Received-SPF: pass (google.com: domain of linux-ext4+bounces-2069-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 12 Apr 2024 10:31:52 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Jan Kara <jack@suse.cz>, Alistair Popple <apopple@nvidia.com>
CC: <linux-mm@kvack.org>, <david@fromorbit.com>, <dan.j.williams@intel.com>,
	<jhubbard@nvidia.com>, <rcampbell@nvidia.com>, <willy@infradead.org>,
	<jgg@nvidia.com>, <linux-fsdevel@vger.kernel.org>, <jack@suse.cz>,
	<djwong@kernel.org>, <hch@lst.de>, <david@redhat.com>,
	<ruansy.fnst@fujitsu.com>, <nvdimm@lists.linux.dev>,
	<linux-xfs@vger.kernel.org>, <linux-ext4@vger.kernel.org>,
	<jglisse@redhat.com>
Subject: Re: [RFC 04/10] fs/dax: Don't track page mapping/index
Message-ID: <66197008db9fc_36222e294b8@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <322065d373bb6571b700dba4450f1759b304644a.1712796818.git-series.apopple@nvidia.com>
 <20240412152208.m25mjo3xjfyawcaj@quack3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240412152208.m25mjo3xjfyawcaj@quack3>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wy0RiuiHYUL+un2ur+lKt7TGL0xvo1YRTIp7BjYi5H3IIAi9MxiXXwQlcaU/?=
 =?us-ascii?Q?5zbUg5HT1HgdDiet6UUkZJMcaVnaIfNY5pEoVDo1XdDewc8R2hokr+LKNk4u?=
 =?us-ascii?Q?tEKt6Hd8DcJ+C4FtO71bowjeo0Rpz/hmnxWoYxPqTGX1hXf3RSPrjwB3LyiV?=
 =?us-ascii?Q?EC1Z135/iu+EdezN3XUZW12hD7Rey2CoiSzJ2FVt7UbnpG3FwDiQ3ANggSr2?=
 =?us-ascii?Q?+FP+UdUdUQYTrttjRrOqAnsTkUpcfHEw2wcFLOvVWtaeSuWJcflNBzE82a3C?=
 =?us-ascii?Q?znXIlzsCUCAYRxAp/oi4sjIzvvwOGZ57aq7a88daO0zIqFSYXxtbEKDLSSeI?=
 =?us-ascii?Q?J9dSMdNDmOGl2LOMaY2pIHDnwAJmY0ibaDDQ+/9Dpa3YkL5Q5zM2RLJjSArm?=
 =?us-ascii?Q?7qscihtwZxp2jjI3YZYmKmQRTF3tFd3rPb8Jnr9X4cvQHn4VPximPXhzaQkJ?=
 =?us-ascii?Q?TZjRJiaq1E2DyyjTq3+Z5woWX3R8ZMFcY7M3wVKfn0R6CXkhXAaicaSF3+Cl?=
 =?us-ascii?Q?VnZxzasTvN/Rb8lpa3gDHYBjCtybwRZbCDR3xggNJvWan1JMoAlB7LsOLP5d?=
 =?us-ascii?Q?Z2RP2AUZMO5eszQzlJnduaeOVcd8jHEyHvsY8Z3pEuSGx/FnFSncKNhZCQny?=
 =?us-ascii?Q?hx1isqhIf6P+AGGKM4dmHDQZEjs+EVS13YdAkYOUb5rb8D/fOD/AmOG2T0Gn?=
 =?us-ascii?Q?zKdm6l75WMV/ZwpgwvWXTm41BwhGxk5lUpoHa5z1HIYiHqiP/B3KVlx4ETB9?=
 =?us-ascii?Q?baEPlgvizjFNDCynhmHuIrsNfmRsWCs7maCEPjbWp7aFaZu0N6iXGQ7c+Hnw?=
 =?us-ascii?Q?fJ/15yYJSP3QpazSkTI9XTCeOC/iRjnrqh1lr7r6jAeiZYWifaIshQWWNlWX?=
 =?us-ascii?Q?gEe0zL7aQGZNvNmej8S8jY1jAlvAT9/PugsTYMXS9Kf3NbF1ufRyqWTpsvS6?=
 =?us-ascii?Q?OHxQWyXNfNDPk5Wva/oIZvHtKTK4OTv3SeaOJv5RrtrJQ2/jgfqmRM1BdM68?=
 =?us-ascii?Q?LiSGVf6KK/ApXq2Hg0B4GYtyGmjOBxECVtlxNgONieeHB6nFs2lxvaINE4M7?=
 =?us-ascii?Q?IAj61nUtIJD6TX6JPVDVEUnW2NdP7Og8SC3tJasa9GY9hT+bDqfdSMl7PC9X?=
 =?us-ascii?Q?YtbG/M2HnBO1tRfRpu0XFDSHGb9Gk2dkNjB8E22FAdn3QknjhRxqjY7ej3ds?=
 =?us-ascii?Q?cAS7GzyKzxHgsUk0rNfcRCL9F3taL1d+wZe4cph2gVdtPpQdQYDQsRIZ/beb?=
 =?us-ascii?Q?azGy08LVk+UEcB9kc6k+pvlh0E/CGzU1Y+Javg4uSb+WJd/yzgBBnWopai+o?=
 =?us-ascii?Q?Dix0xD4ZWY5ds6KqBxEweK0WH8gKRx+jYv3bb7dCzPh+3XIvNredAcXwDmSP?=
 =?us-ascii?Q?QQlUUW1Of+++wpyVfEnMhxTMm5R37H5gcnopbk38m9KblkZIcHiFASnpeU55?=
 =?us-ascii?Q?5aDBJHv/aD9wi2MFkWn5f1f6CmkgBxj/Tdh50VQGW9V+SdBql22p7h+TmeDe?=
 =?us-ascii?Q?AUh75+SmU4njALRSUH2ei52eHtRbKFcGoQjDH27Ut7KGURCYGDucpagRkIEZ?=
 =?us-ascii?Q?yvjF711H8JPwiY6Ro2Wrm4MPUuBES1AYXlNVHr/fRREG/fUaCuRQaVytJwZJ?=
 =?us-ascii?Q?hg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54903b96-ce05-4975-a848-08dc5b167306
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 17:31:55.8645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ukIFd0MmWSnvilxhgKJD8h855BSLp6r77NJh+CucQQAZA9nrn8bffl090+FA3iyGLG35tFPNLyswRCazKgduXv0rdkFRRISe64n4ymD+dLc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8350
X-OriginatorOrg: intel.com

Jan Kara wrote:
> On Thu 11-04-24 10:57:25, Alistair Popple wrote:
> > The page->mapping and page->index fields are normally used by the
> > pagecache and rmap for looking up virtual mappings of pages. FS DAX
> > implements it's own kind of page cache and rmap look ups so these
> > fields are unnecessary. They are currently only used to detect
> > error/warning conditions which should never occur.
> > 
> > A future change will change the way shared mappings are detected by
> > doing normal page reference counting instead, so remove the
> > unnecessary checks.
> > 
> > Signed-off-by: Alistair Popple <apopple@nvidia.com>
> ...
> > -/*
> > - * When it is called in dax_insert_entry(), the shared flag will indicate that
> > - * whether this entry is shared by multiple files.  If so, set the page->mapping
> > - * PAGE_MAPPING_DAX_SHARED, and use page->share as refcount.
> > - */
> > -static void dax_associate_entry(void *entry, struct address_space *mapping,
> > -		struct vm_area_struct *vma, unsigned long address, bool shared)
> > -{
> > -	unsigned long size = dax_entry_size(entry), pfn, index;
> > -	int i = 0;
> > -
> > -	if (IS_ENABLED(CONFIG_FS_DAX_LIMITED))
> > -		return;
> > -
> > -	index = linear_page_index(vma, address & ~(size - 1));
> > -	for_each_mapped_pfn(entry, pfn) {
> > -		struct page *page = pfn_to_page(pfn);
> > -
> > -		if (shared) {
> > -			dax_page_share_get(page);
> > -		} else {
> > -			WARN_ON_ONCE(page->mapping);
> > -			page->mapping = mapping;
> > -			page->index = index + i++;
> > -		}
> > -	}
> > -}
> 
> Hum, but what about existing uses of folio->mapping and folio->index in
> fs/dax.c? AFAICT this patch breaks them. What am I missing? How can this
> ever work?

Right, as far as I can see every fsdax filesystem would need to be
converted to use dax_holder_operations() so that the fs can backfill
->mapping and ->index.