Received-SPF: pass (google.com: domain of linux-ext4+bounces-2070-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 12 Apr 2024 10:32:44 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Alistair Popple <apopple@nvidia.com>
CC: Dan Williams <dan.j.williams@intel.com>, <linux-mm@kvack.org>,
	<david@fromorbit.com>, <jhubbard@nvidia.com>, <rcampbell@nvidia.com>,
	<willy@infradead.org>, <linux-fsdevel@vger.kernel.org>, <jack@suse.cz>,
	<djwong@kernel.org>, <hch@lst.de>, <david@redhat.com>,
	<ruansy.fnst@fujitsu.com>, <nvdimm@lists.linux.dev>,
	<linux-xfs@vger.kernel.org>, <linux-ext4@vger.kernel.org>,
	<jglisse@redhat.com>
Subject: Re: [RFC 00/10] fs/dax: Fix FS DAX page reference counts
Message-ID: <6619703c781e4_36222e294f1@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <66181dd83f74e_15786294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <87frvr5has.fsf@nvdebian.thelocal>
 <877ch35ahu.fsf@nvdebian.thelocal>
 <20240412115352.GY5383@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240412115352.GY5383@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mhwejgf1I+jatneDts8L9OabCk7hEYEx4TUcKNPhRoRa0Ym0/m4n4DULp1oR?=
 =?us-ascii?Q?/dIqtSyfg4C0F1ahMfzOuIpiZNNHUuNFNxtZeZWgh0T4BqK+89h9Kd+seoKb?=
 =?us-ascii?Q?TjtWjhJy7HPB1/2G6qLg+ypbS6oxlDEn0BbwK8hEx6Sk9PD9DygQgWCbPd3B?=
 =?us-ascii?Q?cGXFvrrpCD4wNDWLkzpnKyu49f8y8yMGqf7jyEywa/iJfjDEDeQShObkewxE?=
 =?us-ascii?Q?cGfnyuhqcYuE8FsXw3TQLWzmzkNa8fudv7UUCBb6/PTVzy73uAGg4SxOZQ6o?=
 =?us-ascii?Q?+ndt7UVjlZIuHwcEAEnbk+kytNx9fBny0F0q8Uy8GQZ+x4ekvuGdO3Kjg/U7?=
 =?us-ascii?Q?s4jNVShREsex6FP3xbQNLGw5iB7wOCqFnJUm8rKsVN05auuVvRqSIXfFZv50?=
 =?us-ascii?Q?fT2cOzVrqp2MqVttXM7t/M7vhA/fuWehicuqb3u6kL2yi+zM+8JQLDECkP1F?=
 =?us-ascii?Q?jDHm/dzupi9TpdDK2V5oyuw3Bpmh8+TH/v3jEZnLn1gpu3ldD5oUveoUGsA3?=
 =?us-ascii?Q?5oqXylVBKcy00RU05Secysvx209knLjV0mLLpDuYCnJC+jPOtZx/OhDEuTzd?=
 =?us-ascii?Q?dQ6SPqSkIGzDU6fsMp1mgxprnf09+b0KPREyGe+EPe10vs6KvozN7TibrpQk?=
 =?us-ascii?Q?DHDIxXklecNkZcDFhfgKdlxEXYDtUI1RI9B5Z3vjKNB/fq3o9YcJB9hT49TZ?=
 =?us-ascii?Q?G5VdSNj3RxS5MlOVzdCcyDNiamytS6NtW0m8bzqNqicSFQafwjmMayFEMJw7?=
 =?us-ascii?Q?uUgqQFPij4m3dTXwtH1kU5Z7Brfdhhfq3GKQX/T75I4NmLjJL33fbx1NGab6?=
 =?us-ascii?Q?ME6zmfcwevRpO/SqZ7BsaV1p5cEl4UPBFw2SaNirjcrj3t6an6H7vFUJXWEP?=
 =?us-ascii?Q?eC9FQor8pCx6D5UIt7HxHXG/yVJr5zeK0jfmUWZfN+mptV/+XbkzF1sRqGzB?=
 =?us-ascii?Q?zqEWwb66Zx1hXT2DlSxNCTz4TS48plxEjsEFw3fGYGmpyz7O3PzCvqyVUJGG?=
 =?us-ascii?Q?0jLs+6TovpCl5t9I9/d1vHPyQgxp9YNGWCoAnlRB/jAko73wKAwzH4tokH3M?=
 =?us-ascii?Q?j5a6C1RD87vHoeUTI4qI/AFiJ6BfNGdJqiOflmvU4P72NbGXmV1jET82EaJr?=
 =?us-ascii?Q?N/tx+Yhrjadujp9dxJyEokYblAK+wm5eiql8PUhugRlAHt++Ywxw6wUgGP3+?=
 =?us-ascii?Q?kiPMTt6s0h3bK9XMI2zWtCCwd73BugnsawEG71K+cxg6f/6UrVw4LMRS6Nmr?=
 =?us-ascii?Q?eDwLU4CoSeZ8TLwj4ows819iqp6qjOBOI/LwkBRvcpza4J6C1Xp1B68S1bcK?=
 =?us-ascii?Q?g0SlZNIVWChrQha5s5l9LpRu/ry92GDP+VS4RcGAKoY+s3fa0NJdLx5fT7M+?=
 =?us-ascii?Q?cwhQnfywRJE5iG7X6p7kjV1HwO044K5VgwILeKmxrfJGF67I/3IQzJ2WLrLn?=
 =?us-ascii?Q?mrXcXTlklTRlGIHomgscRggMf2DQYCfpdUfRWYkudn7zJXg/W8oLlauqeJGB?=
 =?us-ascii?Q?jAvvjEbgKBWP1NKLxRBa8BXk8gAzjEPdP4mxGlR2g188zuIcAUWEZooAJJxe?=
 =?us-ascii?Q?j9q8q/FZrtgIkVZNQ//N/hKn6IHPc/QanfZMlrIPnPE1yDfuBIwIHwaAuoRb?=
 =?us-ascii?Q?6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d159644d-d84b-4655-e837-08dc5b1691af
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 17:32:47.2452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kfny2RppeUhQlyT47Vx23BfvjBlvcHmWLoYwL3rWAXQs/m2IyBBBSMIz+Ay51+dLmAMrGsCvddQ+xFFjzVIAHUlcwoqslO35QSNUpm6dyRU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8350
X-OriginatorOrg: intel.com

Jason Gunthorpe wrote:
> On Fri, Apr 12, 2024 at 04:55:31PM +1000, Alistair Popple wrote:
> 
> > Ok, I think I found the dragons you were talking about earlier for
> > device-dax. I completely broke that because as you've already pointed
> > out pmd_trans_huge() won't filter out DAX pages. That's fine for FS DAX
> > (because the pages are essentially normal pages now anyway), but we
> > don't have a PMD equivalent of vm_normal_page() which leads to all sorts
> > of issues for DEVDAX.
> 
> What about vm_normal_page() depends on the radix level ?
> 
> Doesn't DEVDAX memory have struct page too?

Yes.

> > So I will probably have to add something like that unless we only need
> > to support large (pmd/pud) mappings of DEVDAX pages on systems with
> > CONFIG_ARCH_HAS_PTE_SPECIAL in which case I guess we could just filter
> > based on pte_special().
> 
> pte_special should only be used by memory without a struct page, is
> that what DEVDAX is?

Right, I don't think pte_special is applicable for any DAX pages.