Received-SPF: pass (google.com: domain of linux-ext4+bounces-2088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <db13f495fc0addcff12b6b065b7a6b25f09c4be7.1712796818.git-series.apopple@nvidia.com>
 <748fb175-3c5b-4571-9278-1580747a746a@nvidia.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Alistair Popple <apopple@nvidia.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com,
 rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com,
 linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org,
 hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com,
 nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, jglisse@redhat.com
Subject: Re: [RFC 05/10] fs/dax: Refactor wait for dax idle page
Date: Mon, 15 Apr 2024 18:41:51 +1000
In-reply-to: <748fb175-3c5b-4571-9278-1580747a746a@nvidia.com>
Message-ID: <874jc32f1e.fsf@nvdebian.thelocal>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HknGAqPWFN87TD8HJvvpuKbwuoXJ9T4zFhB3nDzJEsKGnI7R7IMDWj8fkG4V?=
 =?us-ascii?Q?ziuCjBSb9Mp1Ip2TFUButN2qppDCQsC6sZWd8/IzMqEPXU99MQFgTu8KK3+z?=
 =?us-ascii?Q?VknbdqHaEGvBm/VOeqnP72FXCTM0sG1gsYc5tG0h2tg45XGswteHman2lGAY?=
 =?us-ascii?Q?zCmHBA3JQJcEaernydaURX3uhaUKVFb4x8JQSPnfcBQphVTmwXpChA1/JsQb?=
 =?us-ascii?Q?dTa6+y06lNwE1Rf+UeWVejb1qyPMHJGK6Jrn7EAYud5oioFGLUHDqEpTsXe2?=
 =?us-ascii?Q?eS4cheaJZHjPvuZadov4Z00ftFioaIUn4K6cQJuiw6GHNmuaqTnSF28b7diR?=
 =?us-ascii?Q?zKgz8qQ/Xjw/Tv3gzWlNliuIo2vwCotLbaSIB1vNkQAEyZ/M+f2q10mJZs7p?=
 =?us-ascii?Q?nupfPnRHZrZGpItf0FAWLhVJ5L2mxf+aQmoiN4waGuKkAlHVzhnqDVgrWfMx?=
 =?us-ascii?Q?/+3LNoqXeyIl5/vC6UsyE2gupSsCT44Sk86q16RKtezy/jUvS/yIRpylU47H?=
 =?us-ascii?Q?q4fgaYQlW88da9OgDFnDDhg6oSPl1Lxj9fpcNg+4DDOXOASj/YMBe+3t61jM?=
 =?us-ascii?Q?RcGglEAtVqsaYtwg4D36BZTRIY7JRu8emObXr6U6YPSSxNliLq/EW+92kmqc?=
 =?us-ascii?Q?CFVVniOXpnDulq4YuTAwh99Rw8ArBtkSVSfKGVLhvrM7CzN/Goq4CjtcQcvd?=
 =?us-ascii?Q?VA1OffOehGJ9FrwfZSmsEiQpyhYPrH/I99q+r6Uxeb9uXLWRUgCZfoe2ASyy?=
 =?us-ascii?Q?Mf/rqYI42YyoAnSSYjfneFM94GN9uRIHGUDoGITOA7rSQ0eD2LcbeiO5sGSr?=
 =?us-ascii?Q?BeH7ISM0s8KQTiveRwidgrqUUTUz+MDbJQMxQle/AFh+LItTKg27lt9ArkpD?=
 =?us-ascii?Q?BIWhTm+Xpy6+b1eZ3KKDI+ysQWNagCjoSHgF+xOg1S+B2a7Nb5ZEAl3zfiIy?=
 =?us-ascii?Q?2myeScBIWfuWrq7wfZTY9wQXe3QKktJa+XxNDYNkUiTcsyjp+dhYuE9R1xlU?=
 =?us-ascii?Q?n660YHPWGViX1BsMroFeclrhHw1418tLX5sAkyOm6DEW1BA4eU1YDJeFWH5J?=
 =?us-ascii?Q?eZeYjFVM9q8Oq6UUWdPr4BTMWkcyEqtG47e47QULsDjVfv7HlG0vNi2MSlVR?=
 =?us-ascii?Q?5q1GY0DpzaZxx7ytTdpZvgI6xu6vcbV7MkOSzchzYBsM5lChRaoZXqHOhBeN?=
 =?us-ascii?Q?Q+sl+xiFoMXkWam5Tlz0yUJWnpXqk+C45IivO5j6De7f4ClygJUmJorcfsyY?=
 =?us-ascii?Q?KRZo+BaOeDGa2vwWkdyqCAGKIIuHXU1b5eUlvb4T5WhTeDBomF1ECSiIQmyz?=
 =?us-ascii?Q?BPpqxIbdDHzh9FTKeJuXNuHY/ufh0ojfbGWHgjY2/1O1xU+CrDyjbTB+/af2?=
 =?us-ascii?Q?LI5WOTw52bvdtFSEPgRUZ0IRxAAfCbPTTt6JstcM204FndNXWkAuPNHS17wt?=
 =?us-ascii?Q?6jromjAVZa1jbIaqWnpYjbpbrW4pYgoVvY3s5KhouggHOrZAuojOCIZ1aGs3?=
 =?us-ascii?Q?prLDgiAM9St/6YmVF+lFsBIQMwdIL9T5YjGO24FqUhLL/5jfNog8iRmLcjVj?=
 =?us-ascii?Q?ab0pf7sn74xiaMXspoG5Kgx1SxpgI+lh5CUPbfn3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 713834f8-db47-4c5d-1391-08dc5d27f17b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 08:42:11.7223
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mzuc2l8rRaqZ1iw91F8W8nyzrwO7GOwJhzL3aT7WmEXgwtiIs3NH2TxSMKnvgfrTY+3h14Ma5Q8ekW+BJD+7ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8290


John Hubbard <jhubbard@nvidia.com> writes:

> On 4/10/24 5:57 PM, Alistair Popple wrote:
> ...
>> diff --git a/include/linux/dax.h b/include/linux/dax.h
>> index 22cd990..bced4d4 100644
>> --- a/include/linux/dax.h
>> +++ b/include/linux/dax.h
>> @@ -212,6 +212,17 @@ int dax_zero_range(struct inode *inode, loff_t pos, loff_t len, bool *did_zero,
>>   int dax_truncate_page(struct inode *inode, loff_t pos, bool *did_zero,
>>   		const struct iomap_ops *ops);
>>   +static inline int dax_wait_page_idle(struct page *page,
>> +				void (cb)(struct inode *),
>> +				struct inode *inode)
>> +{
>> +	int ret;
>> +
>> +	ret = ___wait_var_event(page, page_ref_count(page) == 1,
>> +				TASK_INTERRUPTIBLE, 0, 0, cb(inode));
>> +	return ret;
>> +}
>
> Or just:
> {
> 	return ___wait_var_event(page, page_ref_count(page) == 1,
> 			TASK_INTERRUPTIBLE, 0, 0, cb(inode));
> }
>
> ...yes?

Yep. Thanks.

> thanks,