Received-SPF: pass (google.com: domain of linux-ext4+bounces-2093-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 15 Apr 2024 13:51:33 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Alistair Popple <apopple@nvidia.com>, Dan Williams
	<dan.j.williams@intel.com>
CC: <linux-mm@kvack.org>, <david@fromorbit.com>, <jhubbard@nvidia.com>,
	<rcampbell@nvidia.com>, <willy@infradead.org>, <jgg@nvidia.com>,
	<linux-fsdevel@vger.kernel.org>, <jack@suse.cz>, <djwong@kernel.org>,
	<hch@lst.de>, <david@redhat.com>, <ruansy.fnst@fujitsu.com>,
	<nvdimm@lists.linux.dev>, <linux-xfs@vger.kernel.org>,
	<linux-ext4@vger.kernel.org>, <jglisse@redhat.com>
Subject: Re: [RFC 04/10] fs/dax: Don't track page mapping/index
Message-ID: <661d9355239bc_4d56129485@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <322065d373bb6571b700dba4450f1759b304644a.1712796818.git-series.apopple@nvidia.com>
 <20240412152208.m25mjo3xjfyawcaj@quack3>
 <66197008db9fc_36222e294b8@dwillia2-xfh.jf.intel.com.notmuch>
 <878r1f2jko.fsf@nvdebian.thelocal>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <878r1f2jko.fsf@nvdebian.thelocal>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XHiiGmP+OTm5MPixlclP5AYnjK6Q5imTeixxYawG+Sysk6lfL2yVQ96ZoMBm?=
 =?us-ascii?Q?ewpOmgX9oXc7I2Ps+VERKwX6t/WEVvkItcP82TQ8LHZ+PlPjS3/gNHR3Nanh?=
 =?us-ascii?Q?BjsFm9GgCtAfmGdnIzzimlSTQZ4OBGOyKfZJlAjAQBx37zD1wJi3mo7SgPiX?=
 =?us-ascii?Q?Azo75fnJhd4mQcS1s2waKIff1SGPyPmJ+zb7SkIOVCsEz30o6R/MfwwfyXU+?=
 =?us-ascii?Q?BVt+DsR1GIGyO4W7qxQO2fBGwmXmqn3ABYg57Nr1e+1SRDPrUPIrqvlYPB1x?=
 =?us-ascii?Q?DlDBe3Mur6pHb+TGJw1yV2VOq2UlbJb54WHdVhoyunsx3qyHsOfqnw7biR1R?=
 =?us-ascii?Q?e3wP7aRpjsK7RgkQT0l85PHAtFO1gNbDyslS/yHaU0q7fDglvJh9rLINn5TN?=
 =?us-ascii?Q?pSLoKfIPxEg7rY/42R9/K5HR1mHiOv6l0V2hnuQ43u0niXHOJRssSepjcDn6?=
 =?us-ascii?Q?lu1vBTN96d5RxYT4taoXmaW5X8gc+LisVERbdITMqjAi9XKIuXKxjzuC0BBi?=
 =?us-ascii?Q?WwzNrgRNu5Dvjdn3bZUiR2F/lfFUgAnZkUynPLHG2RJVkxtHjyQG9IIcNBrX?=
 =?us-ascii?Q?x+D880B1YIi47aU+WHEXzXSpV/KoBYwrdra+OrF6jQ1tQ+b7lhTP00ZVtMJM?=
 =?us-ascii?Q?g19zsf2C9KxIgoPbalXgfOegyakCXVN/G6JEvRK7M+LPo3yVpA+enIz5PCFG?=
 =?us-ascii?Q?JX7GIPoFcMiHpjUU6vOlAC0iPJ1vpbYxLN4AvgacbrgtaZWZxaPTr7/yFXsq?=
 =?us-ascii?Q?DuGcf8uBHUs8qZ0SW12Jg3f+aMxtwozc8fwtJiUmhXjwgKsymAQJGnJ/5Ens?=
 =?us-ascii?Q?8Lmq6KSdwU/ul+YUKI6Mj7SnOFwEgV9+B/mjmrBGWGIsC7seBfl+iPyGu40u?=
 =?us-ascii?Q?AVGlWo4gu7HWEtz0x+MMalKV4mBa00v/QLgB1uW9n5e8zxuBeayK1FwPk0Bx?=
 =?us-ascii?Q?O5sHbb/G+MHBBUvHOjiYD//bnytyvAJPtHOIHo4IvIJUOYgixb9YuiK1KmzT?=
 =?us-ascii?Q?w22nCTqGA9UzoU3qANtGBP+4ONeJm63emXGcdeoF29kkDm9L9ZLQ71CP+QEc?=
 =?us-ascii?Q?1SifI2Do159qstrEiyE20+aFU8FetW5kaHTOj3Iuk38xMgsNHqF9zHx0GTeF?=
 =?us-ascii?Q?ygWCUyfJ1q61tfs5ypXtMN9BKOLDIm1jUOG+RXw3lRqOEk4vm5jGsQ666wU7?=
 =?us-ascii?Q?mrhK6wNoO97GftxKR+w3GTMAlh2y2IbmzlZpSUPyk03QtoQNN1+1u0wb6k5X?=
 =?us-ascii?Q?das9+txZJV0SEr/DC8tiD9KQnCBXr9MmgzugoTEgxD8upGRxduecNtZygcdb?=
 =?us-ascii?Q?4b1DXoial+EUzikn3g237fQjJdA6nlm6RDWvaX4wzxCl7aigl3cCqFxQ70h8?=
 =?us-ascii?Q?r2TSy1hs2+DvqWOug7VLcfu0ysxYMMXyDHb2Eic/n1kWrKrTmEYyfFT2PMl7?=
 =?us-ascii?Q?/tQWCE8x6m58eSL4fGeNSnmV7eZuVKdJenyB8UrC39K1mzLgtgogVuJEOTu4?=
 =?us-ascii?Q?hjY/p3EnYOI9sjkUgWUPAIXmSz+KToWQOsDrRVPUguydfL1ADt73vjPRi8XQ?=
 =?us-ascii?Q?loMiVnobXkiEqCtw/PY4Cdj3bGxHqMFQD5TaWRPmO/Zh7TFDnlHxJzXHVqeJ?=
 =?us-ascii?Q?UQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fe954ff9-bdf4-4cbb-57dd-08dc5d8dd757
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 20:51:36.5592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZIKl96O+i+I/7FHFYIy+aV+XSakK0jGrjFKdf2XYegzZpb0yPepIUS7CD40T3DXHIlwwbZLSlHbulGfDkiiK1eUpSFHiqxVjL28dHMQt130=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7883
X-OriginatorOrg: intel.com

Alistair Popple wrote:
> I was initially concerned about these cases because I was wondering if
> folio subpages could ever get different mappings and the shared case
> implied they could. But it seems that's xfs specific and there is a
> separate mechanism to deal with looking up ->mapping/index for that. So
> I guess we should still be able to safely store this on the folio
> head. I will double check and update this change.
> 

I think there is path to store this information only on the folio head.
However, ugh, I think this is potentially another "head" of the
pmd_devmap() hydra.

pmd_devmap() taught the core-mm to treat dax_pmds indentically to
thp_pmds *except* for the __split_huge_pmd() case:

   5c7fb56e5e3f mm, dax: dax-pmd vs thp-pmd vs hugetlbfs-pmd

Later on pmd migration entries joined pmd_devmap() in skipping splits:

   84c3fc4e9c56 mm: thp: check pmd migration entry in common path

Unfortunately, pmd_devmap() stopped being considered for skipping
splits here:

   7f7609175ff2 mm/huge_memory: remove stale locking logic from __split_huge_pmd()

Likely __split_huge_pmd_locked() grew support for pmd migration handling
and forgot about the pmd_devmap() case.

So now Linux has been allowing FSDAX pmd splits since v5.18... but with
no reports of any issues. Likely this is benefiting from the fact that
the preconditions for splitting are rarely if ever satisfied because
FSDAX mappings are never anon, and establishing the mapping in the first
place requires a 2MB aligned file extent and that is likely never
fractured.

Same for device-dax where the fracturing *should* not be allowed, but I
will feel better with focus tests to go after mremap() cases that would
attempt to split the page.