Received-SPF: pass (google.com: domain of linux-ext4+bounces-2109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 16 Apr 2024 18:00:29 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Nam Cao <namcao@linutronix.de>,
	=?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Andreas Dilger <adilger@dilger.ca>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Jan Kara <jack@suse.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv@lists.infradead.org, Theodore Ts'o <tytso@mit.edu>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Conor Dooley <conor@kernel.org>,
	Anders Roxell <anders.roxell@linaro.org>,
	Alexandre Ghiti <alex@ghiti.fr>
Subject: Re: riscv32 EXT4 splat, 6.8 regression?
Message-ID: <Zh6urRin2-wVxNeq@casper.infradead.org>
References: <20240416-deppen-gasleitung-8098fcfd6bbd@brauner>
 <8734rlo9j7.fsf@all.your.base.are.belong.to.us>
 <Zh6KNglOu8mpTPHE@kernel.org>
 <20240416171713.7d76fe7d@namcao>
 <20240416173030.257f0807@namcao>
 <87v84h2tee.fsf@all.your.base.are.belong.to.us>
 <20240416181944.23af44ee@namcao>
 <Zh6n-nvnQbL-0xss@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zh6n-nvnQbL-0xss@kernel.org>

On Tue, Apr 16, 2024 at 07:31:54PM +0300, Mike Rapoport wrote:
> > @@ -238,17 +237,9 @@ static void __init setup_bootmem(void)
> >  	/*
> >  	 * memblock allocator is not aware of the fact that last 4K bytes of
> >  	 * the addressable memory can not be mapped because of IS_ERR_VALUE
> > -	 * macro. Make sure that last 4k bytes are not usable by memblock
> > -	 * if end of dram is equal to maximum addressable memory.  For 64-bit
> > -	 * kernel, this problem can't happen here as the end of the virtual
> > -	 * address space is occupied by the kernel mapping then this check must
> > -	 * be done as soon as the kernel mapping base address is determined.
> > +	 * macro. Make sure that last 4k bytes are not usable by memblock.
> >  	 */
> 
> It's not only memblock, but buddy as well, so maybe
> 
> 	/*
> 	 * The last 4K bytes of the addressable memory can not be used
> 	 * because of IS_ERR_VALUE macro. Make sure that last 4K bytes are
> 	 * not usable by kernel memory allocators.
> 	 */
> 
> > -	if (!IS_ENABLED(CONFIG_64BIT)) {
> > -		max_mapped_addr = __pa(~(ulong)0);
> > -		if (max_mapped_addr == (phys_ram_end - 1))
> > -			memblock_set_current_limit(max_mapped_addr - 4096);
> > -	}
> > +	memblock_reserve(__pa(-PAGE_SIZE), PAGE_SIZE);
> 
> Ack.

Can this go to generic code instead of letting architecture maintainers
fall over it?