Received-SPF: pass (google.com: domain of linux-ext4+bounces-2130-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org,
        Wenchao Hao <haowenchao2@huawei.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, louhongxiang@huawei.com
Subject: Re: [PATCH] debugfs: Fix infinite loop when dump log
Date: Wed, 17 Apr 2024 00:33:41 -0400
Message-ID: <171332777784.2749069.11433721296273612273.b4-ty@mit.edu>
In-Reply-To: <20231117102315.2431846-1-haowenchao2@huawei.com>
References: <20231117102315.2431846-1-haowenchao2@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


On Fri, 17 Nov 2023 18:23:15 +0800, Wenchao Hao wrote:
> There are 2 scenarios which would trigger infinite loop:
> 
> 1. None log is recorded, then dumplog with "-n", for example:
>    debugfs -R "logdump -O -n 10" /dev/xxx
>    while /dev/xxx has no valid log recorded.
> 2. The log area is full and cycle write is triggered, then dumplog with
>    debugfs -R "logdump -aOS" /dev/xxx
> 
> [...]

Applied, thanks!

[1/1] debugfs: Fix infinite loop when dump log
      commit: 272173a300822b5cfe19bef597609523baab0c66

(I renamed reverse_flag to wrapped_flag to make things clearer.)

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>