Received-SPF: pass (google.com: domain of linux-ext4+bounces-2137-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Andreas Dilger <adilger@dilger.ca>
Message-Id: <DF4FF2DC-E1A1-4F65-9AED-DDDF177BA180@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_DE71FC88-9358-4DD9-8FCB-DDC637D687ED";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] e2fsprogs: misc/mke2fs.8.in: Update default inode size
 description
Date: Wed, 17 Apr 2024 17:07:58 -0600
In-Reply-To: <E1rx4t4-00073d-1e@zenith>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
To: Pascal Hambourg <pascal@plouf.fr.eu.org>
References: <E1rx4t4-00073d-1e@zenith>


--Apple-Mail=_DE71FC88-9358-4DD9-8FCB-DDC637D687ED
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Apr 17, 2024, at 5:48 AM, Pascal Hambourg <pascal@plouf.fr.eu.org> wrote:
> 
> Since a23b50cd ("mke2fs: warn about missing y2038 support when
> formatting fresh ext4 fs"), the default inode size is 256 bytes
> for all filesystems, including small and floppy, except for the
> Hurd since it currently only supports 128-byte inodes.
> 
> Signed-off-by: Pascal Hambourg <pascal@plouf.fr.eu.org>

Looks good.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> misc/mke2fs.8.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index 30f97bb5..8122e7f7 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -508,8 +508,8 @@ The default inode size is controlled by the
> file.  In the
> .B mke2fs.conf
> file shipped with e2fsprogs, the default inode size is 256 bytes for
> -most file systems, except for small file systems where the inode size
> -will be 128 bytes.
> +all file systems, except for the GNU Hurd since it only supports
> +128-byte inodes.
> .TP
> .B \-j
> Create the file system with an ext3 journal.  If the
> --
> 2.39.2


Cheers, Andreas


--Apple-Mail=_DE71FC88-9358-4DD9-8FCB-DDC637D687ED
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmYgVk4ACgkQcqXauRfM
H+Dxkg/8C1JR5WkZRLc8Mfq5rY0ShxD3iAAgFr87Kc016+B19vn7d2jmAIj4zc3q
CsBEDniA3ylQHguYvsYjKGvMV/koPUqEPntYCNRjapxwOH9JTEkL5EabrkeJkhLf
eAf59VW4p9vBsO+Xzcn+PkMTBtsT63oLk6ClheWDEqL40z3wLbi/GLTYBx6+KVJq
TqvXmyBK6MPLE9pojaAui5F31XqkdWcddlpVpBv1zupFqiPi+uFzkMkKaCuHTY/3
G8kQ35gOXc08etIk33IKk5g6yP9KvktoBI4SBBwnKp280bA+zR+LggHvGSU/31hp
MEvdAO7+ZjdklGFknkB0YBIQqX1+nDR1uubw/YHTbLjLEmlTZzP0X9mW9geuSKnp
Hqlq0REsGntd3KDll7+5lUonUzgQ/dPKxiqM37D2os9xZBAEJ5QFvOsA8uE15x9u
Dy1IzutNO4Y1B45Kag3fNhOHHgi2nXCP6W9oNyRT0Cu37lHjCpS9D5P4b32J7bjC
v0CwU7ZzUgIYBxxsuRgn2GERK3vLfqIaQqiboSEzc3oRCCoC6KcVGbTg9N7jbSnt
AHEg8unTFXBzgEWZhhJLobd5AJcMPnXMeBSKiJhG2Zkza+ZvMETqjg7DF5l5GEx6
4xEhpGaTcppK4rkIcFsT0+fCB+6gkD73QKaV/0N8TDWl2ZZ7W04=
=rGH6
-----END PGP SIGNATURE-----

--Apple-Mail=_DE71FC88-9358-4DD9-8FCB-DDC637D687ED--