Received: by 2002:ab2:3c46:0:b0:1f5:f2ab:c469 with SMTP id x6csp89094lqf; Thu, 25 Apr 2024 23:50:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWOPL5gfCnP2uJNgDi3uBDqW8tZHjWzY66dhdYZ6p5VU1QmjbWOY4LaPu6j8qQNu3Zpwggj2my5TZN4hduV5NbeQ52c/qeeTItGqjOtiw== X-Google-Smtp-Source: AGHT+IGUh6K7knbgAN8/nWHolfdzSCXaM0OFtZBpKxnTbqS+yvCRxijFfojLtbXZksgNGSVkCHty X-Received: by 2002:a17:906:27c9:b0:a58:8227:a2a with SMTP id k9-20020a17090627c900b00a5882270a2amr1490247ejc.25.1714114209572; Thu, 25 Apr 2024 23:50:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714114209; cv=pass; d=google.com; s=arc-20160816; b=Z5kBPay3oo+wwIA+X3zpTf1FfElSAVCh7cxqEKcXqpibz1VNkPTvbNaXXJfTEuIpAC +sEExsRc1Yq1xJqUWbviqzS93dIP6KRpGSP+BnIj5EGISe6WsVoBtHyieYDTTxZJkcny 7nx+YGAqg1ultu7jHD4Xnr9JKjq9e+iMIAAdmBEt1xz+10hZ8J3TMk+M+7EJoFfZ4ciM t0btBNrsScWBu/wt9x8ZM7d55AeHmYVm6W6hZtlLbNoBUwnC8K/70XfqXp973pWF54hx Lurk8NKrN54Hnx0xUxeMKnS4Kcc5EVOYeZFi3W3/R53b1ixbVn/BBOJzhn5R9TukQgSL OhyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=oOh3iDvWfU2xQkc8qDfMvuKOth/slhquYVFXR6lYplA=; fh=eJE5RoRZ/15DIBx4LlAQVadnk4W+FJL3IPJVkpqi1e4=; b=GKNmmKEqawKpA0jh03smYHX6LhvlStTaDK5nKWZwonUoOnVRXMvOGwL9KuwLqoN9UL dU1ZNEiMOuaBtr0ebOVGPyQyZpZxrG4yoKfzzD1w/RKK35z7Ev7AMJ+lZKK05VKfFqCg nEcdHBZgKRYbll4B047Hb+i1YRyAO3so2LF/LwBCpFcqetGijWzFCT4S4d/RR5V3jSMR ddqZIUeAl3FTvV0PNSm92ksDkuCbCqQecHDSYdiTXzOAr/pc3P/3rfVORdFdZZ4dbVNe 0GCCqLxDPAWuvyUu9A/lpkd2r2QCmZrqWjHezmQpUXwBHabKLVIC8fCpWuEt47UH/0n2 XmVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="yzo4DG2/"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-ext4+bounces-2193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2193-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ko23-20020a170906aa1700b00a5212625db4si10307256ejb.146.2024.04.25.23.50.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 23:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="yzo4DG2/"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-ext4+bounces-2193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2193-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0C2D31F24263 for ; Fri, 26 Apr 2024 06:50:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 665B813A88A; Fri, 26 Apr 2024 06:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="yzo4DG2/" X-Original-To: linux-ext4@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C65E517C8B; Fri, 26 Apr 2024 06:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714114201; cv=none; b=u/gYGsAnFTGMT7w0MCiXDgp+Kl7MpkvfIPk26DdUQ0+GihWPSkprbdnH50zwVOHqO9umMqDn0Zwiqs9z7YVQJzXfi+QFYG01c4d1aYl1XAJk9zXBWex9atrTZ0CRr0WNLk111IOFK+MKkHecqQ6snPTq8QAPU+715qJ38piFsPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714114201; c=relaxed/simple; bh=oOh3iDvWfU2xQkc8qDfMvuKOth/slhquYVFXR6lYplA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tlTEJ7s8n5pOgNWbD8KpgXE18oU5r3E3nknRRDhNRjuuOyWvwt8wbjC3dVEF6YcexshyIFgbGocclUkySDjOwLuEOd/23pYT2O1AJpXkxznKjLMVHrsbroAoU15i6EFKHS3rDD3l7ZGaY6y78njujn1ERq+pO/LNelQwfyE+MY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=yzo4DG2/; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oOh3iDvWfU2xQkc8qDfMvuKOth/slhquYVFXR6lYplA=; b=yzo4DG2/PC16+4Q/9Wvwe9vVZ1 ib62SZdaCIxaAr2gAF+fkA8cKuG2JnZDa6VZRAUzGOX/zk3Eiie7X4ihHQLNhq7pr9UyKke2nZR+O KBdI7GiR3domTJ4/SEGYH1/slVd8pN8qoMVscbp9B/Vlz72DzEz+ajx8UsibTR8feE1uwVQZzqiF3 iFdSp8kSAgiMqRaw5LGD4pImoh/X308Ie9ULxxT+F8FW4F2J1xoDJUX9cwbpzgeVyxfhhW8TkRm+F +o0quAfh/PfLlVgud+fHTY0+kyHw0TQY0hH1tjZNx1qd9bUh6QviNuo90XejJpaHln5dsJ35Y77yl WUSPfkWQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0FPB-0000000BMRG-0ZcU; Fri, 26 Apr 2024 06:49:57 +0000 Date: Thu, 25 Apr 2024 23:49:57 -0700 From: Christoph Hellwig To: "Ritesh Harjani (IBM)" Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , "Darrick J . Wong" , Ojaswin Mujoo , Jan Kara Subject: Re: [RFCv3 5/7] iomap: Fix iomap_adjust_read_range for plen calculation Message-ID: References: Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Apr 25, 2024 at 06:58:49PM +0530, Ritesh Harjani (IBM) wrote: > If the extent spans the block that contains the i_size, we need to s/the i_size/i_size/. > handle both halves separately .. so that we properly zero data in the page cache for blocks that are entirely outside of i_size. Otherwise looks good: Reviewed-by: Christoph Hellwig