Received-SPF: pass (google.com: domain of linux-ext4+bounces-2202-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 26 Apr 2024 08:21:34 -0700
From: "Darrick J. Wong" <djwong@kernel.org>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
	Ojaswin Mujoo <ojaswin@linux.ibm.com>, Jan Kara <jack@suse.cz>
Subject: Re: [RFCv3 1/7] ext2: Remove comment related to journal handle
Message-ID: <20240426152134.GI360919@frogsfrogsfrogs>
References: <cover.1714046808.git.ritesh.list@gmail.com>
 <08f3371e0c0932b5e1367ebbdd77cf61b7e4850b.1714046808.git.ritesh.list@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <08f3371e0c0932b5e1367ebbdd77cf61b7e4850b.1714046808.git.ritesh.list@gmail.com>

On Thu, Apr 25, 2024 at 06:58:45PM +0530, Ritesh Harjani (IBM) wrote:
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

What handle? ;)
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/ext2/inode.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index f3d570a9302b..c4de3a94c4b2 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -615,8 +615,6 @@ static void ext2_splice_branch(struct inode *inode,
>   * allocations is needed - we simply release blocks and do not touch anything
>   * reachable from inode.
>   *
> - * `handle' can be NULL if create == 0.
> - *
>   * return > 0, # of blocks mapped or allocated.
>   * return = 0, if plain lookup failed.
>   * return < 0, error case.
> -- 
> 2.44.0
> 
>