Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp203031lqa; Fri, 26 Apr 2024 21:44:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUqQjmSVnt7YHOGb3BVGcT8EjwYuDE7Ch+nNzlR7jL48bfFLFOMGeuwJx8NE5yHGvqQSUIS1DDhf4qT4w7WvUxUcscmvnOpg0gzCN/46g== X-Google-Smtp-Source: AGHT+IHSZfwzodwdmxhOkW2uylJFDN8K4SwkLvxj/apH3MyjsUrsX82inlJD6DP9ubZAQHV2AwCT X-Received: by 2002:a50:9b45:0:b0:568:cdd8:cf60 with SMTP id a5-20020a509b45000000b00568cdd8cf60mr3758577edj.8.1714193078901; Fri, 26 Apr 2024 21:44:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714193078; cv=pass; d=google.com; s=arc-20160816; b=D3l6g9OKVPguoDjz5gkzaMQ2yG12YPEhiGWWwh/od5I3FRkhtDqejmDImwYsokK/LT du5/EkA6pGhURUEOB56PeZpOsIowJSrAc4sU8H7gK8MHU8OxjjpVDHTZZ1ewNsT65uVG Ypw62L8g/jCZMGSKPquPYNncMNDqYHjWkDGGISnfq4XKxxCaV7xcuSCQdhzFJhkeESI/ Wagz2jYgel7rYRejVs+STYtALhv8dBF7F7SlFELefmkkaVwb9DQjpG3dpUurS7MFJk6R fPlJYqFX4zNr7E2DmAssjribTsKWF7X56GBviHY4JwBSJhFX7rkmajfOKDWpyrPg5K9p fTKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fM+0icHcxjOd5HvMscZat49+YZmTjmzcEp3eWHk0fRI=; fh=PzjpIU1otRd++WfwVxobmlrupoNYAzasaydeZwQ8YTI=; b=Oxc/EmIHzVyKhjBkRoqam2zfTUzAeq/9rO0k9d1bib34KqZswiDRcfiBctMikfLbHL igzHKVUPHyHpqqTM+NiJaFXPBPzRmoyetplVpvblSBYZuLjrLkadhOdP7QCroN006dt/ +wgbAhbPqxKl6N7W1XNkcbHtYBNUXUJga8c23Q7fCNvSTVWM9MmSvedz7VYdim3R7tVX zbQ0eTWU5mSm8Yj6TZo9T0OihkoiZ0MjuYRyprN8UXIJYvIm4LPuxdBpALDf1xWaUUm0 nfpGuMQAoDUwF0JbmVaO9YWR/SzXg25ESVhkXFMlljaGlwDfboO5324fEFl1JrJ1FGvr UdZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hww8PqDV; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-ext4+bounces-2216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2216-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id w21-20020a50d795000000b005726ea813fasi175577edi.37.2024.04.26.21.44.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 21:44:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hww8PqDV; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-ext4+bounces-2216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2216-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9D87C1F22B7E for ; Sat, 27 Apr 2024 04:44:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C69C53E49E; Sat, 27 Apr 2024 04:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hww8PqDV" X-Original-To: linux-ext4@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A9B405C6; Sat, 27 Apr 2024 04:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714193071; cv=none; b=DdMQ0nc8zHQCgUY5tcdRvcoE8Nx8A1yJpj1TmW2gyjyzzhUsT0sil7hGGIKoXhbkisjVVdEs8i5EwCM4+qF52FrDCxsDWZEYKx16p06b6yE40K2iliBSi2YCciMGc4mmhU25WHLiSdCoCsEKItitp/9un7ZrVhanf5nZjPKn/uI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714193071; c=relaxed/simple; bh=fM+0icHcxjOd5HvMscZat49+YZmTjmzcEp3eWHk0fRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jXZjCR5uNCWjH+zHs9O7GDPVUrEXAJBfZAwTH93GJy4CIfmd9y7bGSUSU5KTzMRtG+1vPERVsVfv3Bs5KyL7bbe9hOt0rPoe+OZ+mMRpMxuFPNmGYoGsk/ncqhf6RaVt997sNroILMyVA/tVuoGjY3kfllR2thmf30tvPYqjNO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hww8PqDV; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fM+0icHcxjOd5HvMscZat49+YZmTjmzcEp3eWHk0fRI=; b=hww8PqDV9qork61Y3ewjFZefEK JDU/w6AXdJoz9OdniCjow5WdigZ1u+0yPpIlyzJgm7tltK+Vo/Y1xOHH1Zcy1B5fMOWgxcG6pSQyX oVIo2O50RHXBHbSbhbH8T4y1dlcetrwUVBs5Aq6GvvXo1z3UIxWyZcYMZVWkyY9bZAFyHvA7T0RLW fFEwJigoBmu4eboGkMdoZG4SCBBapImEldqJKezItfY3iaiKoFUGzAPchfuHuQdbc31oGA+miOKIc TP1iQvzTIfiCwE275XEM42jyhTH58v21CX974DWSryl6j6hZAKtuKcaSWKcS2Dgic9cC398QoY1Ze kpU5u/JQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0ZvF-0000000Eodu-0pSZ; Sat, 27 Apr 2024 04:44:25 +0000 Date: Fri, 26 Apr 2024 21:44:25 -0700 From: Christoph Hellwig To: Ritesh Harjani Cc: Christoph Hellwig , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , "Darrick J . Wong" , Ojaswin Mujoo , Jan Kara Subject: Re: [RFCv3 6/7] iomap: Optimize iomap_read_folio Message-ID: References: <87wmokik3m.fsf@gmail.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmokik3m.fsf@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, Apr 26, 2024 at 02:20:05PM +0530, Ritesh Harjani wrote: > iomap_read_folio_iter() handles multiple sub blocks within a given > folio but it's implementation logic is similar to how > iomap_readahead_iter() handles multiple folios within a single mapped > extent. Both of them iterate over a given range of folio/mapped extent > and call iomap_readpage_iter() for reading. Sounds good.