Received-SPF: pass (google.com: domain of linux-ext4+bounces-2254-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 01 May 2024 13:04:40 -0700
To: Michael Forney <mforney@mforney.org>
Cc: Max Kellermann <max.kellermann@ionos.com>, tytso@mit.edu,
 adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
 linux-kernel@vger.kernel.org, brauner@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"
From: Michael Forney <mforney@mforney.org>
References: <20240315142956.2420360-1-max.kellermann@ionos.com>
 <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org>
In-Reply-To: <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org>
Message-Id: <3HNN4SNRB3DRD.39I8TYZWPN7S0@mforney.org>
User-Agent: mblaze/1.2
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Michael Forney <mforney@mforney.org> wrote:
> Max Kellermann <max.kellermann@ionos.com> wrote:
> > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312.  The
> > commit caused a regression because now the umask was applied to
> > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> > has been fixed somewhere else already.
>=20
> Thanks, Max! I've verified that this fixes symlink modes for me,
> as well as the flatpak corruption error I was getting.
>=20
> > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney=
.org/
> > Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
>=20
> Tested-by: Michael Forney <mforney@mforney.org>

Just checking in on this. I'd really like to see this regression
fixed. It currently affects versions 6.5 through 6.9-rc6 as well
as all longterm releases.