Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1380708lqm; Thu, 2 May 2024 13:00:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXK4hTQA3tMLkqDrRc4jXO22aRnMfoICfiaKjZ8nLVryuiKrLI34lXv0Y4HhSFhR7ToEOnS+T8ok8Cd3JzmdWdJA/ug8CfgmaFl9f7gog== X-Google-Smtp-Source: AGHT+IGvEbwekz4ApoTXdpt2L0urPLtkiICck7QjB6tiGtC21Ujgq9G/zREDG7ibDPDqmyKmOlj6 X-Received: by 2002:ac8:5807:0:b0:43a:db77:100a with SMTP id g7-20020ac85807000000b0043adb77100amr606199qtg.34.1714680030021; Thu, 02 May 2024 13:00:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714680030; cv=pass; d=google.com; s=arc-20160816; b=Uwtp2rYB4tAZdQrRJt1quUKfB3wGffaZ9t3CAQrNSuF/mc5WIn+Y/mJwwBdCdai71G 4TEqHnpsgK5hbgkpx96wkphebVUGsGzNIZviJM8wME1gGgbAU05Oe55bbozojmXW+GyQ WWkmQUzYDImvSiPnrNjTG8UvEY6NvacKqS5+mwR30N6iv79YPTIBMUbjubtuGNjaO4Wa r/vFIN/V37sSKKFp6W5rmqUovKa26zu4dAnsN/y4jXKLaj4U73LwKO0SzDGITMigZYPE Inz1k+qYDqXqF99wRw2ipGMDH54nv2iK90IXBICfXdE4N8j3hF40qbEYUrRHdbxlwshb Lv1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Lrv6PuMICPe45nG6IQNLMoZGE1syVHnTdlOolvBM938=; fh=5SdmmzcILpbJV1GxF2dJIof1ap0lwMpctBg0CUNQGbk=; b=TUjQ64H9A+VjPvB0n2wegvb1gvwHv6HV1YtK7LouC6+5XcakBr8jZI6RTOwp/8f78r BObltK2J3T3FOcirjbPdw18vS1Q7wFTgr/izA4eDKSdfbaszWaylZZYeouaVGsdUcgeK AshbgJFPAvqTAspD7KXLDCGxLQoiznRA54hKdJTVJ86KewlwvJIcNKDa5VW4R0Q0Woc4 mZRsAIU421rDxBN7Y1oRMEMEEr0RpzCRmqK4sYKNPm/qMawukpe+twm1a4kvPMZJafe/ UMRrpd9gQqtphmQMxFY/MUJqpvonVKn5G2F+8go+oqJGZmtH6WL7u83BvxopUXRegUPT p7rA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=X123wMgu; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-2266-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2266-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m8-20020a05622a054800b0043aecf949c9si1844921qtx.199.2024.05.02.13.00.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 13:00:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2266-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=X123wMgu; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-2266-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2266-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A8A251C217B4 for ; Thu, 2 May 2024 20:00:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A791469D2F; Thu, 2 May 2024 20:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="X123wMgu" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE6D42AB6 for ; Thu, 2 May 2024 20:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714680027; cv=none; b=mcyaefgPla4Bh/AAXJN+FcnPPNTTaGhMQ3AbfZJDD2KSPweEPl939B12k4Ulwh3jVeCIu9Feg+iVEyYQApXGejXnLOb7qyz4rZRq0tmkaC7W1xs3fD/HvvkvcCeNbpquGmA65kaHcYADDqIwozhDpJfv+nFtTnGP+48jxTWLF3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714680027; c=relaxed/simple; bh=y1KpRPxi6UUt4YkKUpOu2IplpTg2KomJhl1wC4mF4bU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cZ7kXbQ790O96QZ1IJ5Kz6y5Jl7aed/Y4qLU9ROTz/8zPpX9uQ5aCdIY+hBnjpDMCyKrycYMWySvGNKcF00YCy4hKYbRxfKY8+GrC3S40HDHsEsXvnaFZK+oRIB8TdojqrRo2aot3MqLLDI/bUObgT5XyiGaCduXrsM4juiZP08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=X123wMgu; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-108-26-156-33.bstnma.fios.verizon.net [108.26.156.33]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 442K0DZn006120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 May 2024 16:00:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1714680016; bh=Lrv6PuMICPe45nG6IQNLMoZGE1syVHnTdlOolvBM938=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=X123wMguaUunrJAloOWDa77yy2QIb7fV4Lgd//omVBOnCzEKInzMUh12QOivEBuIW 7BxQ+0LT75xnhak8Ykd37+bu89qUcxfh3LXaNdutZG+Mt3lltQUfB71svFj0Mj3kxK 86u12oPqVW0CDEW2ou9UN5aeAUY3XpvlCMC47jXe5dXbIjoZqqeWo9Pew3mWSflAaC jsJQmXepkk5uj1bRw+lR1eQugF3tKInwK6caDvF7nZQ8NUJ+wfopUppkPWUa7n6Qop WCeQ6/U5GoWKekPC22Ez4QJzLG2dxDYP/KjVYZaaSrsVYGZeGWUuvghjS+Yj7FPau6 DGJciBMtLNPsQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id AD8EA15C02BE; Thu, 2 May 2024 16:00:13 -0400 (EDT) From: "Theodore Ts'o" To: Thorsten Blum Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, ritesh.list@gmail.com Subject: Re: [RESEND PATCH] ext4: Remove unneeded if checks before kfree Date: Thu, 2 May 2024 16:00:10 -0400 Message-ID: <171467920457.2990800.8945743113092787242.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240412225026.207063-2-thorsten.blum@toblux.com> References: <20240317153638.2136-2-thorsten.blum@toblux.com> <20240412225026.207063-2-thorsten.blum@toblux.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Sat, 13 Apr 2024 00:50:27 +0200, Thorsten Blum wrote: > kfree already checks if its argument is NULL. This fixes two > Coccinelle/coccicheck warnings reported by ifnullfree.cocci. > > Applied, thanks! [1/1] ext4: Remove unneeded if checks before kfree commit: ea7d09ad7c280122a322f408672ab8d75c1a0e30 Best regards, -- Theodore Ts'o