Received-SPF: pass (google.com: domain of linux-ext4+bounces-2290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7a33ff31-e570-4775-b82f-1c6413656699@oracle.com>
Date: Sat, 4 May 2024 07:27:46 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 4/4] btrfs-progs: convert: support ext2 unwritten file
 data extents
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org,
        linux-ext4@vger.kernel.org
References: <cover.1714722726.git.anand.jain@oracle.com>
 <6d2a19ced4551bfcf2a5d841921af7f84c4ea950.1714722726.git.anand.jain@oracle.com>
 <48787c70-1abf-433e-ad3f-9e212237f9a5@suse.com>
 <8b5107fa-bcce-46dd-950b-775695d872e6@oracle.com>
 <459ec128-eddd-4575-ab28-788f340a6a7c@suse.com>
Content-Language: en-GB
From: Anand Jain <anand.jain@oracle.com>
Autocrypt: addr=anand.jain@oracle.com; keydata=
 xsFNBGQG2+MBEAC42714sRj0ptcjHWMJgkltgglCKCpcjdLTyoFY9dljqJdvrOeojl4N1Ztb
 qMwsnsoFkPiVMUnnU/FgypRlPOzaB4w0R9MTzfvpHKAUNMbaYLquldGJhfuYpTgikr5GztZU
 VGKGsKc4NJzWh6Mfqit2jwurS18RmjxR2dBDKKb5+M5xQ66M5Of2SuuzaM6UnT1vctDN/hWr
 MDqx3CNeQ8Va0i1iCStsdS3ExG6nBVZkL9ZCHHZHi/oqe4bG4vvevRlx57s+uS4WKpAsjlKD
 Z/WHxer9bffB9GuOCngrOTWiXtf1qmgXNs5kXlfb6O3uRv1xnfqTAHdxJ8/pwSShl2aDScdW
 7S265QZ92+ygEJeoviTc8FyrhKkV5c4hAMa9QeiuP6Sk7Mk1G0D/d/DlHQCncQZ/St6q5ESX
 M1LbFLp4amx2yELX0/2lLBXj5s0vQd4mbyz29K5TfiYB/BsEWzSA0gTM9MPdJL3FhIei5VsD
 SQ197dkp3pzqII7/rw77sQs6TFin555Q4DSMsKvKvm/vULpknXMe0DdrHw8ybrY2AjWiTs2W
 1Re7VPORkKxEK7prZ62hghiEvGyZHh0RpnI0aD57R8P3RLJ5P7mCMKimK46SC9fw+zWfWZJA
 EIDccuxTfaLdGPMO8GJ2HnKbvAFbI+nMoSYRvJ6ULvcsH9bPPwARAQABzTJBbmFuZCBTdXZl
 ZXIgSmFpbiAoT3JhY2xlKSA8YW5hbmQuamFpbkBvcmFjbGUuY29tPsLBmAQTAQgAQhYhBKPX
 ZMgfwKRZ10YTjD2+pVga3ljYBQJkBtvjAhsDBQkSzAMABQsJCAcCAyICAQYVCgkICwIEFgID
 AQIeBwIXgAAKCRA9vqVYGt5Y2EAVD/98XUcG+lHTLFvrBn/l+egW5BiJUiUuLIti9wMmj3lg
 Ndv6myanBwjK+v0+RZJ6Vr+oazwTiki6RgnxT3LN9u79T4C7vGuVjqZ205a1vGVN309oMPDm
 +rF4qstsNBMTyE6FfLD1n4ONqgMLATRuk5rPAyfIXQyKy5UomLZo+ISHjpDUt4sXnrsYMz/N
 Ht5w7LRQMmKva92T5cReAvyU8guCHTiG6oN3RCQKlyRmZnFCXa2ov+hYhBrpNikFtPOojGnQ
 JZ/i7RHIU7/ku0/NCGLe+3osdjxaItjkcLP6U7R+WrViweSKocwrtqVIlizSvaDv4MxYM2oM
 aHoAcolFcrpUaqgnUAjhwYRc6CNdB5MroTzrzGnacJ4y7xBlql0+HlrlNho2AVLqvXmar5fp
 uwUHYTeUwsixVHfJL+1sow3Ky7Q5SknDQKd7V7X9X1qs862fuuBD3iPLR4YY5SstF1P0lFrr
 QjNS85TaHFkFhKrXGvhe1WGhum5Fc0hVx88gQBZ2gdw8z4GWKC5esxbvv0lI2UhP89q2ClsY
 ZFS0/Odo0eGgfyxqUGtrouK4cMVXVP+LJb168xt6yOuPMTOLJH/CT9/b3LygcWxn4m/2+XbY
 w1aLKoaO1cKAMSObubp1nQIy+idTnQeY69oKQpxYp97EH7bhYBWfLp/kKJEB98hJeM7BTQRk
 BtvjARAA6w/uFi14uDJ1jAlGWYUpBELdj1NgSAWw6CR6GiS9XPlvtn1uApa80cy/Hm1mqYQJ
 FtC+H3Q0uJRZYol2dvDRJYfDmC4bwoO/mru8ZpHVF2c2rVehDvgzxYJeqH9fJi6fymr9rOa6
 tjX0v8FGKD2pnU8yPXsMNeADdl2lL+XPwVoVhAxx8bpotl8nG14TXQcBNuKxbU4oWRjUZif2
 32CAXkngOnE/dwo68L6tfwBaKNCtXXjv7BMXylXjByMciW1hsR+wwOObWioW8R9uQEDWSNv1
 EwXre7VnuIksrt53Ohfuz458eF5Lg6qKGMYYuLmNwRbFPBeZvx6989P2zKuQn3I6YxzA2sdo
 YIhwJHbJNsf971H3CMFORqiLZY9OQ3Ef6FaLW+KM0p9ezuT9bAomQm6xGJDWC93hM/xLXAd7
 LJxhhxj9rQTwSwxm5eQg0ODntYXeEVfJw/gW0eMf5ivTjzKEF22oTswsEKjnsaZ2UZNPi9Pj
 WbPTEWCzGe4jHLqgY70F7f+OgCoI6Qyvb4+UfXyKez+zuo05Q8TxSFa3diFP5/mRokFMzrmF
 lgnUIyPYrHJWAhizZQveSNQ/5M0C9cVykxhaGaF6r0z8JRxhXi0hAlFIDaGye1k+UB8ZoENq
 JVOcjH5uVcXjdqzEXCa9OCDCJrHYCTu+dxyvR6iFXZUAEQEAAcLBfAQYAQgAJhYhBKPXZMgf
 wKRZ10YTjD2+pVga3ljYBQJkBtvjAhsMBQkSzAMAAAoJED2+pVga3ljYwXIP/2B74x/gNE4c
 5/TGzX3oKEdflBGadVjkirOGM1yjIEqstnCF1UIABhyLJYv9IRaNzhx+ieBDD8knEVAAXvp+
 3b0cnmct+kyvOnXwYpCDJSZcJRE25f8fyTyvo17rUCdP8CennzfB0CFMeis7JhyC3b4ZRaLm
 M87gx9ZJA6z5SLarw5zeI5rHmpQ8FK4hGH82AJeedHKcE+RR8rNOyHpdKDHIEtTxWXTZAC+q
 TxCzgLS6y0OOXDGPifcHjSkW7mSrnVXb/FTIqxVC8ClHwSomp2IQLwqPaew+QNFT3RII7QbK
 vQyq+V0TMXGo7zQQ23SN1N08Nj7E6m/hHffFZvRJ1ibZdHaDDCeDXEZoklttj78325i8yV/C
 XDL6MeirxiJyB8P+Y9eSrIDTQP0jKBPQa6N66QeBSJnMFuDBbP82lovdszeCJq5XhwjDgQ3b
 zAKqel0LTK4JTAlKeYjX678eVUcDAkdfurkLDbYcPd6sOveHr1Wuz3aFgtPVVnVzg3rwi5oH
 rffHVDSAu23bB/YgL+OHJ+EzKIqR+qLaYt0Y+e12zhFBSazVC6NFFQY0A+BV7PPnOLdKF1IE
 kbRwSOU3mzvks433LMKj9vmt5TyRU99OsAIn/BY2nCP3FURwQ1NKQ2vpJ8KnkLCGePkjefcQ
 y4F0QrzFk5Hg4pvnpDur6Cbp
In-Reply-To: <459ec128-eddd-4575-ab28-788f340a6a7c@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WXBId25MOCt2cXFFdEVuK3lDU1cyR1RheTJCUXJ6aDhJTXJzVjVUUld6ZGpz?=
 =?utf-8?B?ZllUdlZQMncyeEpFL0U2QU9QYjgzZ3N1aXpZUGFWRzc2V0taV1gvcnlTYzk4?=
 =?utf-8?B?RVdTYVNMTGhFUmNpKzZPMUE3amE2UTVzMDJsZzhjQXdPR2pzNGxxUzQ5Qm1n?=
 =?utf-8?B?YnEyc2lidVRleGlEdEJoTFJpa3UwTjRvdkhOU09LZ0Rod0d0MHBtdi9uSnhr?=
 =?utf-8?B?dzBPZ09PZWVYOHpDdlRnRXlPOE1DTTNrU1doRmZlbi9pQk9CR1VYTjduMW9V?=
 =?utf-8?B?Mm9EVU5zcjFRRk0xM053YzUvQUdmc3VOTG1uQXVnWmlQVUZPZ3ZIQnFQWEk0?=
 =?utf-8?B?N3RRM3JBOHlLelVCcVZNOXc0aHpnRzcxZEJZOWhYK1A1SjM3ZFBqeHRSNW0w?=
 =?utf-8?B?aElpY0I2UGFVSG5ML09wdExPOCtickdBZU1wUndRUVVKYW9JNVlYMEwvZlJt?=
 =?utf-8?B?S0FjaDAzMkIrTjhTdEQxMGxJeWhwS2lLT3ZicHd0NUdBNDE0N21xMk5PRUZi?=
 =?utf-8?B?T0U5TXEyRTRHVGtQdEpRRkx6aDJidkxJTlU1ZUhLdVRxSEY1MEV5bTE5cVBJ?=
 =?utf-8?B?Zm81V0xXK2k1ZjBTKzl3Rk4wRXYrVzlwT0h4azBRcnpVcldYSm8xSlZ2UmJB?=
 =?utf-8?B?SHZVM3VwUFJwbWd4MER6TU9rYXpvbVdLK1kvbnNNNDc5WmtkcDIrTmhCUGxK?=
 =?utf-8?B?Ny82NzNyMWdKSzVTNzAzREZhWFhTcHFVbHpJeDBjdlhCV1dqc0ZmQkNkOVUz?=
 =?utf-8?B?U3NKNWdpZFczQTRVSnd2S3ROMGdFekErNklUdkE1VzV5bVBKRUdPMEd6ak13?=
 =?utf-8?B?K0ovanBIVTR0Q0VEL0Zubm5SZ3dZN0psYjJpTkFqd3kra2s4Zy9Lb2R6clMv?=
 =?utf-8?B?cmUyN0hBV2F6NE9RYWNpdUd6TUlMQWM2Q01vSEFXdDcyeGJybWthaEZsYXhG?=
 =?utf-8?B?ckgraStqdFp4aTZYNHduK0c3aVVhTENVTXUyZCt4YW8rajNHcktEbEpOdVo5?=
 =?utf-8?B?ays4TVEyTWVmMVZuR2ljRTkvQk03S3p3alNRdnBabGRxTUJJRlhCUXBYTWY2?=
 =?utf-8?B?bXVDWEtTajNRTWFKY3ZySmFtSlRPbXhLSVBKTTVxUDBGbVJSK3VzSXE1MUZJ?=
 =?utf-8?B?WDVNWmFGSDZlU2E5UXJLOWcvNkhJOGUrenRwQWF0L2J3TzFiZHp2b1NYU1BG?=
 =?utf-8?B?TFBEaTRYT2hSMGo5MDZqTStON1hxMjNkTVBxUGJnQ2ZuUmE1SHRUcW9Ga3pE?=
 =?utf-8?B?SzV1U2d6RmpEZVIzdDhmY21NaDNNRyswNDFwNG14LzJjbXNScXpUYklIU1Na?=
 =?utf-8?B?eDVPZzlMaHJDa0UyMHhkVzlQU3YxQXhMYnJqSlA2aUo2N1JwcnFBU3h4U0s5?=
 =?utf-8?B?b2pMMkZzR3RTQzF0KzZ4MXlhTC9rR29sYzVnZkNlV05UT1U4MDFEZHdvcncr?=
 =?utf-8?B?SnJIZXNwb004b01qZ3FKVW4zT0dFYWxhSGNJZlBYc0I1azRRWDhFSTVYa1Q1?=
 =?utf-8?B?OW4vUUo2dmZnV3VYQUZzWk1CT3NOT1ZEZ2Y0emt1cXc5R0VuUVhJRVduU1FM?=
 =?utf-8?B?K2dUaEpPbGoyWnp1c0VHa0NqWllDbUd6UmdyK2pjUmdoZTgrNFE1Qjdxbmhs?=
 =?utf-8?B?WmJ6NURUT0VoamF2ZmYzQlBXZTVKblJCYTIyZlJUSURDSVFPdDRPRHN0aTB4?=
 =?utf-8?B?ZDQwNWpxQk5OakcvMEF4MEdEYUhqSXp3SnQxTFAwa2pEblpacnpPblVOR0VY?=
 =?utf-8?B?QXNTbnhBUld1U3FHZHVHWUdmUTNKZUhXQ3o2T0ZTNEpab1NOVG1iUy9ONmhm?=
 =?utf-8?B?eVF6RGYzWWRuT2kzKzVIM1BXTGxOWUovaWZ3ek5HL0hDTy9hVFZPZHdNVTI4?=
 =?utf-8?B?NmUrMDduM1l5bUNTaUFlb28yQmtEVXk5MlMwckMvVkYyMVllVWRnM0YxVjlu?=
 =?utf-8?B?aks4dS9mS1BTeDJTeTRVc0Z4UURnckRmNWFlYkpZYUQvaFh1NjZETU44QTFi?=
 =?utf-8?B?TmhNUmhpVTJBOExZb3pMM3pxa1hNTVR6OElOWUxBQ1ZMandSc1VxZ0I3MjZD?=
 =?utf-8?B?RCtNK1JWMXZ6cWQ4S29IemRUYjJzN2xEdEh0MHB1Y29qMnFQRmpHcWZld0NU?=
 =?utf-8?B?OUJnTEFPSUxzRXN5Tmh3NDEvT2h2RklTa284T3NVNWNOQjZyUUo3dmdRd1VW?=
 =?utf-8?B?R2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	T6fMppYxxDAu6Xvc62ZqzT9MMbxL/MGLUlSH8H8+TYTklbh+6rPfZNmToPBJvuVQxCp7gil1l+pqCDwlS0vlYZWSn9EjwDa6q4gkJIpLtgYxInJZWf4awloFUYQkNLWtkbge7gCxyJEayTYUiPoVFnj16SGDyNbZpNxfOvDRMRbz4gcCQ77x396xE7cXiuW1dX8aS2/VdxMfTMW2v8E58xqIPfdsk1jstD01rgEM5RAbSPHWhm0t1X1wtyCXsVEbypbmZowYpXHSP23h8gqlPbJtwLSaGdYhFDDbuxORdZrqlnOteCnt1nK2JPpfdFXp7h/7hEbeUHT97j6NKd8m1xBmK4RNCa0rRmjSmX0n4N2AZC9mtKz/LxBvZbzvAMSBo1mDUzr/lX6HPcYndHW+bNwUO/N3RWrlSflak1qK3EtLuqVCPDEa3ONR0rpy6C4moTL/64D3gYhatt+INEn5DdWR9+jPiK7g+hGnMBcYC1Eghu1vys/bfhDGp5G6wZYR+3yRH7HDnU9EOnbK6rJ9+PIKV3vdDPFBCDBBc95/EgLygblc47gX9U1TCS1y+l6V3ZZHeH1ZQyI3zvveuIN103Kwp1WaPemldl/Pi/U9TzI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 620dd3d1-369c-48e8-ffb0-08dc6bc8a814
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 23:27:54.0196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /V0QNfg36Ono5WYQYXfa3gBF5UxvEc5i8PUNEcculgRA9/D5/D3FZELTNPXcQRs5mhOklRHsNa9ee0nGq+WAfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6919
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-03_16,2024-05-03_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2405030166
X-Proofpoint-GUID: ojRcPrdbYnieYgtGqr4WCFtxsY8ue9PT
X-Proofpoint-ORIG-GUID: ojRcPrdbYnieYgtGqr4WCFtxsY8ue9PT


On 5/4/24 06:23, Qu Wenruo wrote:
> 
> 
> 在 2024/5/3 21:55, Anand Jain 写道:
> [...]
>>>> +int find_prealloc(struct blk_iterate_data *data, int index, bool 
>>>> *prealloc)
>>>
>>> This function is called for every file extent we're going to create.
>>> I'm not a big fan of doing so many lookup.
>>>
>>> My question is, is this the only way to determine the flag of the 
>>> data extent?
>>>
>>> My instinct says there should be a straight forward way to determine 
>>> if a file extent is preallocated or not, just like what we do in our 
>>> file extent items.
>>
>>
>>> Thus during the ext2fs_block_iterate2(), there should be some way to 
>>> tell if a block is preallocated or not.
>>
>> Unfortunately, the callback doesn't provide the extent flags. Unless,  
>> I miss something?
> 
> You're right, the iterator interface does not provide any extra info.
> 
> And I also checked the kernel implementation, they have extra 
> ext4_map_blocks() to do the resolve, and then ext4_es_lookup_extent() to 
> determine if it's unwritten.
> 
> So I'm afraid we have to go this solution.
> 
> 
> Meanwhile related to the implementation, can we put the prealloc flat 
> into blk_iterate_data?
> So that we can handle different fses' preallocated extents in a more 
> common way.
> 

I initially thought so, but is blk_iterate_data::num_blocks always
equal to extent::e_len in all file data extent situations mixed
with hole and unwritten combinations? If not, then the flag might
not be appropriate there, as it doesn't apply to the entirety of
blk_iterate_data::num_blocks.

Thanks, Anand

> Thanks,
> Qu