Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp167752lqo; Tue, 7 May 2024 16:22:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRjVNKMc8vXDQFrQda1APJ6xrqlN74CWkCE1MfORuHHbXVwe3dYoywcsXe3Vjy5Zt+1IBZ/wgq1mXOM01m33v8yQpudwYcXpPG4IHa2g== X-Google-Smtp-Source: AGHT+IG8oDHRGnly9XRVmO7OOvFiEFVIvHfbEae46mLaOyXhE/D0OCNYMYt9pwdYEgtisKjVsdJc X-Received: by 2002:a17:90a:af94:b0:2b2:6ede:5ce0 with SMTP id 98e67ed59e1d1-2b6169d9612mr983800a91.39.1715124133377; Tue, 07 May 2024 16:22:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715124133; cv=pass; d=google.com; s=arc-20160816; b=q8My+eCPkKT3o81PuvTipxhUJjwW4LsnnKfR6XBEAMuXZV7pIDVm1UgPfaW8xhKteF DzJDdkEUbb/PvpvxCrCCEsvkVelFNeJowWCAdGLUjlVAVOKTq+vbqSR5qIqEPsAd8b+5 SCTNxSX9Tu0/awj8ofsvZZu4qt7UlmDExDqxj4KnjS65LcsLNsTGHvRtr8TcDakYbCgD j4nidYSOQekFXLhMVaA1P3MrqfzGnCoQzGoAWGsMJ6Vs0HuOv+CG12W+LvuLoiTrlklM bJWwW69uvZavtn51AcqW4SjEvs9V9zY6U5Py9KcEryspvCOgt83cfwg3t4jMdRal6j+h 32sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=E4LG6htVk322z4ErkwjEczI86vSYy/AQbKJj4Rf6hVA=; fh=bF6lhZpIwSlCTa/1xhFv31XdYcx8vyEI5IU0/knUPnU=; b=TGD3ydQLyQf8unM9/hs85BISJkGed9EZx0YMblfIGAPHZ5BKESX/YIEG2jEHUZFv+H goHGycch3R5RgbvT3Tio54s7nbp26mMQg757YSzbf5F3JXglP8f41s6TVp9QQlDn21OF WqtiqYKc92xWGvspuikztkhiUdTogMT1j9XM3e16wbFNVfPY4l8TfyOL5uPRHY+imttF xvucj66LtIaTu8wtuwCQwXvokovOw5+p2HIdRzHIFPIOsFUpG6WS7sqHtNJxD4nQ8X5x oOUr+3DxhF796MqLcYpdxSZHqlDFo97yQ9vPe+NbJQH5jePK+h3wRvxss8omoPqHik2N 5KsQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=KQp8BrbH; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-2352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2352-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a25-20020a656559000000b0061cb56267eesi10006763pgw.788.2024.05.07.16.22.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 16:22:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=KQp8BrbH; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-2352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2352-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D178D281F2B for ; Tue, 7 May 2024 23:21:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A2F5983CBE; Tue, 7 May 2024 23:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="KQp8BrbH" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70F212C7FD for ; Tue, 7 May 2024 23:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715123076; cv=none; b=efqRhwtdd99ZcGrpKdP84SdShOJo0I+98OPK3zHPy328VJp/avYSQp2TWIqPzPnwZ78liqXUM4u4GrmsckvrhKhKiqRU2Omqebj1sEks/C6ol89Oq9443JhU5BuX0Y4eV4QOe/8zBYDF7owwrfMU26G2oa6XhXfukrSQ51XAO5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715123076; c=relaxed/simple; bh=4ki02SrhUgGoO2NBs7aSIdob5gBkMpbDm48dELXE9rg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YmR9ERovE6pNMtaaWQ9pxqrKLY5/bUP7pgsm3wYtu3uEKqopXqKNu/jiQoctOj5J+wQPffgM7GWm0O8DMEpQIJ8eBz7FKuoACKL4SItk9CqcBJ7fXRKPHw5XAa1fqvJZvJKVIGOdrvoKjTnOvOiu6t8sFJs1DnS4sf3XbRRBUIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=KQp8BrbH; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-113-2.bstnma.fios.verizon.net [173.48.113.2]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 447N42VB026194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 May 2024 19:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1715123044; bh=E4LG6htVk322z4ErkwjEczI86vSYy/AQbKJj4Rf6hVA=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=KQp8BrbHEqmHhBTAKaEnbeQr8cwLSTiCebA+l4lvrlKAIwZjiGvMZ1GbljpADqKTy Z/HuFehWcx8N5P0ne/NVNavkMv68l+JJT5m4S/6vVQJpYCaihDDZ7if7GUnXbYrwVS jPeXZs5F78UIaAxyoOBNGaLk0Qq4Djl85dW/uuAhQUuPxVYgyZpoIFq1jTNt5RlQ1V Xfbp3oGXjHt++6IBCAPl1vBopOSL4Sz04OTgQ+TMRou4bSi6zZKrsnnp+xZ+h7bhsW 7tJPj5S+rP570/KQ2sD6w/Mz0BlsQla18Rb40hvSdS9/D7OW2pSPSw1cZfJMjJqg0f YQ0uDA8Gi4bcw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 141C215C02BC; Tue, 07 May 2024 19:04:00 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Zhang Yi Cc: "Theodore Ts'o" , linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH] ext4: remove the redundant folio_wait_stable() Date: Tue, 7 May 2024 19:03:54 -0400 Message-ID: <171512302199.3602678.2811036632858501777.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240419023005.2719050-1-yi.zhang@huaweicloud.com> References: <20240419023005.2719050-1-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 19 Apr 2024 10:30:05 +0800, Zhang Yi wrote: > __filemap_get_folio() with FGP_WRITEBEGIN parameter has already wait > for stable folio, so remove the redundant folio_wait_stable() in > ext4_da_write_begin(), it was left over from the commit cc883236b792 > ("ext4: drop unnecessary journal handle in delalloc write") that > removed the retry getting page logic. > > > [...] Applied, thanks! [1/1] ext4: remove the redundant folio_wait_stable() commit: df0b5afc62f3368d657a8fe4a8d393ac481474c2 Best regards, -- Theodore Ts'o