Received-SPF: pass (google.com: domain of linux-ext4+bounces-2430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <a443974e64917824e078485d4e755ef04c89d73f.1712796818.git-series.apopple@nvidia.com>
 <4393e0d9-28c5-4b85-b603-40e457c9beba@deltatee.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Alistair Popple <apopple@nvidia.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com,
 jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org,
 jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz,
 djwong@kernel.org, hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com,
 nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, jglisse@redhat.com
Subject: Re: [RFC 03/10] pci/p2pdma: Don't initialise page refcount to one
Date: Thu, 09 May 2024 16:14:32 -0700
In-reply-to: <4393e0d9-28c5-4b85-b603-40e457c9beba@deltatee.com>
Message-ID: <878r0ivamq.fsf@nvdebian.thelocal>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zMWkF/hsQPKaZmh832wf/RlFtcGW3dYm8B8bh36PnBK01mrUkBE/RbKZQe88?=
 =?us-ascii?Q?vWROHZVinsGPgoKsWE2W312GVapB7v+04RXtHuwAIennd4MqjA5+/5AbugR+?=
 =?us-ascii?Q?1eytwh8iB6zp4BCvybMcvTfrXkR77SZdahFibpfKE8/bsMs6XXGBZr+qucjs?=
 =?us-ascii?Q?w0bntH5jtE8jlJAmbOit4jgysTfaNJa+x0W9gu/gqsctycX0jc5GGV7vFuE6?=
 =?us-ascii?Q?t2HBd9cqCTaEznatKGCqNm5UlECJq/9u+Xp/bPTOAdoKqqx6++sUrnX31kwj?=
 =?us-ascii?Q?+pVzYK16gH9NalNhwcRQjapE9N+SQL4imjRUF0WkVHkrvw3KCmt0XCJ+SjBU?=
 =?us-ascii?Q?fDBoOyvEvGNaOoQZoGScttWQSWxUxIR0FIzLNzSdoEGso96vqSsyYcLONaMD?=
 =?us-ascii?Q?gx9AKZMNWuNj7vU3JC3Rw6CYzydugXqmdbLHE6AZqLWzNcujdsD4sks086Yn?=
 =?us-ascii?Q?Y3DeDzBrTTneiA1BRYcVsGjBM9QQ2hdO5z1SMPOjc6Tjjids/ZQKEs1eMZc6?=
 =?us-ascii?Q?fjy7R+nemNFbX/ItIgQBD7PszprCOQ5+uoG+IMMnIGRhwjmZkkZvnfeBUvT6?=
 =?us-ascii?Q?vUDHKXaWA43FdNP1hS3XEPw6xDfvUEfet/Tt9an40/BKCv35EPffHdLq73oF?=
 =?us-ascii?Q?TNzg2/KCmCOWHW/zXZyQuDRIrThlFet+JmF6vGLAkR+PNhBmjb7Du9nAEDc0?=
 =?us-ascii?Q?hFZWVra6e8CvzqT+ApAu/y6IB2baBTMvwmAcZflrcVHCucshiRp62TWtBXhf?=
 =?us-ascii?Q?Q5vKvrOouSy9V5vjMMmci4k15bKuEV4dc/hGdbzGzDwOEBCtZQfpM8Ds+pRM?=
 =?us-ascii?Q?5o5ll23Kiul1s8UJl+yVnHIcXtX1ufuhFNIBwMxDvZCCnq9BhcrMgcDuHOWN?=
 =?us-ascii?Q?IjUR6v2UBLbRw6SUqomcnGRVCRx/wgr5X2cO57Z40czRG6ivcv+Ap2z4fWGP?=
 =?us-ascii?Q?Ah/RHCOyMzJI1a/s1bAj2T6LAqkOyrHzUslvpIeFG3pDSaqTOE8oRIFXyl45?=
 =?us-ascii?Q?Bkser+3WgwF70GUo47CiDqwxwvyNmAP9tER7kfMFv+LHe1pH7rDyFKs2LpgU?=
 =?us-ascii?Q?zMWB+scq1eOnf9GCcrLHxielZwOPRSukr9ug0+Nv+MztklOErXcPwTvCCsPY?=
 =?us-ascii?Q?WhjNyAbFeqJ0AU91AM+sitWi4c9qpZUGVF5F0b/Dmm+QT50CP+5EZG1gRa0r?=
 =?us-ascii?Q?EFkQ0YqppO0sZRnpBVigPxKEv1A5k+U3EMWg34w858KY+VjdXOFdQ4dqIG7w?=
 =?us-ascii?Q?rZWMTznPR6ew6rkyYQng840HVMy86gOgYMwolbkxaYj4Yrj11xpvBB+fPua1?=
 =?us-ascii?Q?Xdpw6MyEmsx/QHEn7NZV5jOVOOuU9+j+LFYiGc5OdQw+17oYnzZCPLYmLDGi?=
 =?us-ascii?Q?tGHivxfKNP1gU2Od0isu2FlyF9tss2Okvm9unG71p3yxyhYIIE/QBg8iBUPv?=
 =?us-ascii?Q?7sBEIS8Fof2ALcMxQBR4IUxqBnnGiLZr46uqW8VH71trWhJ4/xlEbBdMbqqQ?=
 =?us-ascii?Q?gcOQ6AijsN+T1rdOe1Mof7p3HE93RV/Db71uDvA32Vl+SjwhyIt2IfP2iS0u?=
 =?us-ascii?Q?rc/aVVj+btTvHLG/WVNOsEoegyqGWJdZJ057JXYJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5175b1aa-c00f-40eb-60c4-08dc707e270a
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 23:17:10.5071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O7Kr7ufd8utlvWeAZTDxRUq6fOYV1BGqrI09i9yR/C5HG2I23iqrRibKZo7KX63VAmFgYEdeBbKxb6GqFhVUdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9343


Logan Gunthorpe <logang@deltatee.com> writes:

> Hi Alistair,
>
> I was working on testing your patch set, however I'm dealing with some
> hardware issues at the moment so I haven't fully tested everything yet.

Oh great. I haven't extensively tested the p2pdma setup yet because I
rely on a pretty janky qemu setup to do so.

> I managed to find one issue though:
>
> On 2024-04-10 18:57, Alistair Popple wrote:
>> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
>> index fa7370f..ab7ef18 100644
>> --- a/drivers/pci/p2pdma.c
>> +++ b/drivers/pci/p2pdma.c
>> @@ -128,6 +128,8 @@ static int p2pmem_alloc_mmap(struct file *filp, struct kobject *kobj,
>>  		goto out;
>>  	}
>>  
>> +	get_page(virt_to_page(kaddr));
>> +
>
> kaddr may represent more than one page, so this will fail to map
> anything if the mapping size is greater than 4KB. There is a loop just
> below this that calls vm_insert_page(). Moving a set_page_count() call
> just before vm_insert_page() fixes the issue.

Good point. I'm in the middle of respinning this (I was hoping to get it
done before LSF/MM but I suspect my travel will preempt it) so will add
this fix.

Note that there are problems with both fs-dax and device-dax in this
version which the next one fixes, but any p2p dma testing would be
appreciated. Thanks!

> Thanks!
>
> Logan