Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2541037lqo; Mon, 20 May 2024 08:51:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVhSsXPCCN7NI+VLfaCeJ9+fun4o+DGJLV/WSSLUoDxQ5ueEnBewjy/ujIZW8KkKPLhdiEHdpWGMsj5DWrCPchDKDEzsuLcmb7CHXMdHw== X-Google-Smtp-Source: AGHT+IGHvplLGarmE7sL7B3KXIFUAsb3hSbgX1qI7ZG9Ypm7ReezqxpCVUxUAd3RfuTotI1XF8Yj X-Received: by 2002:a05:620a:4043:b0:792:bad2:95e0 with SMTP id af79cd13be357-792c7576065mr3645455285a.3.1716220266346; Mon, 20 May 2024 08:51:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716220266; cv=pass; d=google.com; s=arc-20160816; b=PBg5qKWnamIaW6L1m+ubTWUp5eOSICuIRp3ydzsiGUffa4bDktSXQ+eCBofO8dypxH mXo7PEfqECIIkVL+c40VCqPTyMxe62mt6m6f9LaFoUWpPMq4rvag+VtKSQGTtOJlGoCS C3uSIhXVNyMSkZyplhXdcimquXHWk6lLJBdYE2gnDRG+wJO1XC7G90aCWKFFSCJSePYH xa5boNn3zKEPyHkq3kbGs1CmxGMdS50DDnHuhrGXueesLFk12NMIkVj9iefMD5dok9j1 DtYk6Xi3ZRP6VO2uZzQtNnmgMH1cgZgBLaUpz/jrIgGLJjIpDvguVAOOLpJ5lfV0KvuN 42cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=iqHigSQ0qxDkTu/KEBYs+YNNmaCM6a/z+ZttjRRhprI=; fh=vDwh9eUywtCNfeEB0rWNrxt0d7b2eCCILtNFIUdFvC8=; b=ddlTdh6xIntg2HD0XfVRtFxQetGihMkabvREoCZxlJoKX7AwaY8ZXDPGae0lGgs6ga rUhrB1PwL4zWIn3VqdcQnf7O1wZqKR4hZGAzDLA7aOWXSzI865jMo0Y5sBzKiMiXeuKx SVpY2VfcROSv50q3PEpsPoaqrHQ1hdcZBI5ukGzCKC/km6NOHS5LnTS1Qmg2ECtm2st8 y0flMfNrfuvmZvSWhVqGwMMNJSphXvyoMsIjIX48iIV3kZyagTDzvsN27eNgIj+natTc nfU7KaWS1Mm3lgW5pYVW10cIy8yfq3r4tx7455zHIw8sonMU179SysK3f19gLjHO0VbQ VygQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-ext4+bounces-2607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2607-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-792bf297258si393219285a.166.2024.05.20.08.51.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 08:51:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-ext4+bounces-2607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2607-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D2B921C210B3 for ; Mon, 20 May 2024 15:51:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 16528137753; Mon, 20 May 2024 15:50:57 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDC24C66; Mon, 20 May 2024 15:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716220256; cv=none; b=n3FPH7WyVjxI6qFxund3Sc20KZAUn7hIwK/WELf2v5PPkI0Qvv2IGYhTAXjh+hdfw9rplnobFlfX4cALXukGLGX5bYauEhFl+fxq0HYk1uQRqdo3aXQ6ifYrzyLqpC2+DDneLVYzoBdLEgD+7Bb8vhZ8MVs2pDxzEwXVyfq1AsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716220256; c=relaxed/simple; bh=jeid1BQlbkhG+oGn7mKvZgcQUeECcB1Yee8xBttrOY4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RaR+NUq8w+mOKO3e9j7VfrEl1SwqkynoWfJWDFS8WjPDrxKtVhd6AEIYHSK3WsyQ1GWi5eVdC2wqc1u2JTtxImgYeoo3t5z1YuQhBHm2zGa9v3KpYLtai7RkqVxBauBJeqPDDGja+f8ZWZ8a1KGrWNeE3wQE/qg07GP/Rcj0+DQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 0EA1068AFE; Mon, 20 May 2024 17:50:52 +0200 (CEST) Date: Mon, 20 May 2024 17:50:51 +0200 From: Christoph Hellwig To: Mike Snitzer Cc: Christoph Hellwig , Theodore Ts'o , dm-devel@lists.linux.dev, fstests@vger.kernel.org, linux-ext4@vger.kernel.org, regressions@lists.linux.dev, linux-block@vger.kernel.org Subject: Re: dm: use queue_limits_set Message-ID: <20240520155051.GB1327@lst.de> References: <20240518022646.GA450709@mit.edu> <20240520150653.GA32461@lst.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, May 20, 2024 at 11:47:54AM -0400, Mike Snitzer wrote: > Maybe update blk_validate_limits() to ensure max_discard_sectors is a > factor of discard_granularity? That's probably a good idea. I'm travelling currently so I'll probably need a day to two to get to this, feel free to do it yourself if you are faster.