Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp3171807lqo; Tue, 21 May 2024 08:45:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVXa9gDK9w9BTLik1HeA+XmLyoAAVSZp1/QyoK4X6ZiCWWnc17O4LnTU0ecTaAqFMQj2z26xX8uw/UKTXjeO3HFDyspnz74SMRQ0buxgg== X-Google-Smtp-Source: AGHT+IGM4lOfn8Vq8yYCJjuT3501tUcrr+2tNVfgmtIH1+tuG+I6+vPmc9Eewo4s0H62n8LKREeU X-Received: by 2002:a05:620a:244a:b0:792:c524:c67a with SMTP id af79cd13be357-792c75773d7mr4158145085a.2.1716306353889; Tue, 21 May 2024 08:45:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716306353; cv=pass; d=google.com; s=arc-20160816; b=zL2n9E0IrzEhEu7KSKgQqwiDxevJQGGBuLDsUT5ZBwf/p4GddjKJemROQhQramV0kR hPL482pIvfbFiNNFnNhBFvEz9DDmeFV0ynZzvI4rylh2/D7ufMegXYk4CFUp5N13Calw s7p+bCebgxaInGgPJ6li+VXIciBhAwscp4BeD5CVJmO0IiABpg/Ja6ByMMmz8KzAuQsx RPdL1g6npQIiOjvhpQ8N/ASw+hSkn9Vvt+nrdHTNqPW48sh6wLnWTbqVTRhgalUhpF0v qB208+80XNYCOS2jO4eb//MYfHrFJyqt233PlUEImikwUo0xwGSFQHMK/w0y5OTlpF28 mvcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=fBSyg5xRMAlmaP9c4FGvfzgdGgjv2gN6Yl2qAEyO8/w=; fh=rYkJYNx/Q6fjd86C8v/XkdhzqbCOGkTMTD82D+53Mlw=; b=sx9GjV/3IgwOYR5xs14ISx396LYNVcSm80mp05Y49wb5XlmONMIqVosi0w99vySrUZ BM/K17eEHuUNfxngVOK/ODPY4M7ARQBmrWcVW/rL7XF9TXG5Kk4njQ2ah5yZ/QGxFIZy v5Dz3V3X6mc2sgRFjYXQnAaGX4bVd9xViSu9ppIUc6xpvnlcj+6RsmzOLl5HI0r/Fsr7 7BaH2Dsv7ccMEVQ+HZQTSl2UHZPXKOPUp/1KEQxvbKXdnLbqzsz03mKsRMc7W1XASpn4 8j0Lon5x4cP1xSBftY7KNPyP1DMD+fHLCZi6yVPSzzJ4z1420HXC+IiYSDrhdcQajPsX FnpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=KWU2y3RX; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-ext4+bounces-2619-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2619-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-792bf30693csi3040799985a.296.2024.05.21.08.45.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 08:45:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2619-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=KWU2y3RX; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-ext4+bounces-2619-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2619-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6F7561C218EF for ; Tue, 21 May 2024 15:45:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1688142E72; Tue, 21 May 2024 15:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KWU2y3RX" X-Original-To: linux-ext4@vger.kernel.org Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FEC31FBB for ; Tue, 21 May 2024 15:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716306346; cv=none; b=gwSHpkOoHl2UBq7rKvEaygncSIakZ0Pom+uAiRhw1ciX4Gxq2ri35n2aO4I0ygMuL6OgHHn2BGXpyPONYnCklmDkArvbaLELuJMj6Kq1BNLBU73mJPKHjq0Emf2qmtD+j5RCPPWQ3YcFQY9345rMKOTxbRwgKiCq0KkcYeX4r1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716306346; c=relaxed/simple; bh=JiQ17E0QBTkV+Se7Q96uFdgZdo8+hkE/n9fXzqqZ01o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=clYhTDpuD0AAceXNdGcxrC25bcUqaijWRmrBwnIqaeyWe5SQ5Zl5+mFRx8mEubgPfVgpr3tk6hOMcrbHAvsiXKEhL9xC/PWrLKFe4ru6vFa36+UJYM4JNIfcDGbaFS8gkBK+lcvLGR/QLc4qwrcU2t1haCKh0EWbr7q5wbx3510= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KWU2y3RX; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: tytso@mit.edu DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716306342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fBSyg5xRMAlmaP9c4FGvfzgdGgjv2gN6Yl2qAEyO8/w=; b=KWU2y3RXle5w5DQrOGIUA55HkhlSzeJ+aT33D2WOjXE2K5EgYhXclGFG5zIsNn4cF9YM6P pu3AM5I8Y45KnyU89OmpTl4oE1UJenu49KnBfvtH9G/YTY04MtJxoP/MeDGcX3eMynAEpf B8kiWgxF2ok1fKiMxUR/aTD61mWvOro= X-Envelope-To: jack@suse.com X-Envelope-To: linux-ext4@vger.kernel.org X-Envelope-To: luis.henriques@linux.dev X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: adilger@dilger.ca X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Luis Henriques (SUSE)" To: Theodore Ts'o , Andreas Dilger , Jan Kara Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis Henriques (SUSE)" Subject: [RFC PATCH 0/2] ext4: two small fast commit fixes Date: Tue, 21 May 2024 16:45:33 +0100 Message-ID: <20240521154535.12911-1-luis.henriques@linux.dev> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hi! I've spent some time investigating an fstest failure when running it using '-O fast_commit'. As a result, I'm sending two patches that hopefully fix this failure. The first patch is the actual bug fix for the generic/047 fstest. The second patch was just something I saw through code inspection. Note that this generic/047 test also requires the fix I sent before[1], for a different fstest failure. [1] https://lore.kernel.org/all/20240515082857.32730-1-luis.henriques@linux.dev Luis Henriques (SUSE) (2): ext4: fix fast commit inode enqueueing during a full journal commit jbd2: reset fast commit offset only after fs cleanup is done fs/ext4/fast_commit.c | 19 +++++++++++++------ fs/jbd2/commit.c | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-)