Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp25077lqb; Thu, 23 May 2024 09:45:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX8CsSI3CFEYK1syh9cRwGMR7JjCEskiHF53hH3Z1QiXqB4BS6Dc3fRzpa5vjZmdciiNx/z654fmwjfXPb0lYDovZFIDynTOKyLMErHvA== X-Google-Smtp-Source: AGHT+IGJHmTY0ZHQjsjUaygda9e/PgbSJKRxJXh8+kv6PTu2YwE4vy3/gu64u9Uuol5VEria5otr X-Received: by 2002:a17:906:19d3:b0:a59:afbc:1b0 with SMTP id a640c23a62f3a-a62281f75c9mr335459666b.64.1716482754106; Thu, 23 May 2024 09:45:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716482754; cv=pass; d=google.com; s=arc-20160816; b=qq6t+aiim3kxJHXNGHduJufjK5D/+ZwuSlcE0U8Esj4EVbJiCd9C7BIHOPI6NRG5tW IYbLx10yR9IrXLeioAKopHhVSFRRl9s8dO1mNja8Bx1rZ3Mnz8r5wlYewCm1ZQLDZMqC lHHDB0Pu+Ur20MaU0VPnVlq9dMPWE8AmjEIf+2avciRELc/oQhU+Qh7hxjgErXqEJdep a0C7Np3CbC0BdsGDzRba2gUqkzlO7rfHRJOOH9CgCvIT6HHZCoOQVT+wCIa9AUppUDfr ETr4nh2kFJi1bwnyw0SAc0pFZ2561zTKTsntR64WwSQsDEIG9g+VRunabnNcm4mQNSx6 EcDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=76A2SchJx/XQs3JI5IruaZJ74cXb24Hwn2+K3+4a8+k=; fh=2Prxtc9VmqbVp5tUaEUJHvE/Iuz2nCcj2x1s2zHDII8=; b=JyMzUekvj5BcRaawJ0j34fdMq58VKVg0WmuwRsODw8djiew9K89TEuFovF6XXTF3Ua f5Y6o5oQw07qKswwTiiWD2Ubxv1qcNuj9aW2eRuMZLPw5/dFJ7BMAx7MxTtyyMgRKqav Fl5cpOvms4pV/3xXiXZT9/UKe1o+wYfCGbvyG19HBdMZSQMCHlueoN332bQ7dgnz8wxg yPexBldsvv/a/NUdY4EUFGgtE+5KGH6m/he04z1PnDmtAPqEeDukp+0Yq8sfLiEt9hrE kTDtydF4bttpfUEeZS8p/rG4ZPtc/SaMPhw3Vflkxv43EJ+KHiXxLF4vDp/RURm/ld97 9Xbw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=kcl3eoyE; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-2640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2640-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5d0cc8151asi790956466b.750.2024.05.23.09.45.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 09:45:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=kcl3eoyE; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-2640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2640-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D47E01F21849 for ; Thu, 23 May 2024 16:45:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A97D136B17; Thu, 23 May 2024 16:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="kcl3eoyE" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFF0017C7C for ; Thu, 23 May 2024 16:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716482741; cv=none; b=ocu07ylrA39GqiYa1Qqbi63bnothhFIHx+mepRrLxvByTHYOKIxpbBSVvfZSwQkBXcH7tcs3kjpvswooGoPKa6pLbreKjlEiCgozixlh0YQcuGVBGEDZXCF89wAtqEJQAA+hXXiJg4K91n9JZS6z9FE8k1ZxX1gS5Pxnbp+aRdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716482741; c=relaxed/simple; bh=PeE2Iv1cUElnBiThT4jIFU1ihOHGm8Z1qxGwKgRJTAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N++JvuilHRmyRg8Dmi73M7m/GXSUY5drtls274itrbNBY/drr4/PA5IcDt1CQZcnAf7rAZw4mevV02j+Fe8QjgYT5X8MaLRbOEFzzSgpTb+CfMDpDyIsagNIe+TCqMoFA+ut30Qqnep2QErdKqTdariSIE+6a4g+Lqfj7OLu5Ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=kcl3eoyE; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-108-7-50-195.bstnma.fios.verizon.net [108.7.50.195]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 44NGjJlI031728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 May 2024 12:45:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1716482722; bh=76A2SchJx/XQs3JI5IruaZJ74cXb24Hwn2+K3+4a8+k=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kcl3eoyEwTqIqwlQ+1yfhnlEuUVOR+ebptXPpIwcNZjZxh0DsqTXIH+B4SMWoy3YU Jvjy4Lf4duH+yEuQMuLMdZOn1t4IHxW3RtrizNYNv9fbpjKRIRPOpke6chKK7V+nAC WTec0mnUr5r9cQ2lbKiPBPUKCFBuTTJyNi/IRMjLo/QuNmpFC7AmR2UoAIRhdS8SGu gVoGr2bSAea3BqQC3rb8TO+FwVp9j8y47UZ+LgdltsylDRxOsLBf0A5sEuul9U6KpF LbzdLJh/sn34Dv8tqLVbMnbIRi/M8a67AF//y1wElGyqRF/63QrgnPZ0L/h4N4w4hg p8xss9mQEH6Jw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 9E62715C0225; Thu, 23 May 2024 12:45:19 -0400 (EDT) From: "Theodore Ts'o" To: Matthew Wilcox , Dan Carpenter Cc: "Theodore Ts'o" , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ext4: fix error pointer dereference in ext4_mb_load_buddy_gfp() Date: Thu, 23 May 2024 12:45:16 -0400 Message-ID: <171648267844.923789.4231199989954274163.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 10 May 2024 18:22:53 +0300, Dan Carpenter wrote: > This code calls folio_put() on an error pointer which will lead to a > crash. Check for both error pointers and NULL pointers before calling > folio_put(). > > Applied, thanks! [1/1] ext4: fix error pointer dereference in ext4_mb_load_buddy_gfp() commit: c6a6c9694aadc4c3ab8d89bdd44aed3eab1e43c6 Best regards, -- Theodore Ts'o