Received-SPF: pass (google.com: domain of linux-ext4+bounces-2663-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i12284293:Fastmail
From: Alyssa Ross <hi@alyssa.is>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: fix unused parameter warnings/errors
In-Reply-To: <20240528064958.GB1294551@mit.edu>
References: <20240527091542.4121237-2-hi@alyssa.is>
 <20240528064958.GB1294551@mit.edu>
Date: Tue, 28 May 2024 09:21:58 +0200
Message-ID: <874jaih04p.fsf@alyssa.is>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

"Theodore Ts'o" <tytso@mit.edu> writes:

> On Mon, May 27, 2024 at 11:15:43AM +0200, Alyssa Ross wrote:
>> This fixes building dependent packages that use -Werror.
>>=20
>> Signed-off-by: Alyssa Ross <hi@alyssa.is>
>> ---
>> I'm assuming here that it is actually intentional that these variables=20
>> are unused!  I don't understand the code enough to know for sure =E2=80=
=94=20
>> I'm just trying to fix some build regressions after updating e2fsprogs. =
:)
>
> Well, note that you only get the warning at all if you use
> -Wunused-parameter, "-Wunused -Wextra", or "-Wall -Wextra".  The
> unused-parameter warning is not enabled unless you **really** go out
> of your way to enable it, because it has so many false positives.  The
> gcc maintainers do not enable this insanity even with -Wall, so
> someone really went out of their way to make your life miserable.  :-)

Yeah=E2=80=A6
https://github.com/storaged-project/libblockdev/blob/7cd19d14e61c8964187eac=
99cf276e6c999dc93e/src/plugins/fs/Makefile.am#L5

(In this case it /did/ end up with me having to look at the code and
notice the SIZEOF_SIZE_T bug I sent another patch for, so something
useful did actually come out of it this time=E2=80=A6)

> I generally think it's a really bad idea to turn on warnings as if
> they are overdone Christmas tree lights.  However, to accomodate this,
> the normal way to suppress this is via __attribute__(unused).  To do
> this in a portable way to avoid breaking compilers which don't
> understand said attribute:
>
> /* this is usually predfined in some header file like compiler.h */
> #ifdef __GNUC__
> #define EXT2FS_ATTR(x) __attribute__(x)
> #else
> #define EXT2FS_ATTR(x)
> #endif
>
> ...
> _INLINE_ errcode_t ext2fs_resize_mem(unsigned long EXT2FS_ATTR((unused)) =
old_size,
> 				     unsigned long size, void *ptr)
> ...

Okay, I'll send a v2 using this approach.

> You can also play this game if you really have a huge number of stupid
> gcc warnings that you want to suppress:
>
> /* this is usually predfined in some header file like compiler.h */
> #ifndef __GNUC_PREREQ
> #if defined(__GNUC__) && defined(__GNUC_MINOR__)
> #define __GNUC_PREREQ(maj, min) \
> 	((__GNUC__ << 16) + __GNUC_MINOR__ >=3D ((maj) << 16) + (min))
> #else
> #define __GNUC_PREREQ(maj, min) 0
> #endif
> #endif
>
> #if __GNUC_PREREQ (4, 6)
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wunused-function"
> #pragma GCC diagnostic ignored "-Wunused-parameter"
> #endif
>
> ...
>
> #if __GNUC_PREREQ (4, 6)
> #pragma GCC diagnostic pop
> #endif
>
> I do this when I'm defining a lot of inline functions in a header
> file, and some stupid person thinks that -Wunused -Wextra is actually
> a good idea (hint: it's not), and I just want to shut up the
> completely unnecessary warnings.
>
> Cheers,
>
> 					- Ted

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmZVhhYACgkQ+dvtSFmy
ccCNvw//TnqxpUrZ5+5aRgqiVF39u1Snan3ksN/+3zm/CRPHtj0x8TCf2rlSyKwd
CMnGAMD/oroGUpo99+e1YNyOR39Iu7l1UIY1M1uzOIN6aSrKCpdo6O13XIwOq1PC
eKCJ4M+fT3XKFjtR62t1oqYblpcRQAFoLNHLITP1v3Vl7fSfDqBd99/F5lPLuuXW
3Ii8RBnA4O4Fgpfu+x1SMpQNHwXKR3r4kh8JDfkONmobKLyqLR4KC1yDQKyLIt2k
ANnC+kpgT1pNHYAGcxmo4p/KDHHmxx6kWZX2Y5dWI+IDxVOvKuBS0eyDoPiy6pig
qfZyuPn2UZxSB6cZt3OrnTkdwrjG7PaxllGDdaROj5PnpftKtnyHTFvbRi7dBmKa
UANTI65YCdQFRjP8WWpl+4n45Acjc9KEPrE8QF4WckmxVpvQAb89SJZAxgjt1XnC
gxslwPcMWtw23oTuatFJOYTm5zOf1Fwt5fzq5CQTRot7wNg49G6aYru1KjrSCYIJ
IPCQwq39/y5xik6lQphTBWnlDpo1/jiERRYXi/JrirKF0gENiXM2a0KV0vdyp1xy
4WV9kyEOwCcpV5g2PQqplfjLuOlW0P0NUwupXC0p+k+w0eJx+z15n5d4TMeiamDR
s3S/VQ1IDNo7LcyAI34woWesOdFQy8WI54LrfI3DpRj9INpsEgs=
=r9sh
-----END PGP SIGNATURE-----
--=-=-=--