Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp354494lqb; Tue, 28 May 2024 18:57:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV8JSQP8Lvyy2Uc0g5Z2FSZYv1PfbRhKZ+Xmhtg3nSZJfWqdtywPztCqCV442FriwpLd01Suz8E3uI1hY4tg1l+VtogHGcxKVeGPl6mWA== X-Google-Smtp-Source: AGHT+IGghPRIbPiBigWDQ5OiozEBQmXDjLUTPQ+ONjUTZcN1/MZBPu7iOxyftcDhuPDVM9nNXnaS X-Received: by 2002:a05:600c:5746:b0:420:29dd:84f8 with SMTP id 5b1f17b1804b1-42108a99ba4mr141582805e9.32.1716947831553; Tue, 28 May 2024 18:57:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716947831; cv=pass; d=google.com; s=arc-20160816; b=c4zf5gHmNCZJnScFm71zZX0aPbRizuuRNivPp9Q15gKT1qNqlJwmnt0GZdgr6mCLvw UrBxoeoigzU5qgo4k0d6Gus86TsugECgP4uWTnGcxuOxMbXVlNJU989Kei4RApP7EphC 6tN2Rp1GDKJxF3lawqontYXmPAsdwc5kBwk88VjVqzxynCtoqpymbykEvxFaiV4ax8G4 LeQYkY3ZNWGvNNNL6teXwGnRPGkZ7w8GKeEATsKAB+w4Z6F4gEOuZQPd2GoMHW2KsKxU cX5toYAnGfJAPOFy22J6YRcOXBKf9rfl2704Nr+9HPGDPa76rYJKKBJyXrG7ES/WrHR+ ZN8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=SA3fTcT7iYSxePTtaFtUE4a8/MmXF+EmncSV/5Od3Jk=; fh=uPVuEaWmsWadWW+NSH/aeFNFn4Frmc/kchBm168oWL4=; b=zQxanpsMCHbvnFKVebRfi/1toVcFkEU/GQrsU8y1Z0KxPXDI7aAfB7Fm9iXJiAnnPZ oQqzpz8TUhiMvbitvYBzKhDIEx1DWx+RJO2BAduyHry4J2nDJIQ6BQUCTjVT/iJ8Iaj3 o691P3uTbwgDfo5OJhTODmoWN2XxRF5RHD0QZzQWhRp6GQKvcQWRbBhvMhaBpg2USNs9 WB/4oyvGxrAJ4h8l0b3bdN+vQhpWVw9pmbKxA3PtDO6DuZYHeDbFkCfviM6LeGYe0/3F Q8qbnKQgY0MDSw24qXzkvEd7BkQppqTtCPfhWSMamFrnQpzIi6693haf3JkN6GMzuMVg GdQw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=BLvYZ1mj; arc=pass (i=1 dkim=pass dkdomain=linux.org.uk dmarc=pass fromdomain=zeniv.linux.org.uk); spf=pass (google.com: domain of linux-ext4+bounces-2694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2694-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a626c7febcesi550180666b.150.2024.05.28.18.57.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 18:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=BLvYZ1mj; arc=pass (i=1 dkim=pass dkdomain=linux.org.uk dmarc=pass fromdomain=zeniv.linux.org.uk); spf=pass (google.com: domain of linux-ext4+bounces-2694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2694-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 47D0A1F268BB for ; Wed, 29 May 2024 01:57:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60A9F15AAD6; Wed, 29 May 2024 01:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="BLvYZ1mj" X-Original-To: linux-ext4@vger.kernel.org Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D21426AF3; Wed, 29 May 2024 01:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716947823; cv=none; b=fhuZMqImQvyr24XeXFzHkM9JivW/mbRfmtTSgahPs911lapsf1+Rek5/Pv8fn/OMhKplUE4qfkqhvh9aOKf/cAeJBzqMWi7wDbaZMAHWsf8QCLVLYP8Ubi4M3NgDrPMHVj1qdJWoOr7om/Cyvb30lc1xdENgEwvewdV/fypNm9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716947823; c=relaxed/simple; bh=SA3fTcT7iYSxePTtaFtUE4a8/MmXF+EmncSV/5Od3Jk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=goVdEoDKIjdwrwiAiyh0/ooe4/PefOL6AVHujVtlY62iL9XSpsOnJskuu7zq0Vg2x+igPuaNydeW10nzeofROFm9u5A9l+7nAOG5XIg9F8tfiJ3LpNMk1AkvfSKscWqA2rnZqBI9Z8v+Z4SAl1/Gisvim9s0rgQ5Fpm6fi5UtFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=BLvYZ1mj; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SA3fTcT7iYSxePTtaFtUE4a8/MmXF+EmncSV/5Od3Jk=; b=BLvYZ1mjobUUYuRlnEz1zzwo6I wTMeWeJ8ZnV37R/nkMZjMdSrPAak6erbriuu/UyxqMWrcqolyvVALqpotgKTBPtpSp1er/N/H59TH qZexIB5BYvpvs3IpS0KwWDxTPGVLrrZKZogaqyvobFpTul8JPc4Xp4z7y+DHw20jqyQ9j5AiTkGjL fRMqRIy6JugLL02+qMRsoa+PEn2z87az8SiFMzLNGQdt9nmFQAfTE0nKpoUUGeWpQ9H6DOeQ5ZsWP 3pBAyhLBXtVBH/nzlfQUkF2I+fmZeTXyycoIeUUSWQPpoOr5QICvEg+TJC9I+RXrR4g/fBlOU3Ibj c7cOJjZQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1sC8Ye-001pRY-22; Wed, 29 May 2024 01:56:53 +0000 Date: Wed, 29 May 2024 02:56:52 +0100 From: Al Viro To: Edward Adam Davis Cc: syzbot+fe42a669c87e4a980051@syzkaller.appspotmail.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, tytso@mit.edu Subject: Re: [PATCH] fs/dcache: fix warning in ext4_xattr_inode_lookup_create Message-ID: <20240529015652.GJ2118490@ZenIV> References: <0000000000002b03350619853096@google.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro On Wed, May 29, 2024 at 09:15:02AM +0800, Edward Adam Davis wrote: > ext4_xattr_inode_lookup_create() will use s_root, so set it to NULL > after do_one_tree(). Why, in the name of everything unholy, would eviction of dentries need to set any kind of xattrs?