Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp421511lqb; Tue, 28 May 2024 22:26:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWD/YjIW9P4BOMmSoz3b5AvFUTjc1eB/nDExNMfutSOQVBHSM4NaLd/uaWlMAx2E8JwE4L6WO4udr1z3u1NiZ4z/OVWAQeDdJYkKcZ7yA== X-Google-Smtp-Source: AGHT+IF+GdQgF95XHgkYt5Qe/YcdwojU8FNxuWCxATbKTLohXGRE2Fwcg0Gs2C2I+UUZzdlndME2 X-Received: by 2002:a50:c31d:0:b0:579:c4b7:4362 with SMTP id 4fb4d7f45d1cf-579c4b743f0mr9166777a12.0.1716960371018; Tue, 28 May 2024 22:26:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716960370; cv=pass; d=google.com; s=arc-20160816; b=ny+KX1S8Jx0ti0CyP3AqGNFHcBkyjfYgUqFNRx/r1jtXAWqXy2Wv4uUwBb4JiUcOQl U0e2RwQpdXqy06r+5hBTk9HoWlJ/Fm/J53a9Zhqw04ktM9bSxI5gUH7f3eAPmjKiYvRZ kMVLXFy9CG497cw8a2AhNSBwuUFSgHiyEELXC6cPIn+wY2NWYwlnqvPCqHxHc8vYKQS7 dkN332GhCjPMNX2uuS0DDGrzLSQPiaRcc5oxjQsigNYP/wx31N/aXPafg4Gdvfe42jP8 1PBzX5K+QZYhy23PrYIuW8o9Dfs+foMtb/GWxRCXn9O48+7tQFuOMseIoJ2Wv2Tb3Ixw xiYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=fMJXPi5KF+BKzFQfFzmq8IuS4+U+c9Tdj1PMwsLFKTU=; fh=Dk305f9xd/mXvI4Xk50RrI85sYdneBYagoj2h78w+Ao=; b=tCSwmZqZXKyEh53A8AFc6Q8EezNMePTS0kawcdIXuwt8bXYTJwT/MIDQILkDDqaU+Q sC7QGqvwpCJeRGuIGpezxx6C+HJLcgBC1zOrwv7TaA6Hl28LS102SDn0f99dQaKoHgGK wDPIN91Ofz+PTDGspEq2C0UitPjmb0pXDzN5WMhxmz+sDS4ONMG75hdFBmS1JKVm/9Td Wdb8MzvFIkpLNKFFuKLC2afoOJp3wfAQs5EVnhTohNUcFBlPCM0+LzlnMe5AVSBIFFCb SP9gUeHQUTMV6b43WWfEtQd8Bx9FAJ4BYkoLpZWnpVJsPootgDTLjop/zZpaux00GHx7 gFng==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-ext4+bounces-2698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2698-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-579c5a72b90si4104457a12.197.2024.05.28.22.26.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 22:26:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-ext4+bounces-2698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2698-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B92EC1F22F8C for ; Wed, 29 May 2024 05:26:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CBFA715B990; Wed, 29 May 2024 05:26:02 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D32DA15B973; Wed, 29 May 2024 05:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716960362; cv=none; b=avWVLI6FBaOoopOvMd7q5JsWBplR6P+zAtpWOaklb1BQLjdpNQAsCjhCDZL5QHHzCGw7wsikEk0OaVkehH9HXviQ66r15pXd0uWR0KYuDSZ3a0aqg9Zr6r5TOH6oZQinUzk6ywQHfwd5SZDHoS5WQLVmKxqhoFtOqNR5bvGQGpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716960362; c=relaxed/simple; bh=+u2pWKNmsu+c/DGMHN/WdlFPb6p34o0sN/9vYl0T4bM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GG3hJu/yg2J1uHsCfUmBoQKY9j/Wpjuu1hO4Nuea5rQ1N561Zc0rbvX6vUqnzImC7H0HOKe0zNtsKUmleq4Jj8mzuF1Vxa9Mokq7SkI1kXzlwtgso1anP9kUHMWOZLiPpxZzeAZhNziDEibWb5aTuMyQVNb4e0VDCkXbzY7Afws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 6D2A068AFE; Wed, 29 May 2024 07:25:57 +0200 (CEST) Date: Wed, 29 May 2024 07:25:57 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 7/7] iomap: Return the folio from iomap_write_begin() Message-ID: <20240529052557.GC15312@lst.de> References: <20240528164829.2105447-1-willy@infradead.org> <20240528164829.2105447-8-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528164829.2105447-8-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, May 28, 2024 at 05:48:28PM +0100, Matthew Wilcox (Oracle) wrote: > Use an ERR_PTR to return any error that may have occurred, otherwise > return the folio directly instead of returning it by reference. This > mirrors changes which are going into the filemap ->write_begin callbacks. Besides the mechanical errors pointed out by Dave I really like the new calling convention.