Received-SPF: pass (google.com: domain of linux-ext4+bounces-2748-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 3 Jun 2024 08:35:51 +0100
From: Al Viro <viro@zeniv.linux.org.uk>
To: Hyeonwoo Cha <chw1119@hanyang.ac.kr>
Cc: david.sterba@suse.com, aivazian.tigran@gmail.com, brauner@kernel.org,
	jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca,
	hirofumi@mail.parknet.co.jp, sfr@canb.auug.org.au,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-ext4@vger.kernel.org, reiserfs-devel@vger.kernel.org
Subject: Re: [PATCH] Fix filesystem issue: description of the fix Fix
 mark_buffer_dirty_inode to mark_buffer_dirty_fsync Signed-off-by: HyeonWoo
 Cha <chw1119@hanyang.ac.kr>
Message-ID: <20240603073551.GM1629371@ZenIV>
References: <20240603065910.20736-1-chw1119@hanyang.ac.kr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240603065910.20736-1-chw1119@hanyang.ac.kr>
Sender: Al Viro <viro@ftp.linux.org.uk>

On Mon, Jun 03, 2024 at 03:59:10PM +0900, Hyeonwoo Cha wrote:

NAK.  Reasons:
	* patch described as a fix; that implies that some behaviour
change is there.  Yet there's no description of that change or
explanation of the problem being fixed.
	* lack of _any_ explanations, period.  Including e.g.
a discussion of the reasons why the change makes sense.
	* apparent blind trust in continued applicability of comments
that date back to 2002; in any case, no analysis is offered anywhere -
reviewers are supposed to do that themselves, presumably.
	* failure to Cc the original author of the comment in question.