Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp886947lqj; Mon, 3 Jun 2024 04:10:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUeTDqpP9Dx+3Fdj18migyGdc+Tv7Wcfd7lNxlVa7giAgaUW4WIgEKrFdY1Ivhx7dIN3ucyNd6gLIVzPQY4wwM+9iFoOMqxcjaA63EaEg== X-Google-Smtp-Source: AGHT+IHx0hXsUyYEXYxEFn+dAR62WdT6IGbMbZDa+L4Jmx6yfLD2g8QH8FM34pMMo7NjmnGEIFn/ X-Received: by 2002:a17:902:e80d:b0:1f6:6bf5:5aef with SMTP id d9443c01a7336-1f66bf55dccmr40981065ad.29.1717413015469; Mon, 03 Jun 2024 04:10:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717413015; cv=pass; d=google.com; s=arc-20160816; b=DTMlCnSiw+JQnTrtMOAS5q2Tr/rqgGjY7mvYNNZ4OtUyyfZE2NOJAQB+YgkONcBT74 XrfEwWc/8yLPayx/6PhKrPwvBMIskM5iFhfJs677YU/KWjsDooItyu+BubaJtirxmMf8 SeBkNOASYtv8sgtcAXEl7TnXpmn6GDAOQl+0gmgDiA+dhOzW/H3EZa0YSClFNuWO52rk 5w5ZPhAeM94tEb29ZYofNkI2UtfxPrAyGcgMYKmJ8N1PX4j7EyvimwpaDv+qi58X74ig aOQZHeKxbCqWEf5x8dS8vCNaOrFj4o7k2EV5jSKxz2O0FD6aMPZCr78uLFs2gCpa1oww nt3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from:dkim-signature; bh=uGnoAAc7YPzdknGJd+YKFZ3RPWePJNQ/hjnRUSA0X0E=; fh=dEWa2G/lvVejSFkZGe4DEaABPIipNGC53ocEV7yqCmA=; b=SIkR/lv2hGzUVxAsbCo59NyOklJTES+pNjI5Ur8rCqf7PBssJ+GZe7k72XZpKAqtEc Y7CtiGMBkXw0DM9IuL3TBi10cHCnnaoo1joGQw4ObPv31Fef/QHSMhM6EZhrUGqQioDj FCtpQKImGJZheb1QKhgM5t1IR1DrkG1KjlmRCjAzfTGQXHgwX4g2HISeHudwUG0aeIy1 H5D/vJHbeqCeNAEFRfHVp7Xr7hJq4bI/BtuhNS2F52bEMsemlbTE3Y94AuQqEo2urtSh TtK/Mi6W3o4mcmyvb9tQMSbhm/qeiX5PZmm54iXqzbu64l4fzR1NahCTZMHOjPSoh7gV S7RQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=RCFqGgMI; arc=pass (i=1 spf=pass spfdomain=163.com dkim=pass dkdomain=163.com dmarc=pass fromdomain=163.com); spf=pass (google.com: domain of linux-ext4+bounces-2749-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2749-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f679556c04si17925105ad.414.2024.06.03.04.10.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 04:10:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2749-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=RCFqGgMI; arc=pass (i=1 spf=pass spfdomain=163.com dkim=pass dkdomain=163.com dmarc=pass fromdomain=163.com); spf=pass (google.com: domain of linux-ext4+bounces-2749-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2749-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6B4D5B23D03 for ; Mon, 3 Jun 2024 10:57:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D449580039; Mon, 3 Jun 2024 10:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="RCFqGgMI" X-Original-To: linux-ext4@vger.kernel.org Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 233BB107A8 for ; Mon, 3 Jun 2024 10:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717412266; cv=none; b=cp0p8/y+0abaiAP9Un/vnwvvVv247YLu/2AOyWZHBu8sNvZfEj9FFPj+ATnhyqGpaS4KyU1Lk0d7uEBMbQplk18h+CZbsUx1VJzhrXQ4Mk/QoxOL++2J55NMZk/Ls6Pj8NCIrM2PGQrX4D5qadd/P6e5nv/sl+yu2ZSa6jP4GzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717412266; c=relaxed/simple; bh=ILLCQJ6YCWaiOUwBZ2oG6XTFLJUTtXS5qQ90oQP3gAY=; h=From:To:Cc:Subject:Date:Message-Id; b=Bc2z1XvRDv+QtDXKbyrcD7z2n3R1CfR+zmczbMO8EuwB0dhhqgWOh6XaSfcpqHS1IBbZOh03Y1RsC07Dx8rkRiD4nJjme0dOp2qoyUS5D+C4AVhSmgyPzHq3NFOQC0CWdPbvDIE0+UUSD4n1DfEdQJI2xmXJnWXS4nEu8/mTxHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=RCFqGgMI; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=uGnoAAc7YPzdknGJd+ YKFZ3RPWePJNQ/hjnRUSA0X0E=; b=RCFqGgMImfAT3PaJXGkgXjOimRQv9SteeC 7KM11w07Ha3ak/d665LlOYSZWm/Wa/o3bQbW5pVTFV+Umj/W6acGxgZNfwjxK6gh G1gLENsIp0wOHoS6nJG+NiEt1XZCv3ENiRbc6BxRKkHsgUer1Iwsx3PdTxPxdf41 d0k94zRvo= Received: from localhost.tbsite.net (unknown [140.205.118.15]) by gzga-smtp-mta-g1-2 (Coremail) with SMTP id _____wDXr1+RoV1m9DTwFg--.13199S3; Mon, 03 Jun 2024 18:57:22 +0800 (CST) From: carrion bent To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, carrion bent Subject: [PATCH] ext4:fix macro definition error of EXT4_DIRENT_HASH and EXT4_DIRENT_MINOR_HASH Date: Mon, 3 Jun 2024 18:57:19 +0800 Message-Id: <1717412239-31392-1-git-send-email-carrionbent@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID:_____wDXr1+RoV1m9DTwFg--.13199S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gr45ury3tFWxCryrWr45ZFb_yoWDtFcE93 48Ar18GwsIyF93Ka18A345tF1aqr48KF4jqF95G34qvr98Ja13A34qq3srZr93ury3AF1D uF9Yqr1rKrn7WjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sR_SfOUUUUUU== X-CM-SenderInfo: xfdu2xprqev0rw6rljoofrz/1tbiLhbycmV4JUKG1QAAsR Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: the macro parameter "entry" of EXT4_DIRENT_HASH and EXT4_DIRENT_MINOR_HASH was not used, but rather the variable de was directly used, which may be a local variable inside a function that calls the macros Signed-off-by: carrion bent --- fs/ext4/ext4.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 983dad8..04bdd27 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2338,9 +2338,9 @@ struct ext4_dir_entry_2 { ((struct ext4_dir_entry_hash *) \ (((void *)(entry)) + \ ((8 + (entry)->name_len + EXT4_DIR_ROUND) & ~EXT4_DIR_ROUND))) -#define EXT4_DIRENT_HASH(entry) le32_to_cpu(EXT4_DIRENT_HASHES(de)->hash) +#define EXT4_DIRENT_HASH(entry) le32_to_cpu(EXT4_DIRENT_HASHES(entry)->hash) #define EXT4_DIRENT_MINOR_HASH(entry) \ - le32_to_cpu(EXT4_DIRENT_HASHES(de)->minor_hash) + le32_to_cpu(EXT4_DIRENT_HASHES(entry)->minor_hash) static inline bool ext4_hash_in_dirent(const struct inode *inode) { -- 2.7.4