Received-SPF: pass (google.com: domain of linux-ext4+bounces-2757-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 17:24:19 +0200
From: Jan Kara <jack@suse.cz>
To: JunChao Sun <sunjunchao2870@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org, tytso@mit.edu,
	adilger.kernel@dilger.ca
Subject: Re: [PATCH] ext4: Adjust the layout of the ext4_inode_info structure
 to save memory.
Message-ID: <20240603152419.dklvgmf6m4akdyzf@quack3>
References: <20240603131524.324224-1-sunjunchao2870@gmail.com>
 <20240603140705.vfpdrbyljw6yfxpd@quack3>
 <CAHB1NagapRk62L9vn0uSKYJMMSq=9kNiB+jdaxA3JBY16f9jig@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHB1NagapRk62L9vn0uSKYJMMSq=9kNiB+jdaxA3JBY16f9jig@mail.gmail.com>

On Mon 03-06-24 22:43:16, JunChao Sun wrote:
> Jan Kara <jack@suse.cz> 于2024年6月3日周一 22:07写道：
> >
> > On Mon 03-06-24 21:15:24, Junchao Sun wrote:
> > > Using pahole, we can see that there are some padding holes
> > > in the current ext4_inode_info structure. Adjusting the
> > > layout of ext4_inode_info can reduce these holes,
> > > resulting in the size of the structure decreasing
> > > from 2424 bytes to 2408 bytes.
> >
> >
> > > But AFAICT this will save two holes 4 bytes each so only 8 bytes in total?
> > > Not 16?
> 
> Indeed it's 16.
> Consider the layout int a; hole 0; int b; hole 1; And then move int b
> to hole 0 position, this adjustment resulted in saving 8 bytes. There
> are two adjustments like this, so it's 16. And GDB confirmed this.

Aha, OK. Thanks for clarification!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR