Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp387093lqp; Tue, 11 Jun 2024 07:27:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW37ZxuCyUaOGdn+rLK7HE4Yh4N5MLwZ5tm1u1QCWob/grlpeGR1p5BQhemJb7SutSMOzYetFdLf9L4YEDT/6Bi/8lYFP1LyyVMyoBFCg== X-Google-Smtp-Source: AGHT+IHOBpukx0/LoNB8jBOZrhSkBHMW4U2MrjNCQl2ImtSTWDhVwLoQjIyTffCkUoLf2qxVmwKb X-Received: by 2002:a25:74c7:0:b0:dfb:5e8:66c4 with SMTP id 3f1490d57ef6-dfb05e87857mr9532266276.29.1718116046393; Tue, 11 Jun 2024 07:27:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718116046; cv=pass; d=google.com; s=arc-20160816; b=Ttw2GBnoh3EvEiScnHZr45fksghSEMRLS5bKiV4Rh5h3cc04Y6lj7U0GqD43nP2qpb MYXA/YziA49oux94stf5e2M8DuobK7VcPBPY/VKJSBGDrGzZ724gzkCYSr/R5IAB/Uhd 5qLThFM8fXhmWmC0g4TSqHQnnYiVs6hsCbqpqPiJa11AsOkKwOBnYSXEIPdVntdV1YjQ X8rLhTHJrjEbXQaj548DXQCt14sIItWleG+ZL07YYFqsEYu0YRY29KuI9FchQdJO2mXG h/lH43h4yzC4jae63lM0yOp4nVrQvKOHRXNLGTT9y0sHRJ2j3IV0nnjVlNMOgWQqoywb ojxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=If8+HtHtn91wWn82XIuz1y8GVldm8f6n22eLx1qHatI=; fh=mFjBxWtsA9NPNe3Gkwd5L+dWph7pq0ADh54Ay2V+KKY=; b=K/fQ825tOC4Awzu0R9w2KHXNMH9aNI+QBil3RuWwyPUJIOdElwXsC+qmd0chKgNFHC jxGq/IliLMhXvy5g3waamsIzF8+VQcT20dwjNsfvd8VdT/19Ei7UkLOz37jNCiRXo9vQ UHuOQ0tpaBJBuNUyIX2RR7IML/SV246rpebbvgEV5JlGkgV+bFc8j4sVtkaRSQce6ekZ LF1Iw2Z04gpY/2yyugOSv24NzqNFCcjqqRTyNWog4zPvzbNY2GZO6Nyeqe0aoGcmMVPc a4rhscrHiCnUS8X6ldLAUx9wzwKui9Kt2fMVxNEvToW5ksGCulyHD9XlczjrTofj9af1 RKag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=UeAZo699; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-ext4+bounces-2851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-4414bea5a01si14219821cf.340.2024.06.11.07.27.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 07:27:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-2851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=UeAZo699; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-ext4+bounces-2851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-2851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6CE611C22248 for ; Tue, 11 Jun 2024 14:27:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0717A17D898; Tue, 11 Jun 2024 14:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UeAZo699" X-Original-To: linux-ext4@vger.kernel.org Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE1317CA17 for ; Tue, 11 Jun 2024 14:27:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718116043; cv=none; b=qlhQQ9OdroFB45A1rXUVZHN6wB55lWNjxqzJMdVk/4Phq15hvD3nTLR5gXs8KEIewd54Vrv9ObOr4NMMC4W1CLP3+hyw+EHT3YYKPCCA2tJjIDyrvq6mLprHyYkrghWCNSrImmpqhm/15ZgrhMiyfnLdPWIxMJ1YW2g1ZERLNz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718116043; c=relaxed/simple; bh=xQyi8x7XM6VeovpVDfhOGm0eR1PhSRVEsz1IpofzP0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dh67vpQ+pYgcKU13ch9aJk+1+LrSCr0vn06WMKkVuROi7IThv+jrGiGkwcApYYOQit0uEsEcYarhZE4fA2JAkvZUtV8uCxtNezbmDXS2dJcpaSBOCOEi/Ki09SU1BVL+JQjDwncYAvsVnNt58yKAZ75KDlP+I3MGvdDNbeQwm+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UeAZo699; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: luis.henriques@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718116039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=If8+HtHtn91wWn82XIuz1y8GVldm8f6n22eLx1qHatI=; b=UeAZo699GIqXenoAEMN01idW+vVoNeOCBpy3q0ogFUis0LdaOeYI4cBLBK/+G4w0j9J9Z8 GkOgqvvzZztKbZIcMGQFwHGxZrqbhd6mKKNyLHtEKrXD+/vZx5WvR4qMfPoVzLd33hJTxR fCkuzWEuGm8fFZsjBo6H1RCAf+Mh+hA= X-Envelope-To: tytso@mit.edu X-Envelope-To: adilger@dilger.ca X-Envelope-To: linux-ext4@vger.kernel.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Luis Henriques (SUSE)" To: Theodore Ts'o , Andreas Dilger Cc: linux-ext4@vger.kernel.org, "Luis Henriques (SUSE)" Subject: [PATCH 1/2] e2fsck: don't skip checks if the orphan file is present in the filesystem Date: Tue, 11 Jun 2024 15:27:03 +0100 Message-ID: <20240611142704.14307-2-luis.henriques@linux.dev> In-Reply-To: <20240611142704.14307-1-luis.henriques@linux.dev> References: <20240611142704.14307-1-luis.henriques@linux.dev> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT If the filesystem supports the orphan file feature and that file is present then don't skip the filesystem checks as that file may need to be cleaned up. Signed-off-by: Luis Henriques (SUSE) --- e2fsck/unix.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/e2fsck/unix.c b/e2fsck/unix.c index de20b216dde0..7768f0ed7c4e 100644 --- a/e2fsck/unix.c +++ b/e2fsck/unix.c @@ -371,6 +371,10 @@ static void check_if_skip(e2fsck_t ctx) if (ctx->options & E2F_OPT_JOURNAL_ONLY) goto skip; + if (ext2fs_has_feature_orphan_file(fs->super) && + ext2fs_has_feature_orphan_present(fs->super)) + return; + lastcheck = ext2fs_get_tstamp(sb, s_lastcheck); if (lastcheck > ctx->now) lastcheck -= ctx->time_fudge;