Received-SPF: pass (google.com: domain of linux-ext4+bounces-2870-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <45251246-e24b-4ace-9b45-2efad65e8eb5@huawei.com>
Date: Thu, 13 Jun 2024 10:09:44 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ext4/059: disable block_validity checks when mounting a
 corrupted file system
To: <zlang@kernel.org>, Theodore Ts'o <tytso@mit.edu>
CC: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	<linux-fstests@mit.edu>, =?UTF-8?B?5p2o5LqM5Z2k?= <yangerkun@huawei.com>
References: <20230823145621.3680601-1-tytso@mit.edu>
Content-Language: en-US
From: Baokun Li <libaokun1@huawei.com>
In-Reply-To: <20230823145621.3680601-1-tytso@mit.edu>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Zorro,

Could you pick up this patch?
This test case has been failing in the mainline for a while now.

Thanks,
Baokun

On 2023/8/23 22:56, Theodore Ts'o wrote:
> Kernels with the commit "ext4: add correct group descriptors and
> reserved GDT blocks to system zone" will refuse to mount the corrupted
> file system constructed by this test.  So in order to perform the
> test, we need to disable the block_validity checks.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Looks good to me, thanks for the patch!

Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com>

> ---
>   tests/ext4/059 | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tests/ext4/059 b/tests/ext4/059
> index 4230bde92..e4af77f1e 100755
> --- a/tests/ext4/059
> +++ b/tests/ext4/059
> @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
>   $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
>   	grep "Reserved GDT blocks"
>   
> +# Kernels with the commit "ext4: add correct group descriptors and
> +# reserved GDT blocks to system zone" will refuse to mount the file
> +# system due to block_validity checks; so disable block_validity.
> +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity"
> +
>   _scratch_mount
>   
>   # Expect no crash from this resize operation


-- 
With Best Regards,
Baokun Li