2007-07-05 21:26:15

by Andrew Morton

[permalink] [raw]
Subject: + ext4-fix-error-handling-in-ext4_create_journal.patch added to -mm tree

The patch titled
ext4: fix error handling in ext4_create_journal
has been added to the -mm tree. Its filename is

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

Subject: ext4: fix error handling in ext4_create_journal
From: Borislav Petkov <[email protected]>

Fix error handling in ext4_create_journal according to kernel conventions.

Signed-off-by: Borislav Petkov <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>

fs/ext4/super.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff -puN fs/ext4/super.c~ext4-fix-error-handling-in-ext4_create_journal fs/ext4/super.c
--- a/fs/ext4/super.c~ext4-fix-error-handling-in-ext4_create_journal
+++ a/fs/ext4/super.c
@@ -2158,6 +2158,7 @@ static int ext4_create_journal(struct su
unsigned int journal_inum)
journal_t *journal;
+ int err;

if (sb->s_flags & MS_RDONLY) {
printk(KERN_ERR "EXT4-fs: readonly filesystem when trying to "
@@ -2165,13 +2166,15 @@ static int ext4_create_journal(struct su
return -EROFS;

- if (!(journal = ext4_get_journal(sb, journal_inum)))
+ journal = ext4_get_journal(sb, journal_inum);
+ if (!journal)
return -EINVAL;

printk(KERN_INFO "EXT4-fs: creating new journal on inode %u\n",

- if (jbd2_journal_create(journal)) {
+ err = jbd2_journal_create(journal);
+ if (err) {
printk(KERN_ERR "EXT4-fs: error creating journal.\n");
return -EIO;

Patches currently in -mm which might be from [email protected] are