max_debt is used in ext2's find_group_orlov . In ext4's
find_group_orlov, max_debt is only computed, but not used. I wonder
whether it's a typo, Can anyone give me a answer? The kernel source I
read is 2.6.22.
Thanks in advance.
On Thu, 2007-07-19 at 21:00 +0800, Yan Zheng wrote:
> Hi all
> max_debt is used in ext2's find_group_orlov . In ext4's
> find_group_orlov, max_debt is only computed, but not used. I wonder
> whether it's a typo, Can anyone give me a answer? The kernel source I
> read is 2.6.22.
I think you are right, max_debt is currently unused in the current
ext3/4 code. In ext2 max_debt is used along with s_debts (in struct
ext2_sb_info) to decide inode allocations. s_debts is no longer present
You can find the reason for removing s_debts here:
Basically use of s_debts was unsafe since it performed unlocked byte
increment/decrement on words which may be being accessed simultaneously
on other CPUs and since it was a dynamic in-memory table, it required
extension during online resize which needed proper locking.
Until s_debts is added again, I think the code relating to max_debts
should be removed?
> Thanks in advance.
> Best Regards
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html