2008-01-09 19:59:49

by Jan Kara

Subject: [PATCH resend] mke2fs: Make lost+found always have at least 2 blocks

Hi,

this is a resend of Andreas' patch I've sent in the beginning of
December. The patch modifies mke2fs to always create lost+found with at
least two directory blocks. I think this could make sence not only for
testing but as a sanity check that 64KB support works for general e2fsprogs
if someone decides to use it...

Honza

--
Jan Kara <[email protected]>
SUSE Labs, CR
---

From: Andreas Dilger <[email protected]>

Make sure lost+found has always at least 2 disk blocks. This will provide at
least elementary test that we have not screwed-up support for 64KB blocks since
the second directory block will be empty.

Signed-off-by: Jan Kara <[email protected]>

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 98a4957..6249cc2 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -534,7 +534,10 @@ static void create_lost_and_found(ext2_f
}

for (i=1; i < EXT2_NDIR_BLOCKS; i++) {
- if ((lpf_size += fs->blocksize) >= 16*1024)
+ /* Ensure that lost+found is at least 2 blocks, so we always
+ * test large empty blocks for big-block filesystems. */
+ if ((lpf_size += fs->blocksize) >= 16*1024 &&
+ lpf_size >= 2 * fs->blocksize)
break;
retval = ext2fs_expand_dir(fs, ino);
if (retval) {

2008-01-14 15:52:11

by Theodore Ts'o

Subject: Re: [PATCH resend] mke2fs: Make lost+found always have at least 2 blocks

On Wed, Jan 09, 2008 at 08:59:47PM +0100, Jan Kara wrote:
> Hi,
>
> this is a resend of Andreas' patch I've sent in the beginning of
> December. The patch modifies mke2fs to always create lost+found with at
> least two directory blocks. I think this could make sence not only for
> testing but as a sanity check that 64KB support works for general e2fsprogs
> if someone decides to use it...

Thanks, applied.

- Ted