2008-09-10 11:21:34

by Kirill A. Shutemov

[permalink] [raw]
Subject: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h

Signed-off-by: Kirill A. Shutemov <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: <[email protected]>
---
include/linux/ext2_fs.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
index 2efe7b8..f23ba68 100644
--- a/include/linux/ext2_fs.h
+++ b/include/linux/ext2_fs.h
@@ -18,6 +18,7 @@

#include <linux/types.h>
#include <linux/magic.h>
+#include <linux/fs.h>

/*
* The second extended filesystem constants/structures
--
1.5.6.5.GIT



2008-09-10 11:27:12

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h

And who cares?


2008-09-10 11:39:41

by Kirill A. Shutemov

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
> > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
>
> And who cares?

It breaks building pam_mktemp at least.

It's regression introduced by commit 36695673b.

--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/

Attachments:
(No filename) (402.00 B)
 signature.asc (197.00 B)
Digital signature Download all attachments

2008-09-10 11:40:44

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
> > On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
> > > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
> >
> > And who cares?
>
> It breaks building pam_mktemp at least.

pam_mktemp should not use <linux/ext2_fs.h>, but rather
<ext2fs/ext2_fs.h>.


2008-09-10 11:48:52

by Kirill A. Shutemov

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote:
> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote:
> > On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
> > > On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
> > > > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
> > >
> > > And who cares?

Do you think it isn't error?

> > It breaks building pam_mktemp at least.
>
> pam_mktemp should not use <linux/ext2_fs.h>, but rather
> <ext2fs/ext2_fs.h>.

Why linux/ext2_fs.h does export to userspace?


--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/

Attachments:
(No filename) (675.00 B)
 signature.asc (197.00 B)
Digital signature Download all attachments

2008-09-10 13:39:00

by Eric Sandeen

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

Kirill A. Shutemov wrote:
> On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote:
>> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote:
>>> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
>>>> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
>>>>> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
>>>> And who cares?
>
> Do you think it isn't error?
>
>>> It breaks building pam_mktemp at least.
>> pam_mktemp should not use <linux/ext2_fs.h>, but rather
>> <ext2fs/ext2_fs.h>.

That's right.

> Why linux/ext2_fs.h does export to userspace?
>

it does?

$ grep header-y include/linux/Kbuild | wc -l
163
$ grep header-y include/linux/Kbuild | grep ext2
$

I think it does not.

-Eric

2008-09-10 13:47:01

by Kirill A. Shutemov

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

On Wed, Sep 10, 2008 at 08:39:00AM -0500, Eric Sandeen wrote:
> Kirill A. Shutemov wrote:
> > On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote:
> >> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote:
> >>> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
> >>>> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
> >>>>> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
> >>>> And who cares?
> >
> > Do you think it isn't error?
> >
> >>> It breaks building pam_mktemp at least.
> >> pam_mktemp should not use <linux/ext2_fs.h>, but rather
> >> <ext2fs/ext2_fs.h>.
>
> That's right.
>
> > Why linux/ext2_fs.h does export to userspace?
> >
>
> it does?
>
> $ grep header-y include/linux/Kbuild | wc -l
> 163
> $ grep header-y include/linux/Kbuild | grep ext2
> $
>
> I think it does not.

It does:

$ grep unifdef-y include/linux/Kbuild | grep ext2
unifdef-y += ext2_fs.h

--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/

Attachments:
(No filename) (1.03 kB)
 signature.asc (197.00 B)
Digital signature Download all attachments

2008-09-10 14:57:08

by Eric Sandeen

[permalink] [raw]
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

Kirill A. Shutemov wrote:
> On Wed, Sep 10, 2008 at 08:39:00AM -0500, Eric Sandeen wrote:

>> I think it does not.
>
> It does:
>
> $ grep unifdef-y include/linux/Kbuild | grep ext2
> unifdef-y += ext2_fs.h

Oops, I stand corrected :)

-Eric