2008-11-18 11:26:50

by Aneesh Kumar K.V

Subject: [PATCH] ext4: Remove unneeded code.

This also caused an ext4_error when mounting a file system
with only one block group.

Signed-off-by: Aneesh Kumar K.V <[email protected]>
---
fs/ext4/super.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 70f6d61..ddfa29b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1451,7 +1451,6 @@ static int ext4_fill_flex_info(struct super_block *sb)
ext4_group_t flex_group_count;
ext4_group_t flex_group;
int groups_per_flex = 0;
- __u64 block_bitmap = 0;
int i;

if (!sbi->s_es->s_log_groups_per_flex) {
@@ -1474,9 +1473,6 @@ static int ext4_fill_flex_info(struct super_block *sb)
goto failed;
}

- gdp = ext4_get_group_desc(sb, 1, &bh);
- block_bitmap = ext4_block_bitmap(sb, gdp) - 1;

2008-11-22 23:01:31

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Remove unneeded code.

On Tue, Nov 18, 2008 at 04:55:27PM +0530, Aneesh Kumar K.V wrote:
> This also caused an ext4_error when mounting a file system
> with only one block group.
>
> Signed-off-by: Aneesh Kumar K.V <[email protected]>

thanks, applied (with a slightly different patch description).

- Ted