2009-01-30 20:08:01

by Mathieu Desnoyers

[permalink] [raw]
Subject: LTTng 0.89 for Linux 2.6.29-rc3

Hi,

I just ported LTTng to the 2.6.29-rc3 kernel. It includes the following
changes :

- Tree RCU instrumentation
- Updated ext4 and jbd2 instrumentation

Please feel free to try it and report any success/problem you may have.
Note that cross-build has been slightly less tested this time because
I'll have to upgrade many of my compilers to a version compatible with
kernel 2.6.29-rc.

It also includes the recently added kprobes support through a simple

echo symbol_name > /mnt/debugfs/ltt/kprobes/enable

It's available at the new LTTng website :

http://www.lttng.org/

Thanks,

Mathieu

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


2009-02-05 14:04:39

by Paul E. McKenney

[permalink] [raw]
Subject: Re: LTTng 0.89 for Linux 2.6.29-rc3

On Fri, Jan 30, 2009 at 03:07:57PM -0500, Mathieu Desnoyers wrote:
> Hi,
>
> I just ported LTTng to the 2.6.29-rc3 kernel. It includes the following
> changes :
>
> - Tree RCU instrumentation
> - Updated ext4 and jbd2 instrumentation
>
> Please feel free to try it and report any success/problem you may have.
> Note that cross-build has been slightly less tested this time because
> I'll have to upgrade many of my compilers to a version compatible with
> kernel 2.6.29-rc.
>
> It also includes the recently added kprobes support through a simple
>
> echo symbol_name > /mnt/debugfs/ltt/kprobes/enable
>
> It's available at the new LTTng website :
>
> http://www.lttng.org/

Hello, Matheiu,

When I try to apply this to v2.6.29-rc3, I get the following:

can't find file to patch at input line 61
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|get_ltt_root() is necessary for ltt-trace-control to create subdirs in
ltt's
|debugfs dir.
|
|From: Zhao Lei <[email protected]>
|Signed-off-by: Zhao Lei <[email protected]>
|Signed-off-by: Mathieu Desnoyers <[email protected]>
|---
| include/linux/ltt-core.h | 8 ++++++++
| ltt/ltt-core.c | 14 ++++++++++++++
| ltt/ltt-relay.c | 8 +-------
| 3 files changed, 23 insertions(+), 7 deletions(-)
|
|Index: linux-2.6-lttng/include/linux/ltt-core.h
|===================================================================
|--- linux-2.6-lttng.orig/include/linux/ltt-core.h 2009-01-15
15:55:18.000000000 -0500
|+++ linux-2.6-lttng/include/linux/ltt-core.h 2009-01-15
15:55:24.000000000 -0500

Help?

Thanx, Paul

2009-02-05 15:02:46

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Fri, Jan 30, 2009 at 03:07:57PM -0500, Mathieu Desnoyers wrote:
> > Hi,
> >
> > I just ported LTTng to the 2.6.29-rc3 kernel. It includes the following
> > changes :
> >
> > - Tree RCU instrumentation
> > - Updated ext4 and jbd2 instrumentation
> >
> > Please feel free to try it and report any success/problem you may have.
> > Note that cross-build has been slightly less tested this time because
> > I'll have to upgrade many of my compilers to a version compatible with
> > kernel 2.6.29-rc.
> >
> > It also includes the recently added kprobes support through a simple
> >
> > echo symbol_name > /mnt/debugfs/ltt/kprobes/enable
> >
> > It's available at the new LTTng website :
> >
> > http://www.lttng.org/
>
> Hello, Matheiu,
>
> When I try to apply this to v2.6.29-rc3, I get the following:
>
> can't find file to patch at input line 61
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |get_ltt_root() is necessary for ltt-trace-control to create subdirs in
> ltt's
> |debugfs dir.
> |
> |From: Zhao Lei <[email protected]>
> |Signed-off-by: Zhao Lei <[email protected]>
> |Signed-off-by: Mathieu Desnoyers <[email protected]>
> |---
> | include/linux/ltt-core.h | 8 ++++++++
> | ltt/ltt-core.c | 14 ++++++++++++++
> | ltt/ltt-relay.c | 8 +-------
> | 3 files changed, 23 insertions(+), 7 deletions(-)
> |
> |Index: linux-2.6-lttng/include/linux/ltt-core.h
> |===================================================================
> |--- linux-2.6-lttng.orig/include/linux/ltt-core.h 2009-01-15
> 15:55:18.000000000 -0500
> |+++ linux-2.6-lttng/include/linux/ltt-core.h 2009-01-15
> 15:55:24.000000000 -0500
>
> Help?
>

Hi Paul,

I must admit I'm a bit puzzled. I've tried to quilt push -a both
LTTng 0.89 and LTTng 0.92 taken from the website and they both apply
correctly on 2.6.29-rc3. When I quilt pop -a, neither of those 3 files
(include/linux/ltt-core.h, ltt/ltt-core.c, ltt/ltt-relay.c) are stucked
in my tree.

I've used files from :

http://www.lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2

Which tarballs are you using exactly ?

I guess you need to apply them to your existing tree, so pointing you to
git.kernel.org lttng tree won't help much here.

Mathieu

> Thanx, Paul

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-05 15:18:41

by Paul E. McKenney

[permalink] [raw]
Subject: Re: LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 10:02:42AM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Fri, Jan 30, 2009 at 03:07:57PM -0500, Mathieu Desnoyers wrote:
> > > Hi,
> > >
> > > I just ported LTTng to the 2.6.29-rc3 kernel. It includes the following
> > > changes :
> > >
> > > - Tree RCU instrumentation
> > > - Updated ext4 and jbd2 instrumentation
> > >
> > > Please feel free to try it and report any success/problem you may have.
> > > Note that cross-build has been slightly less tested this time because
> > > I'll have to upgrade many of my compilers to a version compatible with
> > > kernel 2.6.29-rc.
> > >
> > > It also includes the recently added kprobes support through a simple
> > >
> > > echo symbol_name > /mnt/debugfs/ltt/kprobes/enable
> > >
> > > It's available at the new LTTng website :
> > >
> > > http://www.lttng.org/
> >
> > Hello, Matheiu,
> >
> > When I try to apply this to v2.6.29-rc3, I get the following:
> >
> > can't find file to patch at input line 61
> > Perhaps you used the wrong -p or --strip option?
> > The text leading up to this was:
> > --------------------------
> > |get_ltt_root() is necessary for ltt-trace-control to create subdirs in
> > ltt's
> > |debugfs dir.
> > |
> > |From: Zhao Lei <[email protected]>
> > |Signed-off-by: Zhao Lei <[email protected]>
> > |Signed-off-by: Mathieu Desnoyers <[email protected]>
> > |---
> > | include/linux/ltt-core.h | 8 ++++++++
> > | ltt/ltt-core.c | 14 ++++++++++++++
> > | ltt/ltt-relay.c | 8 +-------
> > | 3 files changed, 23 insertions(+), 7 deletions(-)
> > |
> > |Index: linux-2.6-lttng/include/linux/ltt-core.h
> > |===================================================================
> > |--- linux-2.6-lttng.orig/include/linux/ltt-core.h 2009-01-15
> > 15:55:18.000000000 -0500
> > |+++ linux-2.6-lttng/include/linux/ltt-core.h 2009-01-15
> > 15:55:24.000000000 -0500
> >
> > Help?
> >
>
> Hi Paul,
>
> I must admit I'm a bit puzzled. I've tried to quilt push -a both
> LTTng 0.89 and LTTng 0.92 taken from the website and they both apply
> correctly on 2.6.29-rc3. When I quilt pop -a, neither of those 3 files
> (include/linux/ltt-core.h, ltt/ltt-core.c, ltt/ltt-relay.c) are stucked
> in my tree.
>
> I've used files from :
>
> http://www.lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
>
> Which tarballs are you using exactly ?

That is indeed the one that I am using.

> I guess you need to apply them to your existing tree, so pointing you to
> git.kernel.org lttng tree won't help much here.

I am attempting to apply to v2.6.29-rc3, which is commit
18e352e4a73465349711a9324767e1b2453383e2 in the linux-2.6 git tree.

Later on, I might well want to apply on top of some other stuff, but
figured I should try it straight first. ;-)

Thanx, Paul

> Mathieu
>
> > Thanx, Paul
>
> --
> Mathieu Desnoyers
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2009-02-05 15:38:25

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Thu, Feb 05, 2009 at 10:02:42AM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney ([email protected]) wrote:
> > > On Fri, Jan 30, 2009 at 03:07:57PM -0500, Mathieu Desnoyers wrote:
> > > > Hi,
> > > >
> > > > I just ported LTTng to the 2.6.29-rc3 kernel. It includes the following
> > > > changes :
> > > >
> > > > - Tree RCU instrumentation
> > > > - Updated ext4 and jbd2 instrumentation
> > > >
> > > > Please feel free to try it and report any success/problem you may have.
> > > > Note that cross-build has been slightly less tested this time because
> > > > I'll have to upgrade many of my compilers to a version compatible with
> > > > kernel 2.6.29-rc.
> > > >
> > > > It also includes the recently added kprobes support through a simple
> > > >
> > > > echo symbol_name > /mnt/debugfs/ltt/kprobes/enable
> > > >
> > > > It's available at the new LTTng website :
> > > >
> > > > http://www.lttng.org/
> > >
> > > Hello, Matheiu,
> > >
> > > When I try to apply this to v2.6.29-rc3, I get the following:
> > >
> > > can't find file to patch at input line 61
> > > Perhaps you used the wrong -p or --strip option?
> > > The text leading up to this was:
> > > --------------------------
> > > |get_ltt_root() is necessary for ltt-trace-control to create subdirs in
> > > ltt's
> > > |debugfs dir.
> > > |
> > > |From: Zhao Lei <[email protected]>
> > > |Signed-off-by: Zhao Lei <[email protected]>
> > > |Signed-off-by: Mathieu Desnoyers <[email protected]>
> > > |---
> > > | include/linux/ltt-core.h | 8 ++++++++
> > > | ltt/ltt-core.c | 14 ++++++++++++++
> > > | ltt/ltt-relay.c | 8 +-------
> > > | 3 files changed, 23 insertions(+), 7 deletions(-)
> > > |
> > > |Index: linux-2.6-lttng/include/linux/ltt-core.h
> > > |===================================================================
> > > |--- linux-2.6-lttng.orig/include/linux/ltt-core.h 2009-01-15
> > > 15:55:18.000000000 -0500
> > > |+++ linux-2.6-lttng/include/linux/ltt-core.h 2009-01-15
> > > 15:55:24.000000000 -0500
> > >
> > > Help?
> > >
> >
> > Hi Paul,
> >
> > I must admit I'm a bit puzzled. I've tried to quilt push -a both
> > LTTng 0.89 and LTTng 0.92 taken from the website and they both apply
> > correctly on 2.6.29-rc3. When I quilt pop -a, neither of those 3 files
> > (include/linux/ltt-core.h, ltt/ltt-core.c, ltt/ltt-relay.c) are stucked
> > in my tree.
> >
> > I've used files from :
> >
> > http://www.lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> >
> > Which tarballs are you using exactly ?
>
> That is indeed the one that I am using.
>
> > I guess you need to apply them to your existing tree, so pointing you to
> > git.kernel.org lttng tree won't help much here.
>
> I am attempting to apply to v2.6.29-rc3, which is commit
> 18e352e4a73465349711a9324767e1b2453383e2 in the linux-2.6 git tree.
>
> Later on, I might well want to apply on top of some other stuff, but
> figured I should try it straight first. ;-)
>

Are you using quilt to apply the patchset series file in the right order ?

Mathieu

> Thanx, Paul
>
> > Mathieu
> >
> > > Thanx, Paul
> >
> > --
> > Mathieu Desnoyers
> > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to ma[email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> _______________________________________________
> ltt-dev mailing list
> [email protected]
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-05 15:58:57

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 10:38:25AM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Thu, Feb 05, 2009 at 10:02:42AM -0500, Mathieu Desnoyers wrote:
> > > * Paul E. McKenney ([email protected]) wrote:
> > > > On Fri, Jan 30, 2009 at 03:07:57PM -0500, Mathieu Desnoyers wrote:
> > > > > Hi,
> > > > >
> > > > > I just ported LTTng to the 2.6.29-rc3 kernel. It includes the following
> > > > > changes :
> > > > >
> > > > > - Tree RCU instrumentation
> > > > > - Updated ext4 and jbd2 instrumentation
> > > > >
> > > > > Please feel free to try it and report any success/problem you may have.
> > > > > Note that cross-build has been slightly less tested this time because
> > > > > I'll have to upgrade many of my compilers to a version compatible with
> > > > > kernel 2.6.29-rc.
> > > > >
> > > > > It also includes the recently added kprobes support through a simple
> > > > >
> > > > > echo symbol_name > /mnt/debugfs/ltt/kprobes/enable
> > > > >
> > > > > It's available at the new LTTng website :
> > > > >
> > > > > http://www.lttng.org/
> > > >
> > > > Hello, Matheiu,
> > > >
> > > > When I try to apply this to v2.6.29-rc3, I get the following:
> > > >
> > > > can't find file to patch at input line 61
> > > > Perhaps you used the wrong -p or --strip option?
> > > > The text leading up to this was:
> > > > --------------------------
> > > > |get_ltt_root() is necessary for ltt-trace-control to create subdirs in
> > > > ltt's
> > > > |debugfs dir.
> > > > |
> > > > |From: Zhao Lei <[email protected]>
> > > > |Signed-off-by: Zhao Lei <[email protected]>
> > > > |Signed-off-by: Mathieu Desnoyers <[email protected]>
> > > > |---
> > > > | include/linux/ltt-core.h | 8 ++++++++
> > > > | ltt/ltt-core.c | 14 ++++++++++++++
> > > > | ltt/ltt-relay.c | 8 +-------
> > > > | 3 files changed, 23 insertions(+), 7 deletions(-)
> > > > |
> > > > |Index: linux-2.6-lttng/include/linux/ltt-core.h
> > > > |===================================================================
> > > > |--- linux-2.6-lttng.orig/include/linux/ltt-core.h 2009-01-15
> > > > 15:55:18.000000000 -0500
> > > > |+++ linux-2.6-lttng/include/linux/ltt-core.h 2009-01-15
> > > > 15:55:24.000000000 -0500
> > > >
> > > > Help?
> > > >
> > >
> > > Hi Paul,
> > >
> > > I must admit I'm a bit puzzled. I've tried to quilt push -a both
> > > LTTng 0.89 and LTTng 0.92 taken from the website and they both apply
> > > correctly on 2.6.29-rc3. When I quilt pop -a, neither of those 3 files
> > > (include/linux/ltt-core.h, ltt/ltt-core.c, ltt/ltt-relay.c) are stucked
> > > in my tree.
> > >
> > > I've used files from :
> > >
> > > http://www.lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > >
> > > Which tarballs are you using exactly ?
> >
> > That is indeed the one that I am using.
> >
> > > I guess you need to apply them to your existing tree, so pointing you to
> > > git.kernel.org lttng tree won't help much here.
> >
> > I am attempting to apply to v2.6.29-rc3, which is commit
> > 18e352e4a73465349711a9324767e1b2453383e2 in the linux-2.6 git tree.
> >
> > Later on, I might well want to apply on top of some other stuff, but
> > figured I should try it straight first. ;-)
> >
>
> Are you using quilt to apply the patchset series file in the right order ?

Ummm... No. I never have used quilt.

Ah, there is a series file. I guess it would not be too hard to make
an appropriate "sh" command:

cat /tmp/patch-2.6.29-rc3-lttng-0.92/series | grep -v '^#' | sed -e 's/^/patch
-p1 < \/tmp\/patch-2.6.29-rc3-lttng-0.92\//' | sh

But this complains about directories. OK, "sudo apt-get install quilt"
followed by "man quilt". Than "quilt import" seems to do some of the
work, but doesn't seem to apply all the patches. Thank goodness for
"git reset --hard"!!!

Help?

Thanx, Paul

> Mathieu
>
> > Thanx, Paul
> >
> > > Mathieu
> > >
> > > > Thanx, Paul
> > >
> > > --
> > > Mathieu Desnoyers
> > > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to [email protected]
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
> >
> > _______________________________________________
> > ltt-dev mailing list
> > [email protected]
> > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> >
>
> --
> Mathieu Desnoyers
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-05 16:22:48

by Trilok Soni

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

Hi Paul,

On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
<[email protected]> wrote:
>>
>> Are you using quilt to apply the patchset series file in the right order ?
>
> Ummm... No. I never have used quilt.
>
> Ah, there is a series file. I guess it would not be too hard to make
> an appropriate "sh" command:
>

How about trying?


#quilt push -a

--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

2009-02-05 16:28:27

by Trilok Soni

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

Hi Paul,

On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
<[email protected]> wrote:
>>
>> Are you using quilt to apply the patchset series file in the right order ?
>
> Ummm... No. I never have used quilt.
>
> Ah, there is a series file. I guess it would not be too hard to make
> an appropriate "sh" command:
>

How about trying?


#quilt push -a

--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

2009-02-05 18:01:38

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> Hi Paul,
>
> On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> <[email protected]> wrote:
> >>
> >> Are you using quilt to apply the patchset series file in the right order ?
> >
> > Ummm... No. I never have used quilt.
> >
> > Ah, there is a series file. I guess it would not be too hard to make
> > an appropriate "sh" command:
>
> How about trying?
>
> #quilt push -a

Is the appropriate incantation as follows?

cd <top of git tree>
mkdir patches
cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
quilt push -a

Thanx, Paul

2009-02-05 18:32:02

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > Hi Paul,
> >
> > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > <[email protected]> wrote:
> > >>
> > >> Are you using quilt to apply the patchset series file in the right order ?
> > >
> > > Ummm... No. I never have used quilt.
> > >
> > > Ah, there is a series file. I guess it would not be too hard to make
> > > an appropriate "sh" command:
> >
> > How about trying?
> >
> > #quilt push -a
>
> Is the appropriate incantation as follows?
>
> cd <top of git tree>
> mkdir patches
> cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> quilt push -a
>

Yes, exactly.

And from there you can follow the LTTng manual here :

http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html

Mathieu

> Thanx, Paul
>

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-05 18:44:58

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > Hi Paul,
> > >
> > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > <[email protected]> wrote:
> > > >>
> > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > >
> > > > Ummm... No. I never have used quilt.
> > > >
> > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > an appropriate "sh" command:
> > >
> > > How about trying?
> > >
> > > #quilt push -a
> >
> > Is the appropriate incantation as follows?
> >
> > cd <top of git tree>
> > mkdir patches
> > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > quilt push -a
> >
>
> Yes, exactly.

Whew! ;-)

> And from there you can follow the LTTng manual here :
>
> http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html

I get some fuzz and the following:

patching file kernel/trace/trace-clock-32-to-64.c
Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
which already exists.
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- rejects in file
kernel/trace/trace-clock-32-to-64.c

Should I be starting from somewhere other than v2.6.29-rc3?

Thanx, Paul

2009-02-05 20:22:59

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney ([email protected]) wrote:
> > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > Hi Paul,
> > > >
> > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > <[email protected]> wrote:
> > > > >>
> > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > >
> > > > > Ummm... No. I never have used quilt.
> > > > >
> > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > an appropriate "sh" command:
> > > >
> > > > How about trying?
> > > >
> > > > #quilt push -a
> > >
> > > Is the appropriate incantation as follows?
> > >
> > > cd <top of git tree>
> > > mkdir patches
> > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > quilt push -a
> > >
> >
> > Yes, exactly.
>
> Whew! ;-)
>
> > And from there you can follow the LTTng manual here :
> >
> > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
>
> I get some fuzz and the following:
>
> patching file kernel/trace/trace-clock-32-to-64.c
> Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> which already exists.
> Hunk #1 FAILED at 1.
> 1 out of 1 hunk FAILED -- rejects in file
> kernel/trace/trace-clock-32-to-64.c
>
> Should I be starting from somewhere other than v2.6.29-rc3?
>

Let's see it step by step, that should get us there.

With patches :

mkdir ~/lttng
cd ~/lttng
wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
cd linux-2.6.29-rc3
mkdir patches
ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
quilt push -a

Does this work ?

Mathieu

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-05 21:04:16

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > * Paul E. McKenney ([email protected]) wrote:
> > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > Hi Paul,
> > > > >
> > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > <[email protected]> wrote:
> > > > > >>
> > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > >
> > > > > > Ummm... No. I never have used quilt.
> > > > > >
> > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > an appropriate "sh" command:
> > > > >
> > > > > How about trying?
> > > > >
> > > > > #quilt push -a
> > > >
> > > > Is the appropriate incantation as follows?
> > > >
> > > > cd <top of git tree>
> > > > mkdir patches
> > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > quilt push -a
> > > >
> > >
> > > Yes, exactly.
> >
> > Whew! ;-)
> >
> > > And from there you can follow the LTTng manual here :
> > >
> > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> >
> > I get some fuzz and the following:
> >
> > patching file kernel/trace/trace-clock-32-to-64.c
> > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > which already exists.
> > Hunk #1 FAILED at 1.
> > 1 out of 1 hunk FAILED -- rejects in file
> > kernel/trace/trace-clock-32-to-64.c
> >
> > Should I be starting from somewhere other than v2.6.29-rc3?
> >
>
> Let's see it step by step, that should get us there.
>
> With patches :
>
> mkdir ~/lttng
> cd ~/lttng
> wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> cd linux-2.6.29-rc3
> mkdir patches
> ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> quilt push -a
>
> Does this work ?

Leaving out the "mkdir", yes. My apologies -- I was forgetting that
"git reset --hard" doesn't get rid of untracked files. I do see fuzz
in a few places, but hopefully this is non-fatal. And in any case, I
can now make the patch required to actually try this out. ;-)

Thanx, Paul

2009-02-05 21:06:30

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney ([email protected]) wrote:
> > > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > > Hi Paul,
> > > > > >
> > > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > > <[email protected]> wrote:
> > > > > > >>
> > > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > > >
> > > > > > > Ummm... No. I never have used quilt.
> > > > > > >
> > > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > > an appropriate "sh" command:
> > > > > >
> > > > > > How about trying?
> > > > > >
> > > > > > #quilt push -a
> > > > >
> > > > > Is the appropriate incantation as follows?
> > > > >
> > > > > cd <top of git tree>
> > > > > mkdir patches
> > > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > > quilt push -a
> > > > >
> > > >
> > > > Yes, exactly.
> > >
> > > Whew! ;-)
> > >
> > > > And from there you can follow the LTTng manual here :
> > > >
> > > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> > >
> > > I get some fuzz and the following:
> > >
> > > patching file kernel/trace/trace-clock-32-to-64.c
> > > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > > which already exists.
> > > Hunk #1 FAILED at 1.
> > > 1 out of 1 hunk FAILED -- rejects in file
> > > kernel/trace/trace-clock-32-to-64.c
> > >
> > > Should I be starting from somewhere other than v2.6.29-rc3?
> > >
> >
> > Let's see it step by step, that should get us there.
> >
> > With patches :
> >
> > mkdir ~/lttng
> > cd ~/lttng
> > wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> > wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> > bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> > cd linux-2.6.29-rc3
> > mkdir patches
> > ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> > quilt push -a
> >
> > Does this work ?
>
> Leaving out the "mkdir", yes.

Ah, yes, my mistake.

> My apologies -- I was forgetting that
> "git reset --hard" doesn't get rid of untracked files. I do see fuzz
> in a few places, but hopefully this is non-fatal. And in any case, I
> can now make the patch required to actually try this out. ;-)
>

Great !

Don't hesitate to ask if you have any question.

Mathieu

> Thanx, Paul
>

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-06 00:33:11

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 04:06:27PM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> > > * Paul E. McKenney ([email protected]) wrote:
> > > > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > > > Hi Paul,
> > > > > > >
> > > > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > > > <[email protected]> wrote:
> > > > > > > >>
> > > > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > > > >
> > > > > > > > Ummm... No. I never have used quilt.
> > > > > > > >
> > > > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > > > an appropriate "sh" command:
> > > > > > >
> > > > > > > How about trying?
> > > > > > >
> > > > > > > #quilt push -a
> > > > > >
> > > > > > Is the appropriate incantation as follows?
> > > > > >
> > > > > > cd <top of git tree>
> > > > > > mkdir patches
> > > > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > > > quilt push -a
> > > > > >
> > > > >
> > > > > Yes, exactly.
> > > >
> > > > Whew! ;-)
> > > >
> > > > > And from there you can follow the LTTng manual here :
> > > > >
> > > > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> > > >
> > > > I get some fuzz and the following:
> > > >
> > > > patching file kernel/trace/trace-clock-32-to-64.c
> > > > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > > > which already exists.
> > > > Hunk #1 FAILED at 1.
> > > > 1 out of 1 hunk FAILED -- rejects in file
> > > > kernel/trace/trace-clock-32-to-64.c
> > > >
> > > > Should I be starting from somewhere other than v2.6.29-rc3?
> > > >
> > >
> > > Let's see it step by step, that should get us there.
> > >
> > > With patches :
> > >
> > > mkdir ~/lttng
> > > cd ~/lttng
> > > wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> > > wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > > bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> > > bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> > > cd linux-2.6.29-rc3
> > > mkdir patches
> > > ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> > > quilt push -a
> > >
> > > Does this work ?
> >
> > Leaving out the "mkdir", yes.
>
> Ah, yes, my mistake.
>
> > My apologies -- I was forgetting that
> > "git reset --hard" doesn't get rid of untracked files. I do see fuzz
> > in a few places, but hopefully this is non-fatal. And in any case, I
> > can now make the patch required to actually try this out. ;-)
> >
>
> Great !
>
> Don't hesitate to ask if you have any question.
>
> Mathieu

Fails to build on Power, so trying x86... (Stock 2.6.29-rc3 does
build and boot, FWIW.)

Looks like misplaced file.

Thanx, Paul

------------------------------------------------------------------------

CHK include/linux/version.h
UPD include/linux/version.h
CHK include/linux/utsrelease.h
UPD include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-powerpc
HOSTCC scripts/ihex2fw
HOSTCC scripts/kallsyms
HOSTCC scripts/pnmtologo
HOSTCC scripts/genksyms/genksyms.o
HOSTCC scripts/conmakehash
HOSTCC scripts/bin2c
CC scripts/mod/empty.o
HOSTCC scripts/mod/mk_elfconfig
SHIPPED scripts/genksyms/lex.c
SHIPPED scripts/genksyms/parse.h
SHIPPED scripts/genksyms/keywords.c
SHIPPED scripts/genksyms/parse.c
HOSTCC scripts/genksyms/parse.o
HOSTCC scripts/genksyms/lex.o
MKELF scripts/mod/elfconfig.h
HOSTCC scripts/mod/file2alias.o
HOSTCC scripts/mod/modpost.o
HOSTCC scripts/mod/sumversion.o
HOSTLD scripts/genksyms/genksyms
HOSTLD scripts/mod/modpost
CC kernel/bounds.s
GEN include/linux/bounds.h
CC arch/powerpc/kernel/asm-offsets.s
In file included from include/linux/module.h:18,
from include/linux/sysdev.h:25,
from include/linux/node.h:22,
from include/linux/swap.h:10,
from include/linux/suspend.h:7,
from arch/powerpc/kernel/asm-offsets.c:24:
include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
In file included from include/linux/module.h:18,
from include/linux/sysdev.h:25,
from include/linux/node.h:22,
from include/linux/swap.h:10,
from include/linux/suspend.h:7,
from arch/powerpc/kernel/asm-offsets.c:24:
include/linux/immediate.h:37: warning: ‘struct __imv’ declared
inside parameter list
include/linux/immediate.h:37: warning: its scope is only this definition
or declaration, which is probably not what you want
include/linux/immediate.h:40: warning: ‘struct __imv’ declared
inside parameter list
make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2
02/05/2009-17:57:41 Build the kernel. Failed rc = 2
02/05/2009-17:57:41 build: Building kernel... Failed rc = 1

2009-02-06 02:00:10

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Thu, Feb 05, 2009 at 04:06:27PM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney ([email protected]) wrote:
> > > On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > > > > Hi Paul,
> > > > > > > >
> > > > > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > > > > <[email protected]> wrote:
> > > > > > > > >>
> > > > > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > > > > >
> > > > > > > > > Ummm... No. I never have used quilt.
> > > > > > > > >
> > > > > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > > > > an appropriate "sh" command:
> > > > > > > >
> > > > > > > > How about trying?
> > > > > > > >
> > > > > > > > #quilt push -a
> > > > > > >
> > > > > > > Is the appropriate incantation as follows?
> > > > > > >
> > > > > > > cd <top of git tree>
> > > > > > > mkdir patches
> > > > > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > > > > quilt push -a
> > > > > > >
> > > > > >
> > > > > > Yes, exactly.
> > > > >
> > > > > Whew! ;-)
> > > > >
> > > > > > And from there you can follow the LTTng manual here :
> > > > > >
> > > > > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> > > > >
> > > > > I get some fuzz and the following:
> > > > >
> > > > > patching file kernel/trace/trace-clock-32-to-64.c
> > > > > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > > > > which already exists.
> > > > > Hunk #1 FAILED at 1.
> > > > > 1 out of 1 hunk FAILED -- rejects in file
> > > > > kernel/trace/trace-clock-32-to-64.c
> > > > >
> > > > > Should I be starting from somewhere other than v2.6.29-rc3?
> > > > >
> > > >
> > > > Let's see it step by step, that should get us there.
> > > >
> > > > With patches :
> > > >
> > > > mkdir ~/lttng
> > > > cd ~/lttng
> > > > wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> > > > wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > > > bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> > > > bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> > > > cd linux-2.6.29-rc3
> > > > mkdir patches
> > > > ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> > > > quilt push -a
> > > >
> > > > Does this work ?
> > >
> > > Leaving out the "mkdir", yes.
> >
> > Ah, yes, my mistake.
> >
> > > My apologies -- I was forgetting that
> > > "git reset --hard" doesn't get rid of untracked files. I do see fuzz
> > > in a few places, but hopefully this is non-fatal. And in any case, I
> > > can now make the patch required to actually try this out. ;-)
> > >
> >
> > Great !
> >
> > Don't hesitate to ask if you have any question.
> >
> > Mathieu
>
> Fails to build on Power, so trying x86... (Stock 2.6.29-rc3 does
> build and boot, FWIW.)
>
> Looks like misplaced file.
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> CHK include/linux/version.h
> UPD include/linux/version.h
> CHK include/linux/utsrelease.h
> UPD include/linux/utsrelease.h
> SYMLINK include/asm -> include/asm-powerpc
> HOSTCC scripts/ihex2fw
> HOSTCC scripts/kallsyms
> HOSTCC scripts/pnmtologo
> HOSTCC scripts/genksyms/genksyms.o
> HOSTCC scripts/conmakehash
> HOSTCC scripts/bin2c
> CC scripts/mod/empty.o
> HOSTCC scripts/mod/mk_elfconfig
> SHIPPED scripts/genksyms/lex.c
> SHIPPED scripts/genksyms/parse.h
> SHIPPED scripts/genksyms/keywords.c
> SHIPPED scripts/genksyms/parse.c
> HOSTCC scripts/genksyms/parse.o
> HOSTCC scripts/genksyms/lex.o
> MKELF scripts/mod/elfconfig.h
> HOSTCC scripts/mod/file2alias.o
> HOSTCC scripts/mod/modpost.o
> HOSTCC scripts/mod/sumversion.o
> HOSTLD scripts/genksyms/genksyms
> HOSTLD scripts/mod/modpost
> CC kernel/bounds.s
> GEN include/linux/bounds.h
> CC arch/powerpc/kernel/asm-offsets.s
> In file included from include/linux/module.h:18,
> from include/linux/sysdev.h:25,
> from include/linux/node.h:22,
> from include/linux/swap.h:10,
> from include/linux/suspend.h:7,
> from arch/powerpc/kernel/asm-offsets.c:24:
> include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
> In file included from include/linux/module.h:18,
> from include/linux/sysdev.h:25,
> from include/linux/node.h:22,
> from include/linux/swap.h:10,
> from include/linux/suspend.h:7,
> from arch/powerpc/kernel/asm-offsets.c:24:
> include/linux/immediate.h:37: warning: ‘struct __imv’ declared
> inside parameter list
> include/linux/immediate.h:37: warning: its scope is only this definition
> or declaration, which is probably not what you want
> include/linux/immediate.h:40: warning: ‘struct __imv’ declared
> inside parameter list
> make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> make: *** [prepare0] Error 2
> 02/05/2009-17:57:41 Build the kernel. Failed rc = 2
> 02/05/2009-17:57:41 build: Building kernel... Failed rc = 1
>

Hrm, does the file

arch/powerpc/include/asm/immediate.h exist in your tree ?

Here, with the setup done following the commands I gave you (minus the
mkdir patch), I get :


[email protected]:~$ head testpaulmck/linux-2.6.29-rc3/arch/powerpc/include/asm/immediate.h
#ifndef _ASM_POWERPC_IMMEDIATE_H
#define _ASM_POWERPC_IMMEDIATE_H

/*
* Immediate values. PowerPC architecture optimizations.
*
* (C) Copyright 2006 Mathieu Desnoyers <[email protected]>
*
* This file is released under the GPLv2.
* See the file COPYING for more details.

....

Which defines struct __imv. So hrm, normally the header should be there.
(/me still confused) :)

Mathieu

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-06 13:48:33

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Thu, Feb 05, 2009 at 09:00:05PM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Thu, Feb 05, 2009 at 04:06:27PM -0500, Mathieu Desnoyers wrote:
> > > * Paul E. McKenney ([email protected]) wrote:
> > > > On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > > > > > Hi Paul,
> > > > > > > > >
> > > > > > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > > > > > <[email protected]> wrote:
> > > > > > > > > >>
> > > > > > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > > > > > >
> > > > > > > > > > Ummm... No. I never have used quilt.
> > > > > > > > > >
> > > > > > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > > > > > an appropriate "sh" command:
> > > > > > > > >
> > > > > > > > > How about trying?
> > > > > > > > >
> > > > > > > > > #quilt push -a
> > > > > > > >
> > > > > > > > Is the appropriate incantation as follows?
> > > > > > > >
> > > > > > > > cd <top of git tree>
> > > > > > > > mkdir patches
> > > > > > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > > > > > quilt push -a
> > > > > > > >
> > > > > > >
> > > > > > > Yes, exactly.
> > > > > >
> > > > > > Whew! ;-)
> > > > > >
> > > > > > > And from there you can follow the LTTng manual here :
> > > > > > >
> > > > > > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> > > > > >
> > > > > > I get some fuzz and the following:
> > > > > >
> > > > > > patching file kernel/trace/trace-clock-32-to-64.c
> > > > > > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > > > > > which already exists.
> > > > > > Hunk #1 FAILED at 1.
> > > > > > 1 out of 1 hunk FAILED -- rejects in file
> > > > > > kernel/trace/trace-clock-32-to-64.c
> > > > > >
> > > > > > Should I be starting from somewhere other than v2.6.29-rc3?
> > > > > >
> > > > >
> > > > > Let's see it step by step, that should get us there.
> > > > >
> > > > > With patches :
> > > > >
> > > > > mkdir ~/lttng
> > > > > cd ~/lttng
> > > > > wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> > > > > wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > > > > bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> > > > > bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> > > > > cd linux-2.6.29-rc3
> > > > > mkdir patches
> > > > > ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> > > > > quilt push -a
> > > > >
> > > > > Does this work ?
> > > >
> > > > Leaving out the "mkdir", yes.
> > >
> > > Ah, yes, my mistake.
> > >
> > > > My apologies -- I was forgetting that
> > > > "git reset --hard" doesn't get rid of untracked files. I do see fuzz
> > > > in a few places, but hopefully this is non-fatal. And in any case, I
> > > > can now make the patch required to actually try this out. ;-)
> > > >
> > >
> > > Great !
> > >
> > > Don't hesitate to ask if you have any question.
> > >
> > > Mathieu
> >
> > Fails to build on Power, so trying x86... (Stock 2.6.29-rc3 does
> > build and boot, FWIW.)
> >
> > Looks like misplaced file.
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > CHK include/linux/version.h
> > UPD include/linux/version.h
> > CHK include/linux/utsrelease.h
> > UPD include/linux/utsrelease.h
> > SYMLINK include/asm -> include/asm-powerpc
> > HOSTCC scripts/ihex2fw
> > HOSTCC scripts/kallsyms
> > HOSTCC scripts/pnmtologo
> > HOSTCC scripts/genksyms/genksyms.o
> > HOSTCC scripts/conmakehash
> > HOSTCC scripts/bin2c
> > CC scripts/mod/empty.o
> > HOSTCC scripts/mod/mk_elfconfig
> > SHIPPED scripts/genksyms/lex.c
> > SHIPPED scripts/genksyms/parse.h
> > SHIPPED scripts/genksyms/keywords.c
> > SHIPPED scripts/genksyms/parse.c
> > HOSTCC scripts/genksyms/parse.o
> > HOSTCC scripts/genksyms/lex.o
> > MKELF scripts/mod/elfconfig.h
> > HOSTCC scripts/mod/file2alias.o
> > HOSTCC scripts/mod/modpost.o
> > HOSTCC scripts/mod/sumversion.o
> > HOSTLD scripts/genksyms/genksyms
> > HOSTLD scripts/mod/modpost
> > CC kernel/bounds.s
> > GEN include/linux/bounds.h
> > CC arch/powerpc/kernel/asm-offsets.s
> > In file included from include/linux/module.h:18,
> > from include/linux/sysdev.h:25,
> > from include/linux/node.h:22,
> > from include/linux/swap.h:10,
> > from include/linux/suspend.h:7,
> > from arch/powerpc/kernel/asm-offsets.c:24:
> > include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
> > In file included from include/linux/module.h:18,
> > from include/linux/sysdev.h:25,
> > from include/linux/node.h:22,
> > from include/linux/swap.h:10,
> > from include/linux/suspend.h:7,
> > from arch/powerpc/kernel/asm-offsets.c:24:
> > include/linux/immediate.h:37: warning: ‘struct __imv’ declared
> > inside parameter list
> > include/linux/immediate.h:37: warning: its scope is only this definition
> > or declaration, which is probably not what you want
> > include/linux/immediate.h:40: warning: ‘struct __imv’ declared
> > inside parameter list
> > make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> > make: *** [prepare0] Error 2
> > 02/05/2009-17:57:41 Build the kernel. Failed rc = 2
> > 02/05/2009-17:57:41 build: Building kernel... Failed rc = 1
> >
>
> Hrm, does the file
>
> arch/powerpc/include/asm/immediate.h exist in your tree ?
>
> Here, with the setup done following the commands I gave you (minus the
> mkdir patch), I get :
>
>
> [email protected]:~$ head testpaulmck/linux-2.6.29-rc3/arch/powerpc/include/asm/immediate.h
> #ifndef _ASM_POWERPC_IMMEDIATE_H
> #define _ASM_POWERPC_IMMEDIATE_H
>
> /*
> * Immediate values. PowerPC architecture optimizations.
> *
> * (C) Copyright 2006 Mathieu Desnoyers <[email protected]>
> *
> * This file is released under the GPLv2.
> * See the file COPYING for more details.
>
> ....
>
> Which defines struct __imv. So hrm, normally the header should be there.
> (/me still confused) :)

It does indeed, see the patch I generated against 2.6.29-rc3:

http://www.rdrop.com/users/paulmck/patches/2.6.29-rc3-ltt-1.patch

I get a similar failure on x86 -- perhaps my tools or build environment
does not match yours?

Thanx, Paul

2009-02-06 20:03:38

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

* Paul E. McKenney ([email protected]) wrote:
> On Thu, Feb 05, 2009 at 09:00:05PM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney ([email protected]) wrote:
> > > On Thu, Feb 05, 2009 at 04:06:27PM -0500, Mathieu Desnoyers wrote:
> > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> > > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > > > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > > > > > > Hi Paul,
> > > > > > > > > >
> > > > > > > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > > > > > > <[email protected]> wrote:
> > > > > > > > > > >>
> > > > > > > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > > > > > > >
> > > > > > > > > > > Ummm... No. I never have used quilt.
> > > > > > > > > > >
> > > > > > > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > > > > > > an appropriate "sh" command:
> > > > > > > > > >
> > > > > > > > > > How about trying?
> > > > > > > > > >
> > > > > > > > > > #quilt push -a
> > > > > > > > >
> > > > > > > > > Is the appropriate incantation as follows?
> > > > > > > > >
> > > > > > > > > cd <top of git tree>
> > > > > > > > > mkdir patches
> > > > > > > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > > > > > > quilt push -a
> > > > > > > > >
> > > > > > > >
> > > > > > > > Yes, exactly.
> > > > > > >
> > > > > > > Whew! ;-)
> > > > > > >
> > > > > > > > And from there you can follow the LTTng manual here :
> > > > > > > >
> > > > > > > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> > > > > > >
> > > > > > > I get some fuzz and the following:
> > > > > > >
> > > > > > > patching file kernel/trace/trace-clock-32-to-64.c
> > > > > > > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > > > > > > which already exists.
> > > > > > > Hunk #1 FAILED at 1.
> > > > > > > 1 out of 1 hunk FAILED -- rejects in file
> > > > > > > kernel/trace/trace-clock-32-to-64.c
> > > > > > >
> > > > > > > Should I be starting from somewhere other than v2.6.29-rc3?
> > > > > > >
> > > > > >
> > > > > > Let's see it step by step, that should get us there.
> > > > > >
> > > > > > With patches :
> > > > > >
> > > > > > mkdir ~/lttng
> > > > > > cd ~/lttng
> > > > > > wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> > > > > > wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > > > > > bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> > > > > > bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> > > > > > cd linux-2.6.29-rc3
> > > > > > mkdir patches
> > > > > > ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> > > > > > quilt push -a
> > > > > >
> > > > > > Does this work ?
> > > > >
> > > > > Leaving out the "mkdir", yes.
> > > >
> > > > Ah, yes, my mistake.
> > > >
> > > > > My apologies -- I was forgetting that
> > > > > "git reset --hard" doesn't get rid of untracked files. I do see fuzz
> > > > > in a few places, but hopefully this is non-fatal. And in any case, I
> > > > > can now make the patch required to actually try this out. ;-)
> > > > >
> > > >
> > > > Great !
> > > >
> > > > Don't hesitate to ask if you have any question.
> > > >
> > > > Mathieu
> > >
> > > Fails to build on Power, so trying x86... (Stock 2.6.29-rc3 does
> > > build and boot, FWIW.)
> > >
> > > Looks like misplaced file.
> > >
> > > Thanx, Paul
> > >
> > > ------------------------------------------------------------------------
> > >
> > > CHK include/linux/version.h
> > > UPD include/linux/version.h
> > > CHK include/linux/utsrelease.h
> > > UPD include/linux/utsrelease.h
> > > SYMLINK include/asm -> include/asm-powerpc
> > > HOSTCC scripts/ihex2fw
> > > HOSTCC scripts/kallsyms
> > > HOSTCC scripts/pnmtologo
> > > HOSTCC scripts/genksyms/genksyms.o
> > > HOSTCC scripts/conmakehash
> > > HOSTCC scripts/bin2c
> > > CC scripts/mod/empty.o
> > > HOSTCC scripts/mod/mk_elfconfig
> > > SHIPPED scripts/genksyms/lex.c
> > > SHIPPED scripts/genksyms/parse.h
> > > SHIPPED scripts/genksyms/keywords.c
> > > SHIPPED scripts/genksyms/parse.c
> > > HOSTCC scripts/genksyms/parse.o
> > > HOSTCC scripts/genksyms/lex.o
> > > MKELF scripts/mod/elfconfig.h
> > > HOSTCC scripts/mod/file2alias.o
> > > HOSTCC scripts/mod/modpost.o
> > > HOSTCC scripts/mod/sumversion.o
> > > HOSTLD scripts/genksyms/genksyms
> > > HOSTLD scripts/mod/modpost
> > > CC kernel/bounds.s
> > > GEN include/linux/bounds.h
> > > CC arch/powerpc/kernel/asm-offsets.s
> > > In file included from include/linux/module.h:18,
> > > from include/linux/sysdev.h:25,
> > > from include/linux/node.h:22,
> > > from include/linux/swap.h:10,
> > > from include/linux/suspend.h:7,
> > > from arch/powerpc/kernel/asm-offsets.c:24:
> > > include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
> > > In file included from include/linux/module.h:18,
> > > from include/linux/sysdev.h:25,
> > > from include/linux/node.h:22,
> > > from include/linux/swap.h:10,
> > > from include/linux/suspend.h:7,
> > > from arch/powerpc/kernel/asm-offsets.c:24:
> > > include/linux/immediate.h:37: warning: ‘struct __imv’ declared
> > > inside parameter list
> > > include/linux/immediate.h:37: warning: its scope is only this definition
> > > or declaration, which is probably not what you want
> > > include/linux/immediate.h:40: warning: ‘struct __imv’ declared
> > > inside parameter list
> > > make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> > > make: *** [prepare0] Error 2
> > > 02/05/2009-17:57:41 Build the kernel. Failed rc = 2
> > > 02/05/2009-17:57:41 build: Building kernel... Failed rc = 1
> > >
> >
> > Hrm, does the file
> >
> > arch/powerpc/include/asm/immediate.h exist in your tree ?
> >
> > Here, with the setup done following the commands I gave you (minus the
> > mkdir patch), I get :
> >
> >
> > [email protected]:~$ head testpaulmck/linux-2.6.29-rc3/arch/powerpc/include/asm/immediate.h
> > #ifndef _ASM_POWERPC_IMMEDIATE_H
> > #define _ASM_POWERPC_IMMEDIATE_H
> >
> > /*
> > * Immediate values. PowerPC architecture optimizations.
> > *
> > * (C) Copyright 2006 Mathieu Desnoyers <[email protected]>
> > *
> > * This file is released under the GPLv2.
> > * See the file COPYING for more details.
> >
> > ....
> >
> > Which defines struct __imv. So hrm, normally the header should be there.
> > (/me still confused) :)
>
> It does indeed, see the patch I generated against 2.6.29-rc3:
>
> http://www.rdrop.com/users/paulmck/patches/2.6.29-rc3-ltt-1.patch
>
> I get a similar failure on x86 -- perhaps my tools or build environment
> does not match yours?
>

Maybe. If you want a quick and dirty solution, try :

CONFIG_IMMEDIATE=n

Immediate values are just an optimization, not necessary anyway.

Mathieu

> Thanx, Paul
>

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-02-06 21:37:03

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Fri, Feb 06, 2009 at 03:03:29PM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney ([email protected]) wrote:
> > On Thu, Feb 05, 2009 at 09:00:05PM -0500, Mathieu Desnoyers wrote:
> > > * Paul E. McKenney ([email protected]) wrote:
> > > > On Thu, Feb 05, 2009 at 04:06:27PM -0500, Mathieu Desnoyers wrote:
> > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > On Thu, Feb 05, 2009 at 03:22:49PM -0500, Mathieu Desnoyers wrote:
> > > > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > > > On Thu, Feb 05, 2009 at 01:31:59PM -0500, Mathieu Desnoyers wrote:
> > > > > > > > > * Paul E. McKenney ([email protected]) wrote:
> > > > > > > > > > On Thu, Feb 05, 2009 at 09:52:16PM +0530, Trilok Soni wrote:
> > > > > > > > > > > Hi Paul,
> > > > > > > > > > >
> > > > > > > > > > > On Thu, Feb 5, 2009 at 9:28 PM, Paul E. McKenney
> > > > > > > > > > > <[email protected]> wrote:
> > > > > > > > > > > >>
> > > > > > > > > > > >> Are you using quilt to apply the patchset series file in the right order ?
> > > > > > > > > > > >
> > > > > > > > > > > > Ummm... No. I never have used quilt.
> > > > > > > > > > > >
> > > > > > > > > > > > Ah, there is a series file. I guess it would not be too hard to make
> > > > > > > > > > > > an appropriate "sh" command:
> > > > > > > > > > >
> > > > > > > > > > > How about trying?
> > > > > > > > > > >
> > > > > > > > > > > #quilt push -a
> > > > > > > > > >
> > > > > > > > > > Is the appropriate incantation as follows?
> > > > > > > > > >
> > > > > > > > > > cd <top of git tree>
> > > > > > > > > > mkdir patches
> > > > > > > > > > cp /tmp/patch-2.6.29-rc3-lttng-0.92/* patches
> > > > > > > > > > quilt push -a
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > Yes, exactly.
> > > > > > > >
> > > > > > > > Whew! ;-)
> > > > > > > >
> > > > > > > > > And from there you can follow the LTTng manual here :
> > > > > > > > >
> > > > > > > > > http://ltt.polymtl.ca/svn/trunk/lttv/LTTngManual.html
> > > > > > > >
> > > > > > > > I get some fuzz and the following:
> > > > > > > >
> > > > > > > > patching file kernel/trace/trace-clock-32-to-64.c
> > > > > > > > Patch attempted to create file kernel/trace/trace-clock-32-to-64.c,
> > > > > > > > which already exists.
> > > > > > > > Hunk #1 FAILED at 1.
> > > > > > > > 1 out of 1 hunk FAILED -- rejects in file
> > > > > > > > kernel/trace/trace-clock-32-to-64.c
> > > > > > > >
> > > > > > > > Should I be starting from somewhere other than v2.6.29-rc3?
> > > > > > > >
> > > > > > >
> > > > > > > Let's see it step by step, that should get us there.
> > > > > > >
> > > > > > > With patches :
> > > > > > >
> > > > > > > mkdir ~/lttng
> > > > > > > cd ~/lttng
> > > > > > > wget http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.29-rc3.tar.bz2
> > > > > > > wget http://lttng.org/files/lttng/patch-2.6.29-rc3-lttng-0.92.tar.bz2
> > > > > > > bzip2 -cd linux-2.6.29-rc3.tar.bz2 |tar xvof -
> > > > > > > bzip2 -cd patch-2.6.29-rc3-lttng-0.92.tar.bz2 |tar xvof -
> > > > > > > cd linux-2.6.29-rc3
> > > > > > > mkdir patches
> > > > > > > ln -s ../patch-2.6.29-rc3-lttng-0.92 patches
> > > > > > > quilt push -a
> > > > > > >
> > > > > > > Does this work ?
> > > > > >
> > > > > > Leaving out the "mkdir", yes.
> > > > >
> > > > > Ah, yes, my mistake.
> > > > >
> > > > > > My apologies -- I was forgetting that
> > > > > > "git reset --hard" doesn't get rid of untracked files. I do see fuzz
> > > > > > in a few places, but hopefully this is non-fatal. And in any case, I
> > > > > > can now make the patch required to actually try this out. ;-)
> > > > > >
> > > > >
> > > > > Great !
> > > > >
> > > > > Don't hesitate to ask if you have any question.
> > > > >
> > > > > Mathieu
> > > >
> > > > Fails to build on Power, so trying x86... (Stock 2.6.29-rc3 does
> > > > build and boot, FWIW.)
> > > >
> > > > Looks like misplaced file.
> > > >
> > > > Thanx, Paul
> > > >
> > > > ------------------------------------------------------------------------
> > > >
> > > > CHK include/linux/version.h
> > > > UPD include/linux/version.h
> > > > CHK include/linux/utsrelease.h
> > > > UPD include/linux/utsrelease.h
> > > > SYMLINK include/asm -> include/asm-powerpc
> > > > HOSTCC scripts/ihex2fw
> > > > HOSTCC scripts/kallsyms
> > > > HOSTCC scripts/pnmtologo
> > > > HOSTCC scripts/genksyms/genksyms.o
> > > > HOSTCC scripts/conmakehash
> > > > HOSTCC scripts/bin2c
> > > > CC scripts/mod/empty.o
> > > > HOSTCC scripts/mod/mk_elfconfig
> > > > SHIPPED scripts/genksyms/lex.c
> > > > SHIPPED scripts/genksyms/parse.h
> > > > SHIPPED scripts/genksyms/keywords.c
> > > > SHIPPED scripts/genksyms/parse.c
> > > > HOSTCC scripts/genksyms/parse.o
> > > > HOSTCC scripts/genksyms/lex.o
> > > > MKELF scripts/mod/elfconfig.h
> > > > HOSTCC scripts/mod/file2alias.o
> > > > HOSTCC scripts/mod/modpost.o
> > > > HOSTCC scripts/mod/sumversion.o
> > > > HOSTLD scripts/genksyms/genksyms
> > > > HOSTLD scripts/mod/modpost
> > > > CC kernel/bounds.s
> > > > GEN include/linux/bounds.h
> > > > CC arch/powerpc/kernel/asm-offsets.s
> > > > In file included from include/linux/module.h:18,
> > > > from include/linux/sysdev.h:25,
> > > > from include/linux/node.h:22,
> > > > from include/linux/swap.h:10,
> > > > from include/linux/suspend.h:7,
> > > > from arch/powerpc/kernel/asm-offsets.c:24:
> > > > include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
> > > > In file included from include/linux/module.h:18,
> > > > from include/linux/sysdev.h:25,
> > > > from include/linux/node.h:22,
> > > > from include/linux/swap.h:10,
> > > > from include/linux/suspend.h:7,
> > > > from arch/powerpc/kernel/asm-offsets.c:24:
> > > > include/linux/immediate.h:37: warning: ‘struct __imv’ declared
> > > > inside parameter list
> > > > include/linux/immediate.h:37: warning: its scope is only this definition
> > > > or declaration, which is probably not what you want
> > > > include/linux/immediate.h:40: warning: ‘struct __imv’ declared
> > > > inside parameter list
> > > > make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> > > > make: *** [prepare0] Error 2
> > > > 02/05/2009-17:57:41 Build the kernel. Failed rc = 2
> > > > 02/05/2009-17:57:41 build: Building kernel... Failed rc = 1
> > > >
> > >
> > > Hrm, does the file
> > >
> > > arch/powerpc/include/asm/immediate.h exist in your tree ?
> > >
> > > Here, with the setup done following the commands I gave you (minus the
> > > mkdir patch), I get :
> > >
> > >
> > > [email protected]:~$ head testpaulmck/linux-2.6.29-rc3/arch/powerpc/include/asm/immediate.h
> > > #ifndef _ASM_POWERPC_IMMEDIATE_H
> > > #define _ASM_POWERPC_IMMEDIATE_H
> > >
> > > /*
> > > * Immediate values. PowerPC architecture optimizations.
> > > *
> > > * (C) Copyright 2006 Mathieu Desnoyers <[email protected]>
> > > *
> > > * This file is released under the GPLv2.
> > > * See the file COPYING for more details.
> > >
> > > ....
> > >
> > > Which defines struct __imv. So hrm, normally the header should be there.
> > > (/me still confused) :)
> >
> > It does indeed, see the patch I generated against 2.6.29-rc3:
> >
> > http://www.rdrop.com/users/paulmck/patches/2.6.29-rc3-ltt-1.patch
> >
> > I get a similar failure on x86 -- perhaps my tools or build environment
> > does not match yours?
> >
>
> Maybe. If you want a quick and dirty solution, try :
>
> CONFIG_IMMEDIATE=n
>
> Immediate values are just an optimization, not necessary anyway.

K -- kicking it off.

Thanx, Paul

2009-02-08 15:47:08

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Fri, Feb 06, 2009 at 01:37:01PM -0800, Paul E. McKenney wrote:
> On Fri, Feb 06, 2009 at 03:03:29PM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney ([email protected]) wrote:
> > > On Thu, Feb 05, 2009 at 09:00:05PM -0500, Mathieu Desnoyers wrote:
> > > > * Paul E. McKenney ([email protected]) wrote:

[ . . . ]

> > > > > CC arch/powerpc/kernel/asm-offsets.s
> > > > > In file included from include/linux/module.h:18,
> > > > > from include/linux/sysdev.h:25,
> > > > > from include/linux/node.h:22,
> > > > > from include/linux/swap.h:10,
> > > > > from include/linux/suspend.h:7,
> > > > > from arch/powerpc/kernel/asm-offsets.c:24:
> > > > > include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
> > > > > In file included from include/linux/module.h:18,
> > > > > from include/linux/sysdev.h:25,
> > > > > from include/linux/node.h:22,
> > > > > from include/linux/swap.h:10,
> > > > > from include/linux/suspend.h:7,
> > > > > from arch/powerpc/kernel/asm-offsets.c:24:
> > > > > include/linux/immediate.h:37: warning: ‘struct __imv’ declared
> > > > > inside parameter list
> > > > > include/linux/immediate.h:37: warning: its scope is only this definition
> > > > > or declaration, which is probably not what you want
> > > > > include/linux/immediate.h:40: warning: ‘struct __imv’ declared
> > > > > inside parameter list
> > > > > make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> > > > > make: *** [prepare0] Error 2
> > > > > 02/05/2009-17:57:41 Build the kernel. Failed rc = 2
> > > > > 02/05/2009-17:57:41 build: Building kernel... Failed rc = 1
> > > > >
> > > >
> > > > Hrm, does the file
> > > >
> > > > arch/powerpc/include/asm/immediate.h exist in your tree ?
> > > >
> > > > Here, with the setup done following the commands I gave you (minus the
> > > > mkdir patch), I get :
> > > >
> > > >
> > > > [email protected]:~$ head testpaulmck/linux-2.6.29-rc3/arch/powerpc/include/asm/immediate.h
> > > > #ifndef _ASM_POWERPC_IMMEDIATE_H
> > > > #define _ASM_POWERPC_IMMEDIATE_H
> > > >
> > > > /*
> > > > * Immediate values. PowerPC architecture optimizations.
> > > > *
> > > > * (C) Copyright 2006 Mathieu Desnoyers <[email protected]>
> > > > *
> > > > * This file is released under the GPLv2.
> > > > * See the file COPYING for more details.
> > > >
> > > > ....
> > > >
> > > > Which defines struct __imv. So hrm, normally the header should be there.
> > > > (/me still confused) :)
> > >
> > > It does indeed, see the patch I generated against 2.6.29-rc3:
> > >
> > > http://www.rdrop.com/users/paulmck/patches/2.6.29-rc3-ltt-1.patch
> > >
> > > I get a similar failure on x86 -- perhaps my tools or build environment
> > > does not match yours?
> > >
> >
> > Maybe. If you want a quick and dirty solution, try :
> >
> > CONFIG_IMMEDIATE=n
> >
> > Immediate values are just an optimization, not necessary anyway.
>
> K -- kicking it off.

One thing that helps on 32-bit x86 is removing the "select HAVE_IMMEDIATE"
that you added to arch/x86/Kconfig. I then get assembly errors:

AS arch/x86/kernel/entry_32.o
arch/x86/kernel/entry_32.S: Assembler messages:
arch/x86/kernel/entry_32.S:272: Error: invalid character '_' in
mnemonic
make[1]: *** [arch/x86/kernel/entry_32.o] Error 1
make: *** [arch/x86/kernel] Error 2

This seems to point to the following new line:

INTERRUPT_RETURN_NMI_SAFE

Replacing this with the NATIVE_INTERRUPT_RETURN_NMI_SAFE that appears
elsewhere did not help.

Over to you!

Thanx, Paul