2009-05-15 03:16:43

by 홍신 shin hong

[permalink] [raw]
Subject: a suggestion for ext2_release_file()

Hi. I have a suggestion while I read ext2 code in recent Linux.

mark_files_ro() function in fs/super.c turns off FMODE_WRITE
of every file in a super block for the case of remounting.

However, an inode whose file's mode is FMODE_WRITE may hold
reservations. I think these reservations lost their chance to be discarded
since FMODE_WRITE is off.

So, I think ext2_release_file rather check

Could you check my suggestion is valid or not please?

Shin Hong