2009-08-06 23:07:54

by Andrew Morton

[permalink] [raw]
Subject: [patch 1/1] ext4: remove redundant test on unsigned

From: Roel Kluin <[email protected]>

unsigned i_block cannot be less than 0.

Signed-off-by: Roel Kluin <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---

fs/ext4/inode.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff -puN fs/ext4/inode.c~ext4-remove-redundant-test-on-unsigned fs/ext4/inode.c
--- a/fs/ext4/inode.c~ext4-remove-redundant-test-on-unsigned
+++ a/fs/ext4/inode.c
@@ -343,9 +343,7 @@ static int ext4_block_to_path(struct ino
int n = 0;
int final = 0;

- if (i_block < 0) {
- ext4_warning(inode->i_sb, "ext4_block_to_path", "block < 0");
- } else if (i_block < direct_blocks) {
+ if (i_block < direct_blocks) {
offsets[n++] = i_block;
final = direct_blocks;
} else if ((i_block -= direct_blocks) < indirect_blocks) {
_