2009-12-07 13:48:58

by Roel Kluin

Subject: [PATCH] ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks()

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <[email protected]>
---
fs/ext3/resize.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c
index 8359e7b..5f83b61 100644
--- a/fs/ext3/resize.c
+++ b/fs/ext3/resize.c
@@ -266,7 +266,7 @@ static int setup_new_group_blocks(struct super_block *sb,
goto exit_bh;

if (IS_ERR(gdb = bclean(handle, sb, block))) {
- err = PTR_ERR(bh);
+ err = PTR_ERR(gdb);
goto exit_bh;
}
ext3_journal_dirty_metadata(handle, gdb);

2009-12-07 15:37:28

by Theodore Ts'o

Subject: Re: [PATCH] ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks()

On Mon, Dec 07, 2009 at 02:50:11PM +0100, Roel Kluin wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <[email protected]>

Reviewed-by: "Theodore Ts'o" <[email protected]>

Thanks for pointing this out! I've added a similar patch for ext4 in
the patch queue.

- Ted