2021-11-04 06:40:32

by xu xin

[permalink] [raw]
Subject: [PATCH v2] ext4: Remove unused assignments

From: luo penghao <[email protected]>

The eh assignment in these two places is meaningless, because the
function will goto to merge, which will not use eh.

The clang_analyzer complains as follows:

fs/ext4/extents.c:1988:4 warning:
fs/ext4/extents.c:2016:4 warning:

Value stored to 'eh' is never read

change in v2:

Repair the sending email box

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: luo penghao <[email protected]>
---
fs/ext4/extents.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index b1933e3..9ed8a15 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1986,7 +1986,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
+ ext4_ext_get_actual_len(newext));
if (unwritten)
ext4_ext_mark_unwritten(ex);
- eh = path[depth].p_hdr;
nearex = ex;
goto merge;
}
@@ -2015,7 +2014,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
+ ext4_ext_get_actual_len(newext));
if (unwritten)
ext4_ext_mark_unwritten(ex);
- eh = path[depth].p_hdr;
nearex = ex;
goto merge;
}
--
2.15.2



2022-01-05 23:39:54

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH v2] ext4: Remove unused assignments

On Thu, 4 Nov 2021 06:40:07 +0000, [email protected] wrote:
> From: luo penghao <[email protected]>
>
> The eh assignment in these two places is meaningless, because the
> function will goto to merge, which will not use eh.
>
> The clang_analyzer complains as follows:
>
> [...]

Applied, thanks!

[1/1] ext4: remove unused assignments
commit: 4bf7773e5a636b80de2b9025a7e107b38fe189b9

Best regards,
--
Theodore Ts'o <[email protected]>