2021-12-15 11:43:44

by Dan Carpenter

[permalink] [raw]
Subject: [PATCH] ext4: fix a copy and paste typo

This was obviously supposed to be an ext4 struct, not xfs. GCC
doesn't care either way so it doesn't affect the build or runtime.

Fixes: cebe85d570cf ("ext4: switch to the new mount api")
Signed-off-by: Dan Carpenter <[email protected]>
---
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 5ec5a1c3b364..da40fb468d7f 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2077,7 +2077,7 @@ static void ext4_fc_free(struct fs_context *fc)

int ext4_init_fs_context(struct fs_context *fc)
{
- struct xfs_fs_context *ctx;
+ struct ext4_fs_context *ctx;

ctx = kzalloc(sizeof(struct ext4_fs_context), GFP_KERNEL);
if (!ctx)
--
2.20.1



2021-12-15 12:10:52

by Lukas Czerner

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix a copy and paste typo

On Wed, Dec 15, 2021 at 02:43:09PM +0300, Dan Carpenter wrote:
> This was obviously supposed to be an ext4 struct, not xfs. GCC
> doesn't care either way so it doesn't affect the build or runtime.

Wow, what a mistake. Nice catch, thanks!

Reviewed-by: Lukas Czerner <[email protected]>

>
> Fixes: cebe85d570cf ("ext4: switch to the new mount api")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 5ec5a1c3b364..da40fb468d7f 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2077,7 +2077,7 @@ static void ext4_fc_free(struct fs_context *fc)
>
> int ext4_init_fs_context(struct fs_context *fc)
> {
> - struct xfs_fs_context *ctx;
> + struct ext4_fs_context *ctx;
>
> ctx = kzalloc(sizeof(struct ext4_fs_context), GFP_KERNEL);
> if (!ctx)
> --
> 2.20.1
>


2022-01-06 04:42:09

by Theodore Y. Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix a copy and paste typo

On Wed, 15 Dec 2021 14:43:09 +0300, Dan Carpenter wrote:
> This was obviously supposed to be an ext4 struct, not xfs. GCC
> doesn't care either way so it doesn't affect the build or runtime.
>
>

Applied, thanks!

[1/1] ext4: fix a copy and paste typo
commit: 42e2b7ca9b4d4a9bb350910a2a66628699365572

Best regards,
--
Theodore Ts'o <[email protected]>