2022-08-18 16:46:18

by Jürg Billeter

Subject: [PATCH] create_inode: do not fail if filesystem doesn't support xattr

As `set_inode_xattr()` doesn't fail if the `llistxattr()` function is
not available, it seems inconsistent to let `set_inode_xattr()` fail if
`llistxattr()` fails with `ENOTSUP`, indicating that the filesystem
doesn't support extended attributes.

Signed-off-by: Jürg Billeter <[email protected]>
---
misc/create_inode.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/misc/create_inode.c b/misc/create_inode.c
index c00d5458..d7ab1c20 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -150,6 +150,8 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,

size = llistxattr(filename, NULL, 0);
if (size == -1) {
+ if (errno == ENOTSUP)
+ return 0;
retval = errno;
com_err(__func__, retval, _("while listing attributes of \"%s\""),
filename);
--
2.35.3

2022-09-19 12:38:36

by Theodore Ts'o

Subject: Re: [PATCH] create_inode: do not fail if filesystem doesn't support xattr

On Thu, 18 Aug 2022 18:31:32 +0200, Jürg Billeter wrote:
> As `set_inode_xattr()` doesn't fail if the `llistxattr()` function is
> not available, it seems inconsistent to let `set_inode_xattr()` fail if
> `llistxattr()` fails with `ENOTSUP`, indicating that the filesystem
> doesn't support extended attributes.
>
>

Applied, thanks!

[1/1] create_inode: do not fail if filesystem doesn't support xattr
commit: 985b46c55070c62153587e5b18ecb5310706546c

Best regards,
--
Theodore Ts'o <[email protected]>