2022-09-16 08:28:57

by Ye Bin

[permalink] [raw]
Subject: [PATCH -next v2 2/2] ext4: adjust fast commit disable judgement order in ext4_fc_track_inode

If fastcommit is already disabled, there isn't need to mark inode ineligible.
So move 'ext4_fc_disabled()' judgement bofore 'ext4_should_journal_data(inode)'
judgement which can avoid to do meaningless judgement.

Signed-off-by: Ye Bin <[email protected]>
---
fs/ext4/fast_commit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index eadab945b856..9217a588afd1 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -577,15 +577,15 @@ void ext4_fc_track_inode(handle_t *handle, struct inode *inode)
if (S_ISDIR(inode->i_mode))
return;

+ if (ext4_fc_disabled(inode->i_sb))
+ return;
+
if (ext4_should_journal_data(inode)) {
ext4_fc_mark_ineligible(inode->i_sb,
EXT4_FC_REASON_INODE_JOURNAL_DATA, handle);
return;
}

- if (ext4_fc_disabled(inode->i_sb))
- return;
-
if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
return;

--
2.31.1


2022-09-19 08:50:30

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH -next v2 2/2] ext4: adjust fast commit disable judgement order in ext4_fc_track_inode

On Fri 16-09-22 16:38:36, Ye Bin wrote:
> If fastcommit is already disabled, there isn't need to mark inode ineligible.
> So move 'ext4_fc_disabled()' judgement bofore 'ext4_should_journal_data(inode)'
> judgement which can avoid to do meaningless judgement.
>
> Signed-off-by: Ye Bin <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/fast_commit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index eadab945b856..9217a588afd1 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -577,15 +577,15 @@ void ext4_fc_track_inode(handle_t *handle, struct inode *inode)
> if (S_ISDIR(inode->i_mode))
> return;
>
> + if (ext4_fc_disabled(inode->i_sb))
> + return;
> +
> if (ext4_should_journal_data(inode)) {
> ext4_fc_mark_ineligible(inode->i_sb,
> EXT4_FC_REASON_INODE_JOURNAL_DATA, handle);
> return;
> }
>
> - if (ext4_fc_disabled(inode->i_sb))
> - return;
> -
> if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
> return;
>
> --
> 2.31.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR