From: Hirokazu Takahashi Subject: [BUG] [FIX] warning on NFS readlink Date: Tue, 17 Sep 2002 17:01:32 +0900 (JST) Sender: nfs-admin@lists.sourceforge.net Message-ID: <20020917.170132.58443699.taka@valinux.co.jp> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Return-path: Received: from sv1.valinux.co.jp ([202.221.173.100]) by usw-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 17rDQa-0002hI-00 for ; Tue, 17 Sep 2002 01:09:48 -0700 Received: from localhost (gw1.valinux.co.jp [202.221.173.98]) by sv1.valinux.co.jp (Postfix) with ESMTP id 34A1E70020 for ; Tue, 17 Sep 2002 17:09:43 +0900 (JST) To: nfs@lists.sourceforge.net Errors-To: nfs-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Unsubscribe: , List-Archive: Hello, I found a trivial problem that kernel might warn "RPC request reserved 1144 but used 1936" when NFS-readlink is requested. This case will happen when symbolic-link file is very big as nfsd_procedure3[] table assumes max-size of symbolic-link file is 256 bytes. It should be change to NFS3_MAXPATHLEN. Here is a patch against linux-2.5.35. And we should also fix it on linux-2.4.19. Thank you, Hirokazu Takahashi. --- linux.ORG/fs/nfsd/nfsproc.c Mon Sep 16 11:18:25 2002 +++ linux/fs/nfsd/nfsproc.c Tue Sep 17 16:07:04 2030 @@ -545,7 +545,7 @@ struct svc_procedure nfsd_procedures2[1 PROC(setattr, sattrargs, attrstat, fhandle, RC_REPLBUFF, ST+AT), PROC(none, void, void, none, RC_NOCACHE, ST), PROC(lookup, diropargs, diropres, fhandle, RC_NOCACHE, ST+FH+AT), - PROC(readlink, fhandle, readlinkres, none, RC_NOCACHE, ST+1+256), + PROC(readlink, fhandle, readlinkres, none, RC_NOCACHE, ST+1+NFS_MAXPATHLEN), PROC(read, readargs, readres, fhandle, RC_NOCACHE, ST+AT+1+NFSSVC_MAXBLKSIZE), PROC(none, void, void, none, RC_NOCACHE, ST), PROC(write, writeargs, attrstat, fhandle, RC_REPLBUFF, ST+AT), --- linux.ORG/fs/nfsd/nfs3proc.c Mon Sep 16 11:18:26 2002 +++ linux/fs/nfsd/nfs3proc.c Tue Sep 17 16:06:41 2030 @@ -670,7 +670,7 @@ struct svc_procedure nfsd_procedures3[2 PROC(setattr, sattr, wccstat, fhandle, RC_REPLBUFF, ST+WC), PROC(lookup, dirop, dirop, fhandle2, RC_NOCACHE, ST+FH+pAT+pAT), PROC(access, access, access, fhandle, RC_NOCACHE, ST+pAT+1), - PROC(readlink, fhandle, readlink, fhandle, RC_NOCACHE, ST+pAT+1+256), + PROC(readlink, fhandle, readlink, fhandle, RC_NOCACHE, ST+pAT+1+NFS3_MAXPATHLEN), PROC(read, read, read, fhandle, RC_NOCACHE, ST+pAT+4+NFSSVC_MAXBLKSIZE), PROC(write, write, write, fhandle, RC_REPLBUFF, ST+WC+4), PROC(create, create, create, fhandle2, RC_REPLBUFF, ST+(1+FH+pAT)+WC), ------------------------------------------------------- Sponsored by: AMD - Your access to the experts on Hammer Technology! Open Source & Linux Developers, register now for the AMD Developer Symposium. Code: EX8664 http://www.developwithamd.com/developerlab _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs