From: Danny Smith Subject: Re: linux 2.4.20 oops Date: Tue, 29 Apr 2003 10:44:42 +0100 Sender: nfs-admin@lists.sourceforge.net Message-ID: <3EAE498A.1000106@cinesite.co.uk> References: <8147E1B07201DD41B6B9F0D31E07B384449055@srv-grp-s07.dev.atos.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: nfs@lists.sourceforge.net Return-path: Received: from scanman.cinesite.co.uk ([193.203.81.129]) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 19ARfu-0002TS-00 for ; Tue, 29 Apr 2003 02:45:22 -0700 To: =?ISO-8859-1?Q?Brasseur_Val=E9ry?= In-Reply-To: <8147E1B07201DD41B6B9F0D31E07B384449055@srv-grp-s07.dev.atos.fr> Errors-To: nfs-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Unsubscribe: , List-Archive: Brasseur Val=E9ry wrote: >I have got this oops in my kernel (2.4.20 + NFS-ALL ) >note : the oops are not log in syslog (don't know why !) >but the oops seems nfs-related, any ideas ? > We had almost identical oopses with the same setup on our dual render box= es, which would often panic almost immediately afterwards. We used this patch from Ulrich Weigand (weigand@informatik.uni-erlangen.d= e), and haven't seen a problem since. See the archives for full details - basical= ly seems to be an SMP race in rpc_delete_timer(). If you're not on an SMP system, it's probably NOT the right fix. HTH, Danny Index: net/sunrpc/sched.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/cvs/linux-2.3/net/sunrpc/sched.c,v retrieving revision 1.13 diff -u -p -r1.13 sched.c --- net/sunrpc/sched.c 3 May 2001 16:18:18 -0000 1.13 +++ net/sunrpc/sched.c 8 Mar 2003 22:46:11 -0000 @@ -168,10 +168,8 @@ void rpc_add_timer(struct rpc_task *task static inline void rpc_delete_timer(struct rpc_task *task) { - if (timer_pending(&task->tk_timer)) { + if (del_timer_sync(&task->tk_timer)) dprintk("RPC: %4d deleting timer\n", task->tk_pid); - del_timer_sync(&task->tk_timer); - } } =20 /* --=20 Danny Smith Senior Systems Administrator, Cinesite (Europe) Ltd 020 7973 4000 - x4055 / dannys@cinesite.co.uk ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs