From: Trond Myklebust Subject: Re: [PATCH 2.6.3] Add write throttling to NFS client Date: Fri, 05 Mar 2004 23:15:46 -0500 Sender: nfs-admin@lists.sourceforge.net Message-ID: <1078546545.4847.70.camel@nidelv.trondhjem.org> References: <20040306035627.79190.qmail@web12822.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Cc: Shantanu Goel , Bogdan Costescu , Charles Lever , Olaf Kirch , Greg Banks , nfs@lists.sourceforge.net Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list2.sourceforge.net with esmtp (Exim 4.30) id 1AzTL0-00033j-PW for nfs@lists.sourceforge.net; Fri, 05 Mar 2004 20:22:58 -0800 Received: from dh197.citi.umich.edu ([141.211.133.197] helo=nidelv.trondhjem.org ident=Debian-exim) by sc8-sf-mx1.sourceforge.net with esmtp (TLSv1:RC4-SHA:128) (Exim 4.30) id 1AzTEA-0007pD-U0 for nfs@lists.sourceforge.net; Fri, 05 Mar 2004 20:15:55 -0800 To: Shantanu Goel In-Reply-To: <20040306035627.79190.qmail@web12822.mail.yahoo.com> Errors-To: nfs-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Post: List-Help: List-Subscribe: , List-Archive: P=E5 fr , 05/03/2004 klokka 22:56, skreiv Shantanu Goel: > > Were there any other cases that I missed? >=20 > The only other one I can see is nfs_writepage_sync().=20 Doh... Right you are. I shouldn't be checking code on a full stomach... > One more thing I just noticed in nfs_writepages(), the > return status of nfs_wait_on_write_congestion() is not > checked. Do we want to ignore signals here? The return value will always be zero, since nfs_write_congestion() is called with "intr" set to 0. My gut feeling here is that pdflush et al. should ignore signals. If they don't then we will end up with a memory leak. I'm open to being persuaded that this might be wrong, though... Cheers, Trond ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs