From: Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: rpc.mountd stops functioning
Date: Fri, 27 Aug 2004 13:31:20 +1000
Sender: nfs-admin@lists.sourceforge.net
Message-ID: <16686.43784.910598.870375@cse.unsw.edu.au>
References: <411217BE.8070209@framestore-cfc.com>
	<20040805144659.GD25948@fieldses.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: nfs@lists.sourceforge.net
To: "J. Bruce Fields" <bfields@fieldses.org>
In-Reply-To: message from J. Bruce Fields on Thursday August 5
Errors-To: nfs-admin@lists.sourceforge.net

On Thursday August 5, bfields@fieldses.org wrote:
> On Thu, Aug 05, 2004 at 12:19:26PM +0100, Johan van den Dorpe wrote:
> > For a long time we've been experiencing problems with rpc.mountd 
> > stopping functioning.
> 
> Maybe you need the following?
> 
> (Neil or someone, could you please apply this?  Last I checked it wasn't
> in nfs-utils cvs.)

I don't think this patch is needed (though it wouldn't actually break anything).
The loop in svc_run.c starts:


		readfds = svc_fdset;
		cache_set_fds(&readfds);

so readfds is completely initialised at the top of the loop, so
clearing something at the bottom (which is essentially what this patch
does) should be a no-op.

Am I wrong?

NeilBrown

> 
> --Bruce Fields
> 
> >From Garrick Staples <garrick@usc.edu>:
> 
> After mountd handles a cache upcall, we should clear the relevant bits in the
> fd_set.
> 
> ---
> 
>  nfs-utils-1.0.6-bfields/utils/mountd/cache.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff -puN utils/mountd/cache.c~cache_select_bugfix utils/mountd/cache.c
> --- nfs-utils-1.0.6/utils/mountd/cache.c~cache_select_bugfix	2004-07-14 12:52:57.000000000 -0400
> +++ nfs-utils-1.0.6-bfields/utils/mountd/cache.c	2004-07-14 12:52:57.000000000 -0400
> @@ -315,6 +315,7 @@ int cache_process_req(fd_set *readfds) 
>  		    FD_ISSET(fileno(cachelist[i].f), readfds)) {
>  			cnt++;
>  			cachelist[i].cache_handle(cachelist[i].f);
> +			FD_CLR(fileno(cachelist[i].f), readfds);
>  		}
>  	}
>  	return cnt;
> _
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by OSTG. Have you noticed the changes on
> Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
> one more big change to announce. We are now OSTG- Open Source Technology
> Group. Come see the changes on the new OSTG site. www.ostg.com
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs