From: Nick Wilson <njw@osdl.org>
Subject: Re: [PATCH 3/3]: NFS: Introduce the use of inode->i_lock to protect fields in nfsi
Date: Tue, 12 Jul 2005 09:52:47 -0700
Message-ID: <20050712165247.GA9097@njw.pdx.osdl.net>
References: <482A3FA0050D21419C269D13989C611308539D87@lavender-fe.eng.netapp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Bill Rugolsky Jr." <brugolsky@telemetry-investments.com>,
	nfs@lists.sourceforge.net
To: "Lever, Charles" <Charles.Lever@netapp.com>
In-Reply-To: <482A3FA0050D21419C269D13989C611308539D87@lavender-fe.eng.netapp.com>
Sender: nfs-admin@lists.sourceforge.net
Errors-To: nfs-admin@lists.sourceforge.net

On Sat, Jul 09, 2005 at 08:33:58AM -0700, Lever, Charles wrote:
>  Down the road we want to eliminate the use of the global kernel lock
>  entirely from the NFS client.  To do this, we need to protect the fields
>  in the nfs_inode structure adequately.  Start by serializing updates to
>  the "cache_validity" field.
> 
>  Note this change addresses an SMP hang found by njw@osdl.org, where
>  processes deadlock because nfs_end_data_update and nfs_revalidate_mapping
>  update the "cache_validity" field without proper serialization.
> 
>  Test plan:
>  Millions of fsx ops on SMP clients.  Run Nick Wilson's breaknfs program on
>  large SMP clients.

breaknfs has been running fine on an 8-way for nearly 24 hours.
Considering it locks up in minutes without these patches, I'd say that
these fix my problem :)

Nick Wilson


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP, 
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs