From: Vince Busam <vbusam@google.com>
Subject: Re: [PATCH] Fix typo on __rpc_purge_upcall
Date: Mon, 12 Dec 2005 12:33:01 -0800
Message-ID: <439DDE7D.3050904@google.com>
References: <4382252E.4000602@google.com>	 <1132602917.8011.2.camel@lade.trondhjem.org> <43824151.5060604@google.com>	 <1132612440.8011.7.camel@lade.trondhjem.org> <4382515C.9020200@google.com>	 <1132614431.8011.14.camel@lade.trondhjem.org> <438B4983.3030809@google.com>	 <1133203961.27574.66.camel@lade.trondhjem.org>	 <4394AB2E.1030809@google.com>  <439DC809.3020502@google.com> <1134415137.7877.10.camel@lade.trondhjem.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Cc: nfs@lists.sourceforge.net
To: Trond Myklebust <trond.myklebust@fys.uio.no>
In-Reply-To: <1134415137.7877.10.camel@lade.trondhjem.org>
Sender: nfs-admin@lists.sourceforge.net
Errors-To: nfs-admin@lists.sourceforge.net

Trond Myklebust wrote:
> On Mon, 2005-12-12 at 10:57 -0800, Vince Busam wrote:
> 
>>I applied this patch from 2.6.15-rc5, and got the following oops.  I really wish I could 
>>reproduce this faster, but it still only happens over the weekend when my credentials have 
>>expired.  Letting them expire during the week doesn't reproduce it.
> 
> 
> Could you send us the contents of rpc_close_pipes() and
> rpc_pipe_release()?
> 
> I cannot see how rpc_pipe_release can be calling __rpc_purge_upcall with
> a null entry for rpci->ops: the inode->i_sem should be protecting it
> from changing.

static void
rpc_close_pipes(struct inode *inode)
{
         struct rpc_inode *rpci = RPC_I(inode);

         cancel_delayed_work(&rpci->queue_timeout);
         flush_scheduled_work();
         down(&inode->i_sem);
         if (rpci->ops != NULL) {
                 rpci->nreaders = 0;
                 __rpc_purge_list(rpci, &rpci->in_upcall, -EPIPE);
                 __rpc_purge_upcall(inode, -EPIPE);
                 rpci->nwriters = 0;
                 if (rpci->ops->release_pipe)
                         rpci->ops->release_pipe(inode);
                 rpci->ops = NULL;
         }
         rpc_inode_setowner(inode, NULL);
         up(&inode->i_sem);
}

static int
rpc_pipe_release(struct inode *inode, struct file *filp)
{
         struct rpc_inode *rpci = RPC_I(filp->f_dentry->d_inode);
         struct rpc_pipe_msg *msg;

         down(&inode->i_sem);
         if (rpci->ops == NULL)
                 goto out;
         msg = (struct rpc_pipe_msg *)filp->private_data;
         if (msg != NULL) {
                 msg->errno = -EPIPE;
                 list_del_init(&msg->list);
                 rpci->ops->destroy_msg(msg);
         }
         if (filp->f_mode & FMODE_WRITE)
                 rpci->nwriters --;
         if (filp->f_mode & FMODE_READ)
                 rpci->nreaders --;
         if (!rpci->nreaders)
                 __rpc_purge_upcall(inode, -EPIPE);
         if (rpci->ops->release_pipe)
                 rpci->ops->release_pipe(inode);
out:
         up(&inode->i_sem);
         return 0;
}


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs