From: Amit Gud Subject: Re: [PATCH 1 / 1] Move NFS mount code from util-linux to nfs-utils - take2 Date: Mon, 12 Jun 2006 23:15:02 -0400 Message-ID: <448E2DB6.6050209@redhat.com> References: <448DF37C.4000109@redhat.com> <1150165495.3061.19.camel@raven.themaw.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Neil Brown , gud@eth.net, nfs@lists.sourceforge.net, Steve Dickson Return-path: Received: from sc8-sf-list2-b.sourceforge.net ([10.3.1.8] helo=sc8-sf-list2.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1FpzK6-0002TV-58 for nfs@lists.sourceforge.net; Mon, 12 Jun 2006 20:12:10 -0700 Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2.sourceforge.net with esmtp (Exim 4.30) id 1FpzK6-00022i-Bf for nfs@lists.sourceforge.net; Mon, 12 Jun 2006 20:12:10 -0700 Received: from mx1.redhat.com ([66.187.233.31]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1FpzK4-0005dB-WF for nfs@lists.sourceforge.net; Mon, 12 Jun 2006 20:12:10 -0700 To: Ian Kent In-Reply-To: <1150165495.3061.19.camel@raven.themaw.net> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net Ian Kent wrote: > On Mon, 2006-06-12 at 19:06 -0400, Amit Gud wrote: >> Neil, >> >> It avoids code duplication (of parsing the options and error checking) >> if we don't branch two different binaries for the NFSv4 and older versions. >> > >> + >> + if(!nomtab) >> + add_mtab(spec, mount_point, nfs_mount_vers == 4 ? "nfs4" : "nfs", >> + flags, extra_opts, 0, 0); > > If mtab~ is busy won't this cause mtab to get out of sync? > Cannot really spin over until the file lock is achieved, it may potentially never be. AG -- May the source be with you. http://www.cis.ksu.edu/~gud _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs