From: Frank Filz <ffilzlnx@us.ibm.com>
Subject: [PATCH] expkey_parse doesn't handle type 3 exports (was Re: [NFS]
 Problems with fh_fsid_type=3 exports (device minor id > 255))
Date: Thu, 01 Jun 2006 10:51:59 -0700
Message-ID: <1149184319.12795.63.camel@dyn9047022153>
References: <1148669319.12795.44.camel@dyn9047022153>
	 <1149115719.12795.49.camel@dyn9047022153>
	 <1149117333.12795.53.camel@dyn9047022153>
	 <17534.24605.250498.8288@cse.unsw.edu.au>
	 <1149175424.12795.57.camel@dyn9047022153>
Mime-Version: 1.0
Content-Type: text/plain
Cc: NFS List <nfs@lists.sourceforge.net>,
	Trond Myklebust <trond.myklebust@fys.uio.no>
To: Neil Brown <neilb@suse.de>
In-Reply-To: <1149175424.12795.57.camel@dyn9047022153>
Sender: nfs-admin@lists.sourceforge.net
Errors-To: nfs-admin@lists.sourceforge.net

On Thu, 2006-06-01 at 08:23 -0700, Frank Filz wrote:
> On Thu, 2006-06-01 at 13:33 +1000, Neil Brown wrote:
> > On Wednesday May 31, ffilzlnx@us.ibm.com wrote:
> > > 
> > > Oops, I'm horribly confused... The above code actually is right, well
> > 
> > :-)  I'm glad you got your problem sorted!
> > 
> > > mostly, I think it actually should be:
> > > 
> > > > 		major = (dev & 0xff00) >> 8;
> > > > 		minor = (dev & 0xff) | ((dev >> 12) & 0xfff00);
> > > 
> > 
> > No, major is 12 bits, minor is 20 bits. So the original code is
> > correct.
> 
> With a bit more sleep, I see that now. Thanks.
> 
> What version of nfs-utils did this show up in? It looks like the
> situation is just a mis-match of nfs-utils and kernel.

I tried the 1.0.8 version of rpc.mountd, and things almost worked, but
the mount still failed. I looked at expkey_parse, and discovered it
doesn't handle type 3 exports. The following patch fixes the problem:

Signed-Off-By: Frank Filz <ffilzlnx@us.ibm.com>

diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -132,7 +132,7 @@ static int expkey_parse(struct cache_det
 	if (*ep)
 		goto out;
 	dprintk("found fsidtype %d\n", fsidtype);
-	if (fsidtype > 2)
+	if (fsidtype > 3)
 		goto out;
 	if ((len=qword_get(&mesg, buf, PAGE_SIZE)) <= 0)
 		goto out;


-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs