From: Christoph Hellwig Subject: Re: [NFS] [PATCH] [nfsd] Add lock annotations to e_start and e_stop Date: Wed, 26 Jul 2006 09:06:56 +0100 Message-ID: <20060726080656.GA28346@infradead.org> References: <1153840824.12517.9.camel@josh-work.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Andrew Morton , nfs@lists.sourceforge.net, Neil Brown Return-path: To: Josh Triplett In-Reply-To: <1153840824.12517.9.camel@josh-work.beaverton.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Jul 25, 2006 at 08:20:24AM -0700, Josh Triplett wrote: > e_start acquires svc_export_cache.hash_lock, and e_stop releases it. Add lock > annotations to these two functions so that sparse can check callers for lock > pairing, and so that sparse will not complain about these functions since they > intentionally use locks in this manner. > > Signed-off-by: Josh Triplett The Signed-off-by: line doesn't match the from line of this mail. Is that any problem or fine in general?