From: Neil Brown Subject: Re: nfs-utils 1.0.9-rc1 - hopefully -final in a week Date: Tue, 4 Jul 2006 17:47:31 +1000 Message-ID: <17578.7443.955689.245120@cse.unsw.edu.au> References: <17576.25386.427824.894874@cse.unsw.edu.au> <1151912016.18333.4.camel@hole.melbourne.sgi.com> <17577.47377.412223.132567@cse.unsw.edu.au> <1151986622.18333.189.camel@hole.melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Linux NFS Mailing List Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1FxfdL-0000tX-Bs for nfs@lists.sourceforge.net; Tue, 04 Jul 2006 00:47:47 -0700 Received: from mx2.suse.de ([195.135.220.15]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1FxfdJ-0000FL-4r for nfs@lists.sourceforge.net; Tue, 04 Jul 2006 00:47:47 -0700 To: Greg Banks In-Reply-To: message from Greg Banks on Tuesday July 4 List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Tuesday July 4, gnb@melbourne.sgi.com wrote: > On Tue, 2006-07-04 at 10:40, Neil Brown wrote: > > For the generates *xdr.c files, what would you think of this change? > > It seems to do the right thing. Each variable declaration is followed > > by a (void) usage of it. Slightly gross, but auto-generated code > > often is ;-) > > I think the following patch is cleaner. It eliminates the > warnings about `buf' being unused by generating the declaration > on first demand. As a result most XDR routines don't have > a `buf' declaration at all; those that do inlining have two, > one each in the encode and decode branch. Comments? My likey. > > I'll see if I can do something equivalent for that pesky `i' too. That seems to be very straight forward. The only place that the 'i' variable is used is in code generated by emit_inline, and that is already in a local block where 'genp' is declared. We can just declare 'i' at the same time. I'll add that to your patch and stick it in .git Thanks, NeilBrown Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs