From: Greg Banks <gnb@melbourne.sgi.com>
Subject: Re: nfs-utils 1.0.9-rc1 - hopefully -final in a week
Date: Tue, 04 Jul 2006 17:56:36 +1000
Message-ID: <1151999796.18333.210.camel@hole.melbourne.sgi.com>
References: <17576.25386.427824.894874@cse.unsw.edu.au>
	<1151912016.18333.4.camel@hole.melbourne.sgi.com>
	<17577.47377.412223.132567@cse.unsw.edu.au>
	<1151986622.18333.189.camel@hole.melbourne.sgi.com>
	<17578.7443.955689.245120@cse.unsw.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: Linux NFS Mailing List <nfs@lists.sourceforge.net>
To: Neil Brown <neilb@suse.de>
In-Reply-To: <17578.7443.955689.245120@cse.unsw.edu.au>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Tue, 2006-07-04 at 17:47, Neil Brown wrote:
> The only place that the 'i' variable is used is in code generated by
> emit_inline, and that is already in a local block where 'genp'
> is declared.  We can just declare 'i' at the same time.
> 
> I'll add that to your patch and stick it in .git

Yep.  That leaves just two warnings.

The first is the whiny message about the result of IXDR_PUT_SHORT()
not being used.  I can't see any way around that except a (void)
cast, like this:

diff-tree cdb0a2d31b63eb6a25ea518a8adcb5029ab6c460 (from 65ae2312a99cb36fbcf4b369200de365810b7015)
Author: Greg Banks <gnb@melbourne.sgi.com>
Date:   Tue Jul 4 17:54:42 2006 +1000

    Remove warning about unused value of IXDR_PUT_{LONG,SHORT}.

diff --git a/tools/rpcgen/rpc_cout.c b/tools/rpcgen/rpc_cout.c
index f78961c..9c32b8a 100644
--- a/tools/rpcgen/rpc_cout.c
+++ b/tools/rpcgen/rpc_cout.c
@@ -646,7 +646,7 @@ emit_single_in_line(declaration *decl, i
 	int freed=0;
 
 	if(flag == PUT)
-		f_print(fout,"\t\t IXDR_PUT_");
+		f_print(fout,"\t\t (void) IXDR_PUT_");
 	else    
 		if(rel== REL_ALIAS)
 			f_print(fout,"\t\t objp->%s = IXDR_GET_",decl->name);


Then there's the type-punned pointer warning.  I hate those.


Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs